Many files were in the autoloader despite having potentially harmful file-scope code. * Exclude all CommandLineInc maintenance scripts from the autoloader. * Introduce "NO_AUTOLOAD" tag which excludes the file containing it from the autoloader. Use it on CommandLineInc.php and a few suspicious-looking files without classes in case they are refactored to add classes in the future. * Add a test which parses all non-PSR4 class files and confirms that they do not contain dangerous file-scope code. It's slow (15s) but its results were enlightening. * Several maintenance scripts define constants in the file scope, intending to modify the behaviour of MediaWiki. Either move the define() to a later setup function, or protect with NO_AUTOLOAD. * Use require_once consistently with Maintenance.php and doMaintenance.php, per the original convention which is supposed to allow one maintenance script to use the class of another maintenance script. Using require breaks autoloading of these maintenance class files. * When Maintenance.php is included, check if MediaWiki has already started, and if so, return early. Revert the fix for T250003 which is incompatible with this safety measure. Hopefully it was superseded by splitting out the class file. * In runScript.php add a redundant PHP_SAPI check since it does some things in file-scope code before any other check will be run. * Change the if(false) class_alias(...) to something more hackish and more compatible with the new test. * Some site-related scripts found Maintenance.php in a non-standard way. Use the standard way. * fileOpPerfTest.php called error_reporting(). Probably debugging code left in; removed. * Moved mediawiki.compress.7z registration from the class file to the caller. Change-Id: I1b1be90343a5ab678df6f1b1bdd03319dcf6537f
72 lines
2.2 KiB
PHP
72 lines
2.2 KiB
PHP
<?php
|
|
/**
|
|
* Efficient concatenated text storage.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
/**
|
|
* To speed up conversion from 1.4 to 1.5 schema, text rows can refer to the
|
|
* leftover cur table as the backend. This avoids expensively copying hundreds
|
|
* of megabytes of data during the conversion downtime.
|
|
*
|
|
* Serialized HistoryBlobCurStub objects will be inserted into the text table
|
|
* on conversion if $wgLegacySchemaConversion is set to true.
|
|
*/
|
|
class HistoryBlobCurStub {
|
|
/** @var int */
|
|
public $mCurId;
|
|
|
|
/**
|
|
* @param int $curid The cur_id pointed to
|
|
*/
|
|
public function __construct( $curid = 0 ) {
|
|
$this->mCurId = $curid;
|
|
}
|
|
|
|
/**
|
|
* Sets the location (cur_id) of the main object to which this object
|
|
* points
|
|
*
|
|
* @param int $id
|
|
*/
|
|
public function setLocation( $id ) {
|
|
$this->mCurId = $id;
|
|
}
|
|
|
|
/**
|
|
* @return string|bool
|
|
*/
|
|
public function getText() {
|
|
$dbr = wfGetDB( DB_REPLICA );
|
|
$row = $dbr->selectRow( 'cur', [ 'cur_text' ], [ 'cur_id' => $this->mCurId ], __METHOD__ );
|
|
if ( !$row ) {
|
|
return false;
|
|
}
|
|
return $row->cur_text;
|
|
}
|
|
}
|
|
|
|
// Blobs generated by MediaWiki < 1.5 on PHP 4 were serialized with the
|
|
// class name coerced to lowercase. We can improve efficiency by adding
|
|
// autoload entries for the lowercase variants of these classes (T166759).
|
|
// The code below is never executed, but it is picked up by the AutoloadGenerator
|
|
// parser, which scans for class_alias() calls.
|
|
/*
|
|
class_alias( HistoryBlobCurStub::class, 'historyblobcurstub' );
|
|
*/
|