3b9d758274
Follows-up 1d77070f19. On Travis CI, this test fails on HHVM:
> There was 1 failure:
> 1) DeprecatedGlobalTest::testWarning
> Failed asserting that exception of type "PHPUnit_Framework_Error" is thrown.
I've been unable to reproduce this locally, but within Travis CI
it happens on both Trusty containers and Trusty VMs, no matter the
version of HHVM. After some trial and error, I narrowed it down
to the error_reporting setting, which presumably has a different default
in the HHVM package Travis CI uses.
Change-Id: I588218103d6c72df5ad4fb6289df688b3740233e
81 lines
2.3 KiB
PHP
81 lines
2.3 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
/**
|
|
* @covers DeprecatedGlobal
|
|
*/
|
|
class DeprecatedGlobalTest extends MediaWikiTestCase {
|
|
|
|
public function setUp() {
|
|
parent::setUp();
|
|
$this->oldErrorLevel = error_reporting( -1 );
|
|
}
|
|
|
|
public function tearDown() {
|
|
error_reporting( $this->oldErrorLevel );
|
|
parent::tearDown();
|
|
}
|
|
|
|
public function testObjectDeStub() {
|
|
global $wgDummy;
|
|
|
|
$wgDummy = new DeprecatedGlobal( 'wgDummy', new HashBagOStuff(), '1.30' );
|
|
$this->assertInstanceOf( DeprecatedGlobal::class, $wgDummy );
|
|
|
|
$this->hideDeprecated( '$wgDummy' );
|
|
// Trigger de-stubification
|
|
$wgDummy->get( 'foo' );
|
|
|
|
$this->assertInstanceOf( HashBagOStuff::class, $wgDummy );
|
|
}
|
|
|
|
public function testLazyLoad() {
|
|
global $wgDummyLazy;
|
|
|
|
$called = false;
|
|
$factory = function () use ( &$called ) {
|
|
$called = true;
|
|
return new HashBagOStuff();
|
|
};
|
|
|
|
$wgDummyLazy = new DeprecatedGlobal( 'wgDummyLazy', $factory, '1.30' );
|
|
$this->assertInstanceOf( DeprecatedGlobal::class, $wgDummyLazy );
|
|
|
|
$this->hideDeprecated( '$wgDummyLazy' );
|
|
$this->assertFalse( $called );
|
|
// Trigger de-stubification
|
|
$wgDummyLazy->get( 'foo' );
|
|
$this->assertTrue( $called );
|
|
$this->assertInstanceOf( HashBagOStuff::class, $wgDummyLazy );
|
|
}
|
|
|
|
/**
|
|
* @expectedException PHPUnit_Framework_Error
|
|
* @expectedExceptionMessage Use of $wgDummy1 was deprecated in MediaWiki 1.30
|
|
*/
|
|
public function testWarning() {
|
|
global $wgDummy1;
|
|
|
|
$wgDummy1 = new DeprecatedGlobal( 'wgDummy1', new HashBagOStuff(), '1.30' );
|
|
$wgDummy1->get( 'foo' );
|
|
$this->assertInstanceOf( HashBagOStuff::class, $wgDummy1 );
|
|
}
|
|
|
|
}
|