The patch set from I5d502b5 re-introduced the use of realpath() within AutoloadGenerator::readFile() as part of a set of changes to ensure that path separators are normalized across Unix and Windows systems. As noted previously in I4623b3d, the use of realpath() in this function will cause fatal exceptions to be thrown when a file such as LocalSettings.php is a symlink to a file outside to $IP. This patch separates the path normalization functionality from realpath() expansion and uses only the path normalization component within AutoloadGenerator::readFile(). It also introduces a cautionary comment in AutoloadGenerator::readFile() that will hopefully keep realpath() from being reintroduced there. Change-Id: I4923dfa8370a7bd6077f42ff4c437d7293fdad66 |
||
|---|---|---|
| .. | ||
| AutoloadGenerator.php | ||
| IP.php | ||
| MWCryptHKDF.php | ||
| MWCryptRand.php | ||
| MWFunction.php | ||
| README | ||
| StringUtils.php | ||
| UIDGenerator.php | ||
| ZipDirectoryReader.php | ||
The classes in this directory are general utilities for use by any part of MediaWiki. They do not favour any particular user interface and are not constrained to serve any particular feature. This is similar to includes/libs, except that some dependency on the MediaWiki framework (such as the use of MWException, Status or wfDebug()) disqualifies them from use outside of MediaWiki without modification. Utilities should not use global configuration variables, rather they should rely on the caller to configure their behaviour.