06c1a5976c
Benefit of keeping the parameter optional: - In maintenance scripts that really only have one parameter, it's a little more convenient to be able to ask for *the* parameter via an empty getArg(). Disadvantages: - It's unclear what getArg() means when there is no indication *which* argument the code asks for. This might as well return the last argument, or an array of all arguments. - In scripts with two or more arguments, it's confusing to see getArg( 1 ) next to an empty getArg(). - The methods are more complex and a bit more complicated to use with the extra feature of this parameter being optional. Users need to look up what the default is to be able to use it safely. Change-Id: I22a43bfdfc0f0c9ffdb468c13aba73b888d1f15e
77 lines
2.1 KiB
PHP
77 lines
2.1 KiB
PHP
<?php
|
|
/**
|
|
* Test JavaScript validity parses using jsmin+'s parser
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @ingroup Maintenance
|
|
*/
|
|
|
|
require_once __DIR__ . '/Maintenance.php';
|
|
|
|
/**
|
|
* Maintenance script to test JavaScript validity using JsMinPlus' parser
|
|
*
|
|
* @ingroup Maintenance
|
|
*/
|
|
class JSParseHelper extends Maintenance {
|
|
public $errs = 0;
|
|
|
|
public function __construct() {
|
|
parent::__construct();
|
|
$this->addDescription( 'Runs parsing/syntax checks on JavaScript files' );
|
|
$this->addArg( 'file(s)', 'JavaScript file to test', false );
|
|
}
|
|
|
|
public function execute() {
|
|
if ( $this->hasArg( 0 ) ) {
|
|
$files = $this->mArgs;
|
|
} else {
|
|
$this->maybeHelp( true ); // @todo fixme this is a lame API :)
|
|
exit( 1 ); // it should exit from the above first...
|
|
}
|
|
|
|
$parser = new JSParser();
|
|
foreach ( $files as $filename ) {
|
|
Wikimedia\suppressWarnings();
|
|
$js = file_get_contents( $filename );
|
|
Wikimedia\restoreWarnings();
|
|
if ( $js === false ) {
|
|
$this->output( "$filename ERROR: could not read file\n" );
|
|
$this->errs++;
|
|
continue;
|
|
}
|
|
|
|
try {
|
|
$parser->parse( $js, $filename, 1 );
|
|
} catch ( Exception $e ) {
|
|
$this->errs++;
|
|
$this->output( "$filename ERROR: " . $e->getMessage() . "\n" );
|
|
continue;
|
|
}
|
|
|
|
$this->output( "$filename OK\n" );
|
|
}
|
|
|
|
if ( $this->errs > 0 ) {
|
|
exit( 1 );
|
|
}
|
|
}
|
|
}
|
|
|
|
$maintClass = JSParseHelper::class;
|
|
require_once RUN_MAINTENANCE_IF_MAIN;
|