31fcbb83c1
wfParseUrl falls back to the global service locator as of I706ef8a5. This will soon be disallowed in unit tests (see I5117eab9), and all the classes updated in this patch are covered by a unit test that would then fail. SiteConfig already has a UrlUtils object available, so just use that. In the other classes, there is no need to inject a UrlUtils service and we can instead adopt parse_url, because these didn't depend on our site-configurable or custom parsing logic. For precedent see also change I6492f5142861513e4a7, I1e76d2f5aef, and lots of other examples in Codesearch for parse_url(). The warnings about parse_url() in UrlUtils.php have been obsolete since about PHP 5.4, when it started to support protocol-relative URLs, non-slash protocols like "mailto", and deal with spaces/newlines correctly (https://3v4l.org/YWUkl). This patch was partly copied from PS 20 of I5117eab9. Co-Authored-by: Timo Tijhof <krinkle@fastmail.com> Change-Id: I98ea4670e842d11598664f058d8c90a900477be4 |
||
|---|---|---|
| .. | ||
| Config | ||
| LanguageVariantConverterUnitTest.php | ||
| PageBundleParserOutputConverterTest.php | ||
| ParsoidRenderIdTest.php | ||