All services required by LinkBatch are now injected by the LinkBatchFactory. The constructor for LinkBatch has been soft-deprecated, but the required services are still optional. Bug: T239855 Depends-On: If49cbb730d4ac48586b891908cf24601efbc5d6a Change-Id: I93d931ab60305ad49a6e419f8269c77791a3938d
236 lines
6.3 KiB
PHP
236 lines
6.3 KiB
PHP
<?php
|
|
|
|
use Wikimedia\AtEase\AtEase;
|
|
use Wikimedia\Rdbms\ILoadBalancer;
|
|
|
|
/**
|
|
* @group Database
|
|
* @group Cache
|
|
* @covers LinkBatch
|
|
*/
|
|
class LinkBatchTest extends MediaWikiIntegrationTestCase {
|
|
|
|
/**
|
|
* @covers LinkBatch::__construct()
|
|
* @covers LinkBatch::getSize()
|
|
* @covers LinkBatch::isEmpty()
|
|
*/
|
|
public function testConstructEmpty() {
|
|
$batch = new LinkBatch();
|
|
|
|
$this->assertTrue( $batch->isEmpty() );
|
|
$this->assertSame( 0, $batch->getSize() );
|
|
}
|
|
|
|
/**
|
|
* @covers LinkBatch::__construct()
|
|
* @covers LinkBatch::getSize()
|
|
* @covers LinkBatch::isEmpty()
|
|
*/
|
|
public function testConstruct() {
|
|
$batch = new LinkBatch( [
|
|
new TitleValue( NS_MAIN, 'Foo' ),
|
|
new TitleValue( NS_TALK, 'Bar' ),
|
|
] );
|
|
|
|
$this->assertFalse( $batch->isEmpty() );
|
|
$this->assertSame( 2, $batch->getSize() );
|
|
}
|
|
|
|
/**
|
|
* @covers LinkBatch::__construct()
|
|
* @covers LinkBatch::getSize()
|
|
* @covers LinkBatch::isEmpty()
|
|
*/
|
|
public function testConstructEmptyWithServices() {
|
|
$batch = new LinkBatch(
|
|
[],
|
|
$this->createMock( LinkCache::class ),
|
|
$this->createMock( TitleFormatter::class ),
|
|
$this->createMock( Language::class ),
|
|
$this->createMock( GenderCache::class ),
|
|
$this->createMock( ILoadBalancer::class )
|
|
);
|
|
|
|
$this->assertTrue( $batch->isEmpty() );
|
|
$this->assertSame( 0, $batch->getSize() );
|
|
}
|
|
|
|
/**
|
|
* @covers LinkBatch::__construct()
|
|
* @covers LinkBatch::getSize()
|
|
* @covers LinkBatch::isEmpty()
|
|
*/
|
|
public function testConstructWithServices() {
|
|
$batch = new LinkBatch(
|
|
[
|
|
new TitleValue( NS_MAIN, 'Foo' ),
|
|
new TitleValue( NS_TALK, 'Bar' ),
|
|
],
|
|
$this->createMock( LinkCache::class ),
|
|
$this->createMock( TitleFormatter::class ),
|
|
$this->createMock( Language::class ),
|
|
$this->createMock( GenderCache::class ),
|
|
$this->createMock( ILoadBalancer::class )
|
|
);
|
|
|
|
$this->assertFalse( $batch->isEmpty() );
|
|
$this->assertSame( 2, $batch->getSize() );
|
|
}
|
|
|
|
/**
|
|
* @covers LinkBatch::addObj()
|
|
* @covers LinkBatch::getSize()
|
|
*/
|
|
public function testAddObj() {
|
|
$batch = new LinkBatch(
|
|
[
|
|
new TitleValue( NS_MAIN, 'Foo' )
|
|
],
|
|
$this->createMock( LinkCache::class ),
|
|
$this->createMock( TitleFormatter::class ),
|
|
$this->createMock( Language::class ),
|
|
$this->createMock( GenderCache::class ),
|
|
$this->createMock( ILoadBalancer::class )
|
|
);
|
|
|
|
$batch->addObj( new TitleValue( NS_TALK, 'Bar' ) );
|
|
$batch->addObj( new TitleValue( NS_MAIN, 'Foo' ) );
|
|
|
|
$this->assertSame( 2, $batch->getSize() );
|
|
}
|
|
|
|
/**
|
|
* @covers LinkBatch::add()
|
|
* @covers LinkBatch::getSize()
|
|
*/
|
|
public function testAdd() {
|
|
$batch = new LinkBatch(
|
|
[
|
|
new TitleValue( NS_MAIN, 'Foo' )
|
|
],
|
|
$this->createMock( LinkCache::class ),
|
|
$this->createMock( TitleFormatter::class ),
|
|
$this->createMock( Language::class ),
|
|
$this->createMock( GenderCache::class ),
|
|
$this->createMock( ILoadBalancer::class )
|
|
);
|
|
|
|
$batch->add( NS_TALK, 'Bar' );
|
|
$batch->add( NS_MAIN, 'Foo' );
|
|
|
|
$this->assertSame( 2, $batch->getSize() );
|
|
}
|
|
|
|
public function testExecute() {
|
|
$existing1 = $this->getExistingTestPage( __METHOD__ . '1' )->getTitle();
|
|
$existing2 = $this->getExistingTestPage( __METHOD__ . '2' )->getTitle();
|
|
$nonexisting1 = $this->getNonexistingTestPage( __METHOD__ . 'x' )->getTitle();
|
|
$nonexisting2 = $this->getNonexistingTestPage( __METHOD__ . 'y' )->getTitle();
|
|
|
|
$cache = $this->getMockBuilder( LinkCache::class )
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$good = [];
|
|
$bad = [];
|
|
|
|
$cache->expects( $this->exactly( 2 ) )
|
|
->method( 'addGoodLinkObjFromRow' )
|
|
->willReturnCallback( function ( TitleValue $title, $row ) use ( &$good ) {
|
|
$good["$title"] = $title;
|
|
} );
|
|
|
|
$cache->expects( $this->exactly( 2 ) )
|
|
->method( 'addBadLinkObj' )
|
|
->willReturnCallback( function ( TitleValue $title ) use ( &$bad ) {
|
|
$bad["$title"] = $title;
|
|
} );
|
|
|
|
$services = \MediaWiki\MediaWikiServices::getInstance();
|
|
|
|
$batch = new LinkBatch(
|
|
[],
|
|
$cache,
|
|
// TODO: This would be even better with mocked dependencies
|
|
$services->getTitleFormatter(),
|
|
$services->getContentLanguage(),
|
|
$services->getGenderCache(),
|
|
$services->getDBLoadBalancer()
|
|
);
|
|
|
|
$batch->addObj( $existing1 );
|
|
$batch->addObj( $existing2 );
|
|
$batch->addObj( $nonexisting1 );
|
|
$batch->addObj( $nonexisting2 );
|
|
|
|
// Bad stuff, should be skipped!
|
|
$batch->add( NS_MAIN, '_X' );
|
|
$batch->add( NS_MAIN, 'X_' );
|
|
$batch->add( NS_MAIN, '' );
|
|
|
|
AtEase::suppressWarnings();
|
|
$batch->execute();
|
|
AtEase::restoreWarnings();
|
|
|
|
$this->assertArrayHasKey( $existing1->getTitleValue()->__toString(), $good );
|
|
$this->assertArrayHasKey( $existing2->getTitleValue()->__toString(), $good );
|
|
|
|
$this->assertArrayHasKey( $nonexisting1->getTitleValue()->__toString(), $bad );
|
|
$this->assertArrayHasKey( $nonexisting2->getTitleValue()->__toString(), $bad );
|
|
}
|
|
|
|
public function testDoGenderQueryWithEmptyLinkBatch() {
|
|
$batch = new LinkBatch(
|
|
[],
|
|
$this->createMock( LinkCache::class ),
|
|
$this->createMock( TitleFormatter::class ),
|
|
$this->createNoOpMock( Language::class ),
|
|
$this->createNoOpMock( GenderCache::class ),
|
|
$this->createMock( ILoadBalancer::class )
|
|
);
|
|
|
|
static::assertFalse( $batch->doGenderQuery() );
|
|
}
|
|
|
|
public function testDoGenderQueryWithLanguageWithoutGenderDistinction() {
|
|
$language = $this->createMock( Language::class );
|
|
$language->method( 'needsGenderDistinction' )->willReturn( false );
|
|
|
|
$batch = new LinkBatch(
|
|
[],
|
|
$this->createMock( LinkCache::class ),
|
|
$this->createMock( TitleFormatter::class ),
|
|
$language,
|
|
$this->createNoOpMock( GenderCache::class ),
|
|
$this->createMock( ILoadBalancer::class )
|
|
);
|
|
$batch->addObj(
|
|
new TitleValue( NS_MAIN, 'Foo' )
|
|
);
|
|
|
|
static::assertFalse( $batch->doGenderQuery() );
|
|
}
|
|
|
|
public function testDoGenderQueryWithLanguageWithGenderDistinction() {
|
|
$language = $this->createMock( Language::class );
|
|
$language->method( 'needsGenderDistinction' )->willReturn( true );
|
|
|
|
$genderCache = $this->createMock( GenderCache::class );
|
|
$genderCache->expects( $this->once() )->method( 'doLinkBatch' );
|
|
|
|
$batch = new LinkBatch(
|
|
[],
|
|
$this->createMock( LinkCache::class ),
|
|
$this->createMock( TitleFormatter::class ),
|
|
$language,
|
|
$genderCache,
|
|
$this->createMock( ILoadBalancer::class )
|
|
);
|
|
$batch->addObj(
|
|
new TitleValue( NS_MAIN, 'Foo' )
|
|
);
|
|
|
|
static::assertTrue( $batch->doGenderQuery() );
|
|
}
|
|
}
|