9b643b639d
Also fix alphabetization in release notes Bug: T248192 Change-Id: I41c13b20d31aa75d86783a77a0a263b647a050c5
420 lines
11 KiB
PHP
420 lines
11 KiB
PHP
<?php
|
|
|
|
use MediaWiki\MediaWikiServices;
|
|
use MediaWiki\Revision\RevisionRecord;
|
|
use Wikimedia\IPUtils;
|
|
|
|
/**
|
|
* @group Database
|
|
*/
|
|
class PageArchiveTest extends MediaWikiIntegrationTestCase {
|
|
|
|
/**
|
|
* @var int
|
|
*/
|
|
protected $pageId;
|
|
|
|
/**
|
|
* @var PageArchive
|
|
*/
|
|
protected $archivedPage;
|
|
|
|
/**
|
|
* A logged out user who edited the page before it was archived.
|
|
* @var string
|
|
*/
|
|
protected $ipEditor;
|
|
|
|
/**
|
|
* Revision of the first (initial) edit
|
|
* @var RevisionRecord
|
|
*/
|
|
protected $firstRev;
|
|
|
|
/**
|
|
* Revision of the IP edit (the second edit)
|
|
* @var RevisionRecord
|
|
*/
|
|
protected $ipRev;
|
|
|
|
public function __construct( $name = null, array $data = [], $dataName = '' ) {
|
|
parent::__construct( $name, $data, $dataName );
|
|
|
|
$this->tablesUsed = array_merge(
|
|
$this->tablesUsed,
|
|
[
|
|
'page',
|
|
'revision',
|
|
'revision_comment_temp',
|
|
'ip_changes',
|
|
'text',
|
|
'archive',
|
|
'recentchanges',
|
|
'logging',
|
|
'page_props',
|
|
'comment',
|
|
'slots',
|
|
'content',
|
|
'content_models',
|
|
'slot_roles',
|
|
]
|
|
);
|
|
}
|
|
|
|
protected function addCoreDBData() {
|
|
// Blanked out to keep auto-increment values stable.
|
|
}
|
|
|
|
protected function setUp() : void {
|
|
parent::setUp();
|
|
|
|
// First create our dummy page
|
|
$page = Title::newFromText( 'PageArchiveTest_thePage' );
|
|
$page = new WikiPage( $page );
|
|
$content = ContentHandler::makeContent(
|
|
'testing',
|
|
$page->getTitle(),
|
|
CONTENT_MODEL_WIKITEXT
|
|
);
|
|
|
|
$user = $this->getTestUser()->getUser();
|
|
$page->doEditContent( $content, 'testing', EDIT_NEW, false, $user );
|
|
|
|
$this->pageId = $page->getId();
|
|
$this->firstRev = $page->getRevisionRecord();
|
|
|
|
// Insert IP revision
|
|
$this->ipEditor = '2001:db8::1';
|
|
|
|
$revisionStore = MediaWikiServices::getInstance()->getRevisionStore();
|
|
|
|
$ipTimestamp = wfTimestamp(
|
|
TS_MW,
|
|
wfTimestamp( TS_UNIX, $this->firstRev->getTimestamp() ) + 1
|
|
);
|
|
|
|
$rev = $revisionStore->newMutableRevisionFromArray( [
|
|
'text' => 'Lorem Ipsum',
|
|
'comment' => 'just a test',
|
|
'page' => $page->getId(),
|
|
'user_text' => $this->ipEditor,
|
|
'timestamp' => $ipTimestamp,
|
|
] );
|
|
|
|
$dbw = wfGetDB( DB_MASTER );
|
|
$this->ipRev = $revisionStore->insertRevisionOn( $rev, $dbw );
|
|
|
|
// Delete the page
|
|
$page->doDeleteArticleReal( 'Just a test deletion', $user );
|
|
|
|
$this->archivedPage = new PageArchive( $page->getTitle() );
|
|
}
|
|
|
|
/**
|
|
* @covers PageArchive::undeleteAsUser
|
|
* @covers PageArchive::undeleteRevisions
|
|
*/
|
|
public function testUndeleteRevisions() {
|
|
// TODO: MCR: Test undeletion with multiple slots. Check that slots remain untouched.
|
|
$revisionStore = MediaWikiServices::getInstance()->getRevisionStore();
|
|
|
|
// First make sure old revisions are archived
|
|
$dbr = wfGetDB( DB_REPLICA );
|
|
$arQuery = $revisionStore->getArchiveQueryInfo();
|
|
$row = $dbr->selectRow(
|
|
$arQuery['tables'],
|
|
$arQuery['fields'],
|
|
[ 'ar_rev_id' => $this->ipRev->getId() ],
|
|
__METHOD__,
|
|
[],
|
|
$arQuery['joins']
|
|
);
|
|
$this->assertEquals( $this->ipEditor, $row->ar_user_text );
|
|
|
|
// Should not be in revision
|
|
$row = $dbr->selectRow( 'revision', '1', [ 'rev_id' => $this->ipRev->getId() ] );
|
|
$this->assertFalse( $row );
|
|
|
|
// Should not be in ip_changes
|
|
$row = $dbr->selectRow( 'ip_changes', '1', [ 'ipc_rev_id' => $this->ipRev->getId() ] );
|
|
$this->assertFalse( $row );
|
|
|
|
// Restore the page
|
|
$this->archivedPage->undeleteAsUser( [], $this->getTestSysop()->getUser() );
|
|
|
|
// Should be back in revision
|
|
$revQuery = $revisionStore->getQueryInfo();
|
|
$row = $dbr->selectRow(
|
|
$revQuery['tables'],
|
|
$revQuery['fields'],
|
|
[ 'rev_id' => $this->ipRev->getId() ],
|
|
__METHOD__,
|
|
[],
|
|
$revQuery['joins']
|
|
);
|
|
$this->assertNotFalse( $row, 'row exists in revision table' );
|
|
$this->assertEquals( $this->ipEditor, $row->rev_user_text );
|
|
|
|
// Should be back in ip_changes
|
|
$row = $dbr->selectRow( 'ip_changes', [ 'ipc_hex' ], [ 'ipc_rev_id' => $this->ipRev->getId() ] );
|
|
$this->assertNotFalse( $row, 'row exists in ip_changes table' );
|
|
$this->assertEquals( IPUtils::toHex( $this->ipEditor ), $row->ipc_hex );
|
|
}
|
|
|
|
protected function getExpectedArchiveRows() {
|
|
return [
|
|
[
|
|
'ar_minor_edit' => '0',
|
|
'ar_user' => null,
|
|
'ar_user_text' => $this->ipEditor,
|
|
'ar_actor' => (string)User::newFromName( $this->ipEditor, false )->getActorId( $this->db ),
|
|
'ar_len' => '11',
|
|
'ar_deleted' => '0',
|
|
'ar_rev_id' => strval( $this->ipRev->getId() ),
|
|
'ar_timestamp' => $this->db->timestamp( $this->ipRev->getTimestamp() ),
|
|
'ar_sha1' => '0qdrpxl537ivfnx4gcpnzz0285yxryy',
|
|
'ar_page_id' => strval( $this->ipRev->getPageId() ),
|
|
'ar_comment_text' => 'just a test',
|
|
'ar_comment_data' => null,
|
|
'ar_comment_cid' => '2',
|
|
'ts_tags' => null,
|
|
'ar_id' => '2',
|
|
'ar_namespace' => '0',
|
|
'ar_title' => 'PageArchiveTest_thePage',
|
|
'ar_parent_id' => strval( $this->ipRev->getParentId() ),
|
|
],
|
|
[
|
|
'ar_minor_edit' => '0',
|
|
'ar_user' => (string)$this->getTestUser()->getUser()->getId(),
|
|
'ar_user_text' => $this->getTestUser()->getUser()->getName(),
|
|
'ar_actor' => (string)$this->getTestUser()->getUser()->getActorId(),
|
|
'ar_len' => '7',
|
|
'ar_deleted' => '0',
|
|
'ar_rev_id' => strval( $this->firstRev->getId() ),
|
|
'ar_timestamp' => $this->db->timestamp( $this->firstRev->getTimestamp() ),
|
|
'ar_sha1' => 'pr0s8e18148pxhgjfa0gjrvpy8fiyxc',
|
|
'ar_page_id' => strval( $this->firstRev->getPageId() ),
|
|
'ar_comment_text' => 'testing',
|
|
'ar_comment_data' => null,
|
|
'ar_comment_cid' => '1',
|
|
'ts_tags' => null,
|
|
'ar_id' => '1',
|
|
'ar_namespace' => '0',
|
|
'ar_title' => 'PageArchiveTest_thePage',
|
|
'ar_parent_id' => '0',
|
|
],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @covers PageArchive::listRevisions
|
|
*/
|
|
public function testListRevisions() {
|
|
$revisions = $this->archivedPage->listRevisions();
|
|
$this->assertEquals( 2, $revisions->numRows() );
|
|
|
|
// Get the rows as arrays
|
|
$row0 = (array)$revisions->current();
|
|
$row1 = (array)$revisions->next();
|
|
|
|
$expectedRows = $this->getExpectedArchiveRows();
|
|
|
|
$this->assertEquals(
|
|
$expectedRows[0],
|
|
$row0
|
|
);
|
|
$this->assertEquals(
|
|
$expectedRows[1],
|
|
$row1
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @covers PageArchive::listRevisions
|
|
*/
|
|
public function testListRevisions_slots() {
|
|
$revisions = $this->archivedPage->listRevisions();
|
|
|
|
$revisionStore = MediaWikiServices::getInstance()->getInstance()->getRevisionStore();
|
|
$slotsQuery = $revisionStore->getSlotsQueryInfo( [ 'content' ] );
|
|
|
|
foreach ( $revisions as $row ) {
|
|
$this->assertSelect(
|
|
$slotsQuery['tables'],
|
|
'count(*)',
|
|
[ 'slot_revision_id' => $row->ar_rev_id ],
|
|
[ [ 1 ] ],
|
|
[],
|
|
$slotsQuery['joins']
|
|
);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @covers PageArchive::listPagesBySearch
|
|
*/
|
|
public function testListPagesBySearch() {
|
|
$pages = PageArchive::listPagesBySearch( 'PageArchiveTest_thePage' );
|
|
$this->assertSame( 1, $pages->numRows() );
|
|
|
|
$page = (array)$pages->current();
|
|
|
|
$this->assertSame(
|
|
[
|
|
'ar_namespace' => '0',
|
|
'ar_title' => 'PageArchiveTest_thePage',
|
|
'count' => '2',
|
|
],
|
|
$page
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @covers PageArchive::listPagesBySearch
|
|
*/
|
|
public function testListPagesByPrefix() {
|
|
$pages = PageArchive::listPagesByPrefix( 'PageArchiveTest' );
|
|
$this->assertSame( 1, $pages->numRows() );
|
|
|
|
$page = (array)$pages->current();
|
|
|
|
$this->assertSame(
|
|
[
|
|
'ar_namespace' => '0',
|
|
'ar_title' => 'PageArchiveTest_thePage',
|
|
'count' => '2',
|
|
],
|
|
$page
|
|
);
|
|
}
|
|
|
|
public function provideGetTextFromRowThrowsInvalidArgumentException() {
|
|
yield 'missing ar_text_id field' => [ [] ];
|
|
yield 'ar_text_id is null' => [ [ 'ar_text_id' => null ] ];
|
|
yield 'ar_text_id is zero' => [ [ 'ar_text_id' => 0 ] ];
|
|
yield 'ar_text_id is "0"' => [ [ 'ar_text_id' => '0' ] ];
|
|
}
|
|
|
|
/**
|
|
* @covers PageArchive::getLastRevisionId
|
|
*/
|
|
public function testGetLastRevisionId() {
|
|
$id = $this->archivedPage->getLastRevisionId();
|
|
$this->assertSame( $this->ipRev->getId(), $id );
|
|
}
|
|
|
|
/**
|
|
* @covers PageArchive::isDeleted
|
|
*/
|
|
public function testIsDeleted() {
|
|
$this->assertTrue( $this->archivedPage->isDeleted() );
|
|
}
|
|
|
|
/**
|
|
* @covers PageArchive::getRevision
|
|
*/
|
|
public function testGetRevision() {
|
|
$this->hideDeprecated( 'PageArchive::getRevision' );
|
|
$this->hideDeprecated( 'Revision::__construct' );
|
|
$this->hideDeprecated( 'Revision::getRevisionRecord' );
|
|
|
|
$rev = $this->archivedPage->getRevision( $this->ipRev->getTimestamp() );
|
|
$this->assertNotNull( $rev );
|
|
$this->assertSame( $this->pageId, $rev->getRevisionRecord()->getPageId() );
|
|
|
|
$rev = $this->archivedPage->getRevision( '22991212115555' );
|
|
$this->assertNull( $rev );
|
|
}
|
|
|
|
/**
|
|
* @covers PageArchive::getRevisionRecordByTimestamp
|
|
*/
|
|
public function testGetRevisionRecordByTimestamp() {
|
|
$revRecord = $this->archivedPage->getRevisionRecordByTimestamp(
|
|
$this->ipRev->getTimestamp()
|
|
);
|
|
$this->assertNotNull( $revRecord );
|
|
$this->assertSame( $this->pageId, $revRecord->getPageId() );
|
|
|
|
$revRecord = $this->archivedPage->getRevisionRecordByTimestamp( '22991212115555' );
|
|
$this->assertNull( $revRecord );
|
|
}
|
|
|
|
/**
|
|
* @covers PageArchive::getArchivedRevision
|
|
*/
|
|
public function testGetArchivedRevision() {
|
|
$this->hideDeprecated( 'PageArchive::getArchivedRevision' );
|
|
$this->hideDeprecated( 'Revision::__construct' );
|
|
$this->hideDeprecated( 'Revision::getRevisionRecord' );
|
|
|
|
$rev = $this->archivedPage->getArchivedRevision( $this->ipRev->getId() );
|
|
$this->assertNotNull( $rev );
|
|
|
|
$revRecord = $rev->getRevisionRecord();
|
|
$this->assertSame( $this->ipRev->getTimestamp(), $revRecord->getTimestamp() );
|
|
$this->assertSame( $this->pageId, $revRecord->getPageId() );
|
|
|
|
$rev = $this->archivedPage->getArchivedRevision( 632546 );
|
|
$this->assertNull( $rev );
|
|
}
|
|
|
|
/**
|
|
* @covers PageArchive::getPreviousRevision
|
|
*/
|
|
public function testGetPreviousRevision() {
|
|
$this->hideDeprecated( 'PageArchive::getPreviousRevision' );
|
|
$this->hideDeprecated( 'Revision::__construct' );
|
|
$this->hideDeprecated( 'Revision::getId' );
|
|
|
|
$rev = $this->archivedPage->getPreviousRevision( $this->ipRev->getTimestamp() );
|
|
$this->assertNotNull( $rev );
|
|
$this->assertSame( $this->firstRev->getId(), $rev->getId() );
|
|
|
|
$rev = $this->archivedPage->getPreviousRevision( $this->firstRev->getTimestamp() );
|
|
$this->assertNull( $rev );
|
|
|
|
// Re-create our dummy page
|
|
$title = Title::newFromText( 'PageArchiveTest_thePage' );
|
|
$page = new WikiPage( $title );
|
|
$content = ContentHandler::makeContent(
|
|
'testing again',
|
|
$page->getTitle(),
|
|
CONTENT_MODEL_WIKITEXT
|
|
);
|
|
|
|
$user = $this->getTestUser()->getUser();
|
|
$status = $page->doEditContent( $content, 'testing', EDIT_NEW, false, $user );
|
|
|
|
/** @var RevisionRecord $newRevRecord */
|
|
$newRevRecord = $status->value['revision-record'];
|
|
|
|
// force the revision timestamp
|
|
$newTimestamp = wfTimestamp(
|
|
TS_MW,
|
|
wfTimestamp( TS_UNIX, $this->ipRev->getTimestamp() ) + 1
|
|
);
|
|
|
|
$this->db->update(
|
|
'revision',
|
|
[ 'rev_timestamp' => $this->db->timestamp( $newTimestamp ) ],
|
|
[ 'rev_id' => $newRevRecord->getId() ]
|
|
);
|
|
|
|
// check that we don't get the existing revision too soon.
|
|
$rev = $this->archivedPage->getPreviousRevision( $newTimestamp );
|
|
$this->assertNotNull( $rev );
|
|
$this->assertSame( $this->ipRev->getId(), $rev->getId() );
|
|
|
|
// check that we do get the existing revision when appropriate.
|
|
$afterNewTimestamp = wfTimestamp(
|
|
TS_MW,
|
|
wfTimestamp( TS_UNIX, $newTimestamp ) + 1
|
|
);
|
|
|
|
$rev = $this->archivedPage->getPreviousRevision( $afterNewTimestamp );
|
|
$this->assertNotNull( $rev );
|
|
$this->assertSame( $newRevRecord->getId(), $rev->getId() );
|
|
}
|
|
|
|
}
|