4938038175
This reduces confidence in the test. There is no guruantee that it won't return the same value twice during the duration of a full PHPUnit run of all test suites, whether twice in a row or 20 minutes apart. For a test that needs a string of any kind, use an explicit, consinstent and cheap literal value. For a test that specifically needs some kind of uniqueness compared to something else within the same test case, do so explicitly. Tests that require something globally unique (for some undefined/vague definition of "global") were not found, and should not exist anyway. Also, in libs/objectcache tests, fix order of parameters in some assertions (expected first, then actual), and use assertFalse/assertSame instead of assertEqual for cases where false is expected to remove tolerance of other loosely equal values. Change-Id: Ifc60e88178da471330b94bfbf12e2731d2efc77d
85 lines
2.2 KiB
PHP
85 lines
2.2 KiB
PHP
<?php
|
|
|
|
class GlobalVarConfigTest extends MediaWikiTestCase {
|
|
|
|
/**
|
|
* @covers GlobalVarConfig::newInstance
|
|
*/
|
|
public function testNewInstance() {
|
|
$config = GlobalVarConfig::newInstance();
|
|
$this->assertInstanceOf( GlobalVarConfig::class, $config );
|
|
$this->setMwGlobals( 'wgBaz', 'somevalue' );
|
|
// Check prefix is set to 'wg'
|
|
$this->assertEquals( 'somevalue', $config->get( 'Baz' ) );
|
|
}
|
|
|
|
/**
|
|
* @covers GlobalVarConfig::__construct
|
|
* @dataProvider provideConstructor
|
|
*/
|
|
public function testConstructor( $prefix ) {
|
|
$var = $prefix . 'GlobalVarConfigTest';
|
|
$this->setMwGlobals( $var, 'testvalue' );
|
|
$config = new GlobalVarConfig( $prefix );
|
|
$this->assertInstanceOf( GlobalVarConfig::class, $config );
|
|
$this->assertEquals( 'testvalue', $config->get( 'GlobalVarConfigTest' ) );
|
|
}
|
|
|
|
public static function provideConstructor() {
|
|
return [
|
|
[ 'wg' ],
|
|
[ 'ef' ],
|
|
[ 'smw' ],
|
|
[ 'blahblahblahblah' ],
|
|
[ '' ],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @covers GlobalVarConfig::has
|
|
* @covers GlobalVarConfig::hasWithPrefix
|
|
*/
|
|
public function testHas() {
|
|
$this->setMwGlobals( 'wgGlobalVarConfigTestHas', 'testvalue' );
|
|
$config = new GlobalVarConfig();
|
|
$this->assertTrue( $config->has( 'GlobalVarConfigTestHas' ) );
|
|
$this->assertFalse( $config->has( 'GlobalVarConfigTestNotHas' ) );
|
|
}
|
|
|
|
public static function provideGet() {
|
|
$set = [
|
|
'wgSomething' => 'default1',
|
|
'wgFoo' => 'default2',
|
|
'efVariable' => 'default3',
|
|
'BAR' => 'default4',
|
|
];
|
|
|
|
foreach ( $set as $var => $value ) {
|
|
$GLOBALS[$var] = $value;
|
|
}
|
|
|
|
return [
|
|
[ 'Something', 'wg', 'default1' ],
|
|
[ 'Foo', 'wg', 'default2' ],
|
|
[ 'Variable', 'ef', 'default3' ],
|
|
[ 'BAR', '', 'default4' ],
|
|
[ 'ThisGlobalWasNotSetAbove', 'wg', false ]
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideGet
|
|
* @covers GlobalVarConfig::get
|
|
* @covers GlobalVarConfig::getWithPrefix
|
|
* @param string $name
|
|
* @param string $prefix
|
|
* @param string $expected
|
|
*/
|
|
public function testGet( $name, $prefix, $expected ) {
|
|
$config = new GlobalVarConfig( $prefix );
|
|
if ( $expected === false ) {
|
|
$this->setExpectedException( ConfigException::class, 'GlobalVarConfig::get: undefined option:' );
|
|
}
|
|
$this->assertEquals( $config->get( $name ), $expected );
|
|
}
|
|
}
|