wiki.techinc.nl/tests/phpunit/includes/objectcache/ObjectCacheTest.php
Derick Alangi e0c34987eb
objectcache: Restore default keyspace for LocalServerCache service
* Fix main makeLocalServerCache() call in ObjectCacheFactory::newFromId
  to include a default keyspace, since wgCachePrefix is false by default
  (including at WMF).
* Idem for ExtensionRegistry.
* Dependency inject the domain ID so that service wiring does the
  correct thing when doing cross-wiki operations.

This is a followup on: I3179a387486377c6a575d173f39f82870c49c321.

Bug: T358346
Bug: T361177
Change-Id: Ibbb250465529810b8593f90bbb8330af0a2c3dbd
2024-03-28 19:47:44 +01:00

161 lines
4.5 KiB
PHP

<?php
use MediaWiki\MainConfigNames;
use Wikimedia\Rdbms\DatabaseDomain;
use Wikimedia\TestingAccessWrapper;
/**
* @covers \ObjectCache
* @group BagOStuff
* @group Database
*/
class ObjectCacheTest extends MediaWikiIntegrationTestCase {
protected function setUp(): void {
// Parent calls ObjectCache::clear() among other things
parent::setUp();
$this->setCacheConfig();
$this->setMainCache( CACHE_NONE );
$this->overrideConfigValues( [
MainConfigNames::MessageCacheType => CACHE_NONE,
MainConfigNames::ParserCacheType => CACHE_NONE,
] );
}
protected function tearDown(): void {
ObjectCache::$localServerCacheClass = null;
}
private function setCacheConfig( $arr = [] ) {
$defaults = [
CACHE_NONE => [ 'class' => EmptyBagOStuff::class ],
CACHE_DB => [ 'class' => SqlBagOStuff::class ],
'hash' => [ 'class' => HashBagOStuff::class ],
CACHE_ANYTHING => [ 'class' => HashBagOStuff::class ],
];
$this->overrideConfigValue( MainConfigNames::ObjectCaches, $arr + $defaults );
// Mock ACCEL with 'hash' as being installed.
// This makes tests deterministic regardless of APC.
ObjectCache::$localServerCacheClass = 'HashBagOStuff';
}
public function testNewAnythingNothing() {
$this->assertInstanceOf(
SqlBagOStuff::class,
ObjectCache::newAnything(),
'No available types. Fallback to DB'
);
}
public function testNewAnythingHash() {
$this->setMainCache( CACHE_HASH );
$this->assertInstanceOf(
HashBagOStuff::class,
ObjectCache::newAnything(),
'Use an available type (hash)'
);
}
public function testNewAnythingAccel() {
$this->setMainCache( CACHE_ACCEL );
$this->assertInstanceOf(
HashBagOStuff::class,
ObjectCache::newAnything(),
'Use an available type (CACHE_ACCEL)'
);
}
public function testNewAnythingNoAccel() {
// Mock APC not being installed (T160519, T147161)
ObjectCache::$localServerCacheClass = EmptyBagOStuff::class;
$this->setMainCache( CACHE_ACCEL );
$this->assertInstanceOf(
SqlBagOStuff::class,
ObjectCache::newAnything(),
'Fallback to DB if available types fall back to Empty'
);
}
public function testNewAnythingNoAccelNoDb() {
$this->setCacheConfig( [
// Mock APC not being installed (T160519, T147161)
CACHE_ACCEL => [ 'class' => EmptyBagOStuff::class ]
] );
$this->setMainCache( CACHE_ACCEL );
$this->getServiceContainer()->disableStorage();
$this->assertInstanceOf(
EmptyBagOStuff::class,
ObjectCache::newAnything(),
'Fallback to none if available types and DB are unavailable'
);
}
public function testNewAnythingNothingNoDb() {
$this->getServiceContainer()->disableStorage();
$this->assertInstanceOf(
EmptyBagOStuff::class,
ObjectCache::newAnything(),
'No available types or DB. Fallback to none.'
);
}
public function provideLocalServerKeyspace() {
$dbDomain = static function ( $dbName, $dbPrefix ) {
global $wgDBmwschema;
return ( new DatabaseDomain( $dbName, $wgDBmwschema, $dbPrefix ) )->getId();
};
return [
'default' => [ false, 'my_wiki', '', $dbDomain( 'my_wiki', '' ) ],
'custom' => [ 'custom', 'my_wiki', '', 'custom' ],
'prefix' => [ false, 'my_wiki', 'nl_', $dbDomain( 'my_wiki', 'nl_' ) ],
'empty string' => [ '', 'my_wiki', 'nl_', $dbDomain( 'my_wiki', 'nl_' ) ],
];
}
/**
* @dataProvider provideLocalServerKeyspace
* @covers \ObjectCache
* @covers \ObjectCacheFactory
* @covers \MediaWiki\WikiMap\WikiMap
*/
public function testLocalServerKeyspace( $cachePrefix, $dbName, $dbPrefix, $expect ) {
$this->overrideConfigValues( [
MainConfigNames::CachePrefix => $cachePrefix,
MainConfigNames::DBname => $dbName,
MainConfigNames::DBprefix => $dbPrefix,
] );
// Regression against T247562 (2020), T361177 (2024).
$cache = $this->getServiceContainer()->getObjectCacheFactory()->getInstance( CACHE_ACCEL );
$cache = TestingAccessWrapper::newFromObject( $cache );
$this->assertSame( $expect, $cache->keyspace );
}
public static function provideIsDatabaseId() {
return [
[ CACHE_DB, CACHE_NONE, true ],
[ CACHE_ANYTHING, CACHE_DB, true ],
[ CACHE_ANYTHING, 'hash', false ],
[ CACHE_ANYTHING, CACHE_ANYTHING, true ]
];
}
/**
* @dataProvider provideIsDatabaseId
* @param string|int $id
* @param string|int $mainCacheType
* @param bool $expected
*/
public function testIsDatabaseId( $id, $mainCacheType, $expected ) {
$this->overrideConfigValues( [
MainConfigNames::MainCacheType => $mainCacheType
] );
$this->assertSame( $expected, ObjectCache::isDatabaseId( $id ) );
}
}