78e2089140
Per I1702c11928f8760, tests should fail when trying to make a HTTP request, unless they have explicitely defined the desired response. This patch implements the same behavior for the newly introduced createGuzzleClient() method. Bug: T263816 Bug: T262443 Change-Id: Ie3c2efb1387ecc5bc29ff1749cae4bb33e636e9f
67 lines
1.6 KiB
PHP
67 lines
1.6 KiB
PHP
<?php
|
|
|
|
use MediaWiki\Config\ServiceOptions;
|
|
use MediaWiki\Http\HttpRequestFactory;
|
|
use PHPUnit\Framework\Assert;
|
|
use PHPUnit\Framework\AssertionFailedError;
|
|
use Psr\Log\NullLogger;
|
|
|
|
/**
|
|
* A simple {@link HttpRequestFactory} implementation that can be used to prevent
|
|
* HTTP requests in tests. All attempts to create requests will fail.
|
|
*
|
|
* Use MockHttpTrait for creating a mock factory and controlling responses.
|
|
*
|
|
* @author Daniel Kinzler
|
|
* @license GPL-2.0-or-later
|
|
*/
|
|
class NullHttpRequestFactory extends HttpRequestFactory {
|
|
|
|
public function __construct() {
|
|
$options = new ServiceOptions(
|
|
self::CONSTRUCTOR_OPTIONS, [
|
|
'HTTPTimeout' => 1,
|
|
'HTTPConnectTimeout' => 1,
|
|
'HTTPMaxTimeout' => 2,
|
|
'HTTPMaxConnectTimeout' => 2,
|
|
]
|
|
);
|
|
|
|
parent::__construct( $options, new NullLogger() );
|
|
}
|
|
|
|
/**
|
|
* Always fails.
|
|
*
|
|
* @param string $url
|
|
* @param array $options
|
|
* @param string $caller
|
|
*
|
|
* @throws AssertionFailedError always
|
|
*/
|
|
public function create( $url, array $options = [], $caller = __METHOD__ ) {
|
|
Assert::fail( "HTTP request blocked: $url by $caller. Use MockHttpTrait." );
|
|
}
|
|
|
|
/**
|
|
* Returns a NullMultiHttpClient that will fail to make any requests.
|
|
*
|
|
* @param array $options
|
|
*
|
|
* @return NullMultiHttpClient
|
|
*/
|
|
public function createMultiClient( $options = [] ) {
|
|
return new NullMultiHttpClient( $options );
|
|
}
|
|
|
|
/**
|
|
* @param array $config
|
|
*
|
|
* @return \GuzzleHttp\Client
|
|
*/
|
|
public function createGuzzleClient( array $config = [] ): \GuzzleHttp\Client {
|
|
// NOTE: if needed, we can also return a mock here, like we do in createMultiClient()
|
|
Assert::fail( "HTTP request blocked. Use MockHttpTrait." );
|
|
}
|
|
|
|
}
|