wiki.techinc.nl/tests/phpunit/includes
Thiemo Kreuz b655f382db Remove broken/outdated @param/@throws tags from @dataProviders
My personal best practice is to not document @params when there
is a @dataProvider. I mean, these test…() functions are not
meant to be called from anywhere. They do not really need
documentation. @param tags don't do much but duplicate what the
@dataProvider does. This is error-prone, as demonstrated by the
examples in this patch.

This patch also removes @throws tags from tests. A test…() can
never throw an exception. Otherwise the test would fail.

Most of these are found by the not yet released I10559d8.

Change-Id: I3782bca43f875687cd2be972144a7ab6b298454e
2021-01-21 03:42:42 +00:00
..
actions Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
api Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
auth tests: Remove @param docs from test code that just repeat the signature 2021-01-21 03:41:23 +00:00
block Revert "Enhance GroupPermissionsLookup and use it." 2021-01-12 04:48:49 +00:00
cache More misc test cleanup 2020-12-24 00:52:06 +00:00
changes More misc test cleanup 2020-12-24 00:52:06 +00:00
changetags More misc test cleanup 2020-12-24 00:52:06 +00:00
collation More misc test cleanup 2020-12-24 00:52:06 +00:00
config
content tests: Remove @param docs from test code that just repeat the signature 2021-01-21 03:41:23 +00:00
context Add Authority to Context 2021-01-20 09:07:27 -06:00
db Make unit tests assertion about assertNotEquals more strict 2020-11-01 23:12:06 +00:00
debug Merge "Emit deprecation warning for deprecated overrides." 2021-01-13 04:06:55 +00:00
deferred deferred: make DeferredUpdates::doUpdates() recursion more uniform 2021-01-14 15:37:58 -08:00
diff Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
editpage Hard deprecate NamespaceInfo::getRestrictionLevels 2020-11-16 04:40:24 +01:00
exception exception: Move remaiming MWExceptionHandler tests to its test case 2021-01-07 15:09:12 -08:00
externalstore
filebackend More misc test cleanup 2020-12-24 00:52:06 +00:00
filerepo Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
GlobalFunctions Remove hard deprecated wfIsBadImage() 2020-12-29 15:55:10 +02:00
HookContainer Prevent service injection to LoadExtensionSchemaUpdates hook 2020-09-18 08:01:52 +10:00
htmlform Make unit tests assertion about assertNotEquals more strict 2020-11-01 23:12:06 +00:00
http Add a function to HttpRequestFactory for creating a GuzzleHttp\Client 2020-10-22 23:11:47 -05:00
import Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
interwiki phpunit: Remove odd "MediaWiki" group from tests using it 2021-01-08 18:35:30 +00:00
jobqueue Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
language
libs Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
linkeddata Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
linker Replace wfGetDB with LoadBalancer in LinkCache service 2020-08-26 19:58:48 +02:00
logging Improve some function documentation in tests 2021-01-14 22:13:55 +01:00
mail Convert or split some tests to MediaWikiUnitTestCase 2021-01-07 17:51:27 +00:00
media Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
Message
Navigation
objectcache
page Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
pager Improve some function documentation in tests 2021-01-14 22:13:55 +01:00
ParamValidator/TypeDef Deprecate InterwikiLoadPrefix hook 2020-12-21 19:28:48 +00:00
parser Strict return types for PageIdentity 2021-01-18 17:33:14 +01:00
password
Permissions Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
poolcounter Fix incomplete/bogus PHPDoc tags in various tests 2021-01-14 19:02:00 +00:00
preferences
rcfeed
registration Use expectWarning/Deprecation/Notice/Error() in phpunit tests 2021-01-04 00:16:51 +00:00
resourceloader Merge "Feature file styles should precede module defined ones" 2021-01-13 14:24:44 +00:00
Rest Handle CORS preflight request and prevent anon users from unsafe methods 2020-09-21 19:29:40 -04:00
Revision Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
search Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
session Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
shell Improve some function documentation in tests 2021-01-14 22:13:55 +01:00
site
skins tests: Remove @param docs from test code that just repeat the signature 2021-01-21 03:41:23 +00:00
sparql
specialpage Use expectWarning/Deprecation/Notice/Error() in phpunit tests 2021-01-04 00:16:51 +00:00
specials Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
Storage Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
title Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
upload Deprecate InterwikiLoadPrefix hook 2020-12-21 19:28:48 +00:00
user Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
utils Make use of array deconstruction directly in foreach, if possible 2020-11-12 18:38:06 +00:00
watcheditem Remove WatchedItemStoreUnitTest::getFakeRow 2021-01-15 09:21:48 +00:00
ActorMigrationTest.php More misc test cleanup 2020-12-24 00:52:06 +00:00
ActorMigrationTest.sql
AutoLoaderTest.php
AutopromoteTest.php Merge "UserEditTracker: Minor code clean up and follow-ups" 2020-09-28 20:35:39 +00:00
CategoryTest.php
CommentStoreCommentTest.php
CommentStoreTest.php
CommentStoreTest.sql
ContentSecurityPolicyTest.php More misc test cleanup 2020-12-24 00:52:06 +00:00
DeprecatedGlobalTest.php Use expectWarning/Deprecation/Notice/Error() in phpunit tests 2021-01-04 00:16:51 +00:00
DiffHistoryBlobTest.php
EditPageConstraintsTest.php Add AccidentalRecreationConstraint 2020-11-16 22:36:54 +00:00
EditPageTest.php Swap out uses of User->isLoggedIn() with ->isRegistered() 2020-12-22 03:13:37 +00:00
ExportTest.php Explicitly wrap some XML calls in libxml_disable_entity_loader() 2020-09-20 15:57:14 +00:00
ExtraParserTest.php Deprecate InterwikiLoadPrefix hook 2020-12-21 19:28:48 +00:00
FauxRequestTest.php Implement FauxRequest::getPostValues() 2020-11-27 09:38:08 +01:00
GitInfoTest.php More misc test cleanup 2020-12-24 00:52:06 +00:00
HooksTest.php Use expectWarning/Deprecation/Notice/Error() in phpunit tests 2021-01-04 00:16:51 +00:00
HtmlTest.php Use expectWarning/Deprecation/Notice/Error() in phpunit tests 2021-01-04 00:16:51 +00:00
LinkerTest.php Drop the LinkBegin and LinkEnd hooks, deprecated since 1.28 2020-07-29 11:25:49 +01:00
LinkFilterTest.php
ListToggleTest.php
MagicWordFactoryTest.php
MediaWikiServicesTest.php phpunit: Remove odd "MediaWiki" group from tests using it 2021-01-08 18:35:30 +00:00
MediaWikiTest.php More misc test cleanup 2020-12-24 00:52:06 +00:00
MediaWikiVersionFetcherTest.php
MergeHistoryTest.php Inject WikiPageFactory into MergeHistory/MovePage 2020-11-11 22:10:47 +01:00
MessageTest.php tests: Use ::class on exception names 2021-01-03 20:47:49 +01:00
MockServiceWiring.php Use the old HookContainer to set up the post-reset services 2020-12-01 13:04:12 +11:00
MovePageTest.php Add delete-redirect for deleting single-rev redirects during moves 2020-09-04 03:50:17 +00:00
MultiHttpClientTest.php
MWTimestampTest.php
OutputPageTest.php Remove broken/outdated @param/@throws tags from @dataProviders 2021-01-21 03:42:42 +00:00
PagePropsTest.php Replace tabs with spaces 2020-09-04 18:04:07 +02:00
PrefixSearchTest.php WikiPage: deprecated construction on bad titles 2021-01-20 14:31:11 +01:00
ReadOnlyModeTest.php
RevisionDbTest.php Improve some function documentation in tests 2021-01-14 22:13:55 +01:00
RevisionTest.php
RevisionTestModifyableContent.php
RevisionTestModifyableContentHandler.php
SampleTest.php Fix hang of ApiMainTest 2020-12-16 15:39:19 +11:00
SiteStatsTest.php
StatusTest.php [StatusTest] Replace ReflectionMethod with TestingAccessWrapper 2020-10-30 14:02:10 +00:00
SystemBlockTest.php
TemplateCategoriesTest.php
TestLocalisationCache.php
TestLogger.php
TestUser.php ParserTestRunner: share more code w/ MediaWikiIntegrationTestCase 2021-01-07 23:31:12 -05:00
TestUserRegistry.php Swap out uses of User->isLoggedIn() with ->isRegistered() 2020-12-22 03:13:37 +00:00
TimeAdjustTest.php
TitleMethodsTest.php Title: add tests for makeTitle and makeTitleSafe 2021-01-20 16:57:46 +00:00
TitleTest.php Define equality for PageIdentity and LinkTarget 2021-01-19 23:07:37 +00:00
WebRequestTest.php Make WebRequest::getAcceptLang() return floats instead of strings 2020-07-14 19:10:24 +00:00
WikiMapTest.php
WikiReferenceTest.php
XmlTest.php Convert or split some tests to MediaWikiUnitTestCase 2021-01-07 17:51:27 +00:00