34fe90ac52
It looks like there is something missing after the last statement Also remove some other empty lines at begin of functions, ifs or loops while at these files Change-Id: Ib00b5cfd31ca4dcd0c32ce33754d3c80bae70641
202 lines
6.9 KiB
PHP
202 lines
6.9 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group Media
|
|
*/
|
|
class ExifBitmapTest extends MediaWikiMediaTestCase {
|
|
|
|
/**
|
|
* @var ExifBitmapHandler
|
|
*/
|
|
protected $handler;
|
|
|
|
protected function setUp() {
|
|
parent::setUp();
|
|
$this->checkPHPExtension( 'exif' );
|
|
|
|
$this->setMwGlobals( 'wgShowEXIF', true );
|
|
|
|
$this->handler = new ExifBitmapHandler;
|
|
}
|
|
|
|
/**
|
|
* @covers ExifBitmapHandler::isMetadataValid
|
|
*/
|
|
public function testIsOldBroken() {
|
|
$res = $this->handler->isMetadataValid( null, ExifBitmapHandler::OLD_BROKEN_FILE );
|
|
$this->assertEquals( ExifBitmapHandler::METADATA_COMPATIBLE, $res );
|
|
}
|
|
|
|
/**
|
|
* @covers ExifBitmapHandler::isMetadataValid
|
|
*/
|
|
public function testIsBrokenFile() {
|
|
$res = $this->handler->isMetadataValid( null, ExifBitmapHandler::BROKEN_FILE );
|
|
$this->assertEquals( ExifBitmapHandler::METADATA_GOOD, $res );
|
|
}
|
|
|
|
/**
|
|
* @covers ExifBitmapHandler::isMetadataValid
|
|
*/
|
|
public function testIsInvalid() {
|
|
$res = $this->handler->isMetadataValid( null, 'Something Invalid Here.' );
|
|
$this->assertEquals( ExifBitmapHandler::METADATA_BAD, $res );
|
|
}
|
|
|
|
/**
|
|
* @covers ExifBitmapHandler::isMetadataValid
|
|
*/
|
|
public function testGoodMetadata() {
|
|
// @codingStandardsIgnoreStart Ignore Generic.Files.LineLength.TooLong
|
|
$meta = 'a:16:{s:10:"ImageWidth";i:20;s:11:"ImageLength";i:20;s:13:"BitsPerSample";a:3:{i:0;i:8;i:1;i:8;i:2;i:8;}s:11:"Compression";i:5;s:25:"PhotometricInterpretation";i:2;s:16:"ImageDescription";s:17:"Created with GIMP";s:12:"StripOffsets";i:8;s:11:"Orientation";i:1;s:15:"SamplesPerPixel";i:3;s:12:"RowsPerStrip";i:64;s:15:"StripByteCounts";i:238;s:11:"XResolution";s:19:"1207959552/16777216";s:11:"YResolution";s:19:"1207959552/16777216";s:19:"PlanarConfiguration";i:1;s:14:"ResolutionUnit";i:2;s:22:"MEDIAWIKI_EXIF_VERSION";i:2;}';
|
|
// @codingStandardsIgnoreEnd
|
|
$res = $this->handler->isMetadataValid( null, $meta );
|
|
$this->assertEquals( ExifBitmapHandler::METADATA_GOOD, $res );
|
|
}
|
|
|
|
/**
|
|
* @covers ExifBitmapHandler::isMetadataValid
|
|
*/
|
|
public function testIsOldGood() {
|
|
// @codingStandardsIgnoreStart Ignore Generic.Files.LineLength.TooLong
|
|
$meta = 'a:16:{s:10:"ImageWidth";i:20;s:11:"ImageLength";i:20;s:13:"BitsPerSample";a:3:{i:0;i:8;i:1;i:8;i:2;i:8;}s:11:"Compression";i:5;s:25:"PhotometricInterpretation";i:2;s:16:"ImageDescription";s:17:"Created with GIMP";s:12:"StripOffsets";i:8;s:11:"Orientation";i:1;s:15:"SamplesPerPixel";i:3;s:12:"RowsPerStrip";i:64;s:15:"StripByteCounts";i:238;s:11:"XResolution";s:19:"1207959552/16777216";s:11:"YResolution";s:19:"1207959552/16777216";s:19:"PlanarConfiguration";i:1;s:14:"ResolutionUnit";i:2;s:22:"MEDIAWIKI_EXIF_VERSION";i:1;}';
|
|
// @codingStandardsIgnoreEnd
|
|
$res = $this->handler->isMetadataValid( null, $meta );
|
|
$this->assertEquals( ExifBitmapHandler::METADATA_COMPATIBLE, $res );
|
|
}
|
|
|
|
/**
|
|
* Handle metadata from paged tiff handler (gotten via instant commons) gracefully.
|
|
* @covers ExifBitmapHandler::isMetadataValid
|
|
*/
|
|
public function testPagedTiffHandledGracefully() {
|
|
// @codingStandardsIgnoreStart Ignore Generic.Files.LineLength.TooLong
|
|
$meta = 'a:6:{s:9:"page_data";a:1:{i:1;a:5:{s:5:"width";i:643;s:6:"height";i:448;s:5:"alpha";s:4:"true";s:4:"page";i:1;s:6:"pixels";i:288064;}}s:10:"page_count";i:1;s:10:"first_page";i:1;s:9:"last_page";i:1;s:4:"exif";a:9:{s:10:"ImageWidth";i:643;s:11:"ImageLength";i:448;s:11:"Compression";i:5;s:25:"PhotometricInterpretation";i:2;s:11:"Orientation";i:1;s:15:"SamplesPerPixel";i:4;s:12:"RowsPerStrip";i:50;s:19:"PlanarConfiguration";i:1;s:22:"MEDIAWIKI_EXIF_VERSION";i:1;}s:21:"TIFF_METADATA_VERSION";s:3:"1.4";}';
|
|
// @codingStandardsIgnoreEnd
|
|
$res = $this->handler->isMetadataValid( null, $meta );
|
|
$this->assertEquals( ExifBitmapHandler::METADATA_BAD, $res );
|
|
}
|
|
|
|
/**
|
|
* @covers ExifBitmapHandler::convertMetadataVersion
|
|
*/
|
|
public function testConvertMetadataLatest() {
|
|
$metadata = [
|
|
'foo' => [ 'First', 'Second', '_type' => 'ol' ],
|
|
'MEDIAWIKI_EXIF_VERSION' => 2
|
|
];
|
|
$res = $this->handler->convertMetadataVersion( $metadata, 2 );
|
|
$this->assertEquals( $metadata, $res );
|
|
}
|
|
|
|
/**
|
|
* @covers ExifBitmapHandler::convertMetadataVersion
|
|
*/
|
|
public function testConvertMetadataToOld() {
|
|
$metadata = [
|
|
'foo' => [ 'First', 'Second', '_type' => 'ol' ],
|
|
'bar' => [ 'First', 'Second', '_type' => 'ul' ],
|
|
'baz' => [ 'First', 'Second' ],
|
|
'fred' => 'Single',
|
|
'MEDIAWIKI_EXIF_VERSION' => 2,
|
|
];
|
|
$expected = [
|
|
'foo' => "\n#First\n#Second",
|
|
'bar' => "\n*First\n*Second",
|
|
'baz' => "\n*First\n*Second",
|
|
'fred' => 'Single',
|
|
'MEDIAWIKI_EXIF_VERSION' => 1,
|
|
];
|
|
$res = $this->handler->convertMetadataVersion( $metadata, 1 );
|
|
$this->assertEquals( $expected, $res );
|
|
}
|
|
|
|
/**
|
|
* @covers ExifBitmapHandler::convertMetadataVersion
|
|
*/
|
|
public function testConvertMetadataSoftware() {
|
|
$metadata = [
|
|
'Software' => [ [ 'GIMP', '1.1' ] ],
|
|
'MEDIAWIKI_EXIF_VERSION' => 2,
|
|
];
|
|
$expected = [
|
|
'Software' => 'GIMP (Version 1.1)',
|
|
'MEDIAWIKI_EXIF_VERSION' => 1,
|
|
];
|
|
$res = $this->handler->convertMetadataVersion( $metadata, 1 );
|
|
$this->assertEquals( $expected, $res );
|
|
}
|
|
|
|
/**
|
|
* @covers ExifBitmapHandler::convertMetadataVersion
|
|
*/
|
|
public function testConvertMetadataSoftwareNormal() {
|
|
$metadata = [
|
|
'Software' => [ "GIMP 1.2", "vim" ],
|
|
'MEDIAWIKI_EXIF_VERSION' => 2,
|
|
];
|
|
$expected = [
|
|
'Software' => "\n*GIMP 1.2\n*vim",
|
|
'MEDIAWIKI_EXIF_VERSION' => 1,
|
|
];
|
|
$res = $this->handler->convertMetadataVersion( $metadata, 1 );
|
|
$this->assertEquals( $expected, $res );
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideSwappingICCProfile
|
|
* @covers ExifBitmapHandler::swapICCProfile
|
|
*/
|
|
public function testSwappingICCProfile(
|
|
$sourceFilename, $controlFilename, $newProfileFilename, $oldProfileName
|
|
) {
|
|
global $wgExiftool;
|
|
|
|
if ( !$wgExiftool || !is_file( $wgExiftool ) ) {
|
|
$this->markTestSkipped( "Exiftool not installed, cannot test ICC profile swapping" );
|
|
}
|
|
|
|
$this->setMwGlobals( 'wgUseTinyRGBForJPGThumbnails', true );
|
|
|
|
$sourceFilepath = $this->filePath . $sourceFilename;
|
|
$controlFilepath = $this->filePath . $controlFilename;
|
|
$profileFilepath = $this->filePath . $newProfileFilename;
|
|
$filepath = $this->getNewTempFile();
|
|
|
|
copy( $sourceFilepath, $filepath );
|
|
|
|
$file = $this->dataFile( $sourceFilename, 'image/jpeg' );
|
|
$this->handler->swapICCProfile( $filepath, $oldProfileName, $profileFilepath );
|
|
|
|
$this->assertEquals(
|
|
sha1( file_get_contents( $filepath ) ),
|
|
sha1( file_get_contents( $controlFilepath ) )
|
|
);
|
|
}
|
|
|
|
public function provideSwappingICCProfile() {
|
|
return [
|
|
// File with sRGB should end up with TinyRGB
|
|
[
|
|
'srgb.jpg',
|
|
'tinyrgb.jpg',
|
|
'tinyrgb.icc',
|
|
'IEC 61966-2.1 Default RGB colour space - sRGB'
|
|
],
|
|
// File with TinyRGB should be left unchanged
|
|
[
|
|
'tinyrgb.jpg',
|
|
'tinyrgb.jpg',
|
|
'tinyrgb.icc',
|
|
'IEC 61966-2.1 Default RGB colour space - sRGB'
|
|
],
|
|
// File with no profile should be left unchanged
|
|
[
|
|
'test.jpg',
|
|
'test.jpg',
|
|
'tinyrgb.icc',
|
|
'IEC 61966-2.1 Default RGB colour space - sRGB'
|
|
]
|
|
];
|
|
}
|
|
}
|