3f852f7ddc
DatabaseInstaller had some LSP violations, such as calling undeclared methods of the supplied Installer object, assuming that it was a WebInstaller. It was also large. So, split the web form parts of DatabaseInstaller into separate classes. We have a class hierarchy for the connect forms, and a class hierarchy for the settings forms, with a base class DatabaseForm mostly as a place to put protected helper methods. Also, have DatabaseInstaller::getConnection() return a special subclass of Status, so that we can remove many Phan type overrides. Change-Id: Ie84025f8f70b895fa6882848b9a21ba1750d60e2
46 lines
1 KiB
PHP
46 lines
1 KiB
PHP
<?php
|
|
|
|
namespace MediaWiki\Installer;
|
|
|
|
use MediaWiki\Status\Status;
|
|
|
|
/**
|
|
* @internal
|
|
*/
|
|
class SqliteConnectForm extends DatabaseConnectForm {
|
|
|
|
public function getHtml() {
|
|
return $this->getTextBox(
|
|
'wgSQLiteDataDir',
|
|
'config-sqlite-dir', [],
|
|
$this->webInstaller->getHelpBox( 'config-sqlite-dir-help' )
|
|
) .
|
|
$this->getTextBox(
|
|
'wgDBname',
|
|
'config-db-name',
|
|
[],
|
|
$this->webInstaller->getHelpBox( 'config-sqlite-name-help' )
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return Status
|
|
*/
|
|
public function submit() {
|
|
$this->setVarsFromRequest( [ 'wgSQLiteDataDir', 'wgDBname' ] );
|
|
|
|
# Try realpath() if the directory already exists
|
|
$dir = SqliteInstaller::realpath( $this->getVar( 'wgSQLiteDataDir' ) );
|
|
$result = SqliteInstaller::checkDataDir( $dir );
|
|
if ( $result->isOK() ) {
|
|
# Try expanding again in case we've just created it
|
|
$dir = SqliteInstaller::realpath( $dir );
|
|
$this->setVar( 'wgSQLiteDataDir', $dir );
|
|
}
|
|
# Table prefix is not used on SQLite, keep it empty
|
|
$this->setVar( 'wgDBprefix', '' );
|
|
|
|
return $result;
|
|
}
|
|
|
|
}
|