Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/tests/phpunit/includes
History
Thiemo Kreuz b95a07380a Remove meaningless ->expects( $this->any() ) from all tests 
It is not entirely meaningless. It might be an indicator that
the number of calls to a method is intentionally unlimited.
This is similar to e.g. an @inheritDoc PHPDoc comment that
marks a method as being "intentionally undocumented".

However, what's the meaning of being "intentionally
unconstrained"? Let's just not have any constraint then.

I feel all these ->expects( $this->any() ) bloat the test
code so much that it's never worth it.

Change-Id: I9925e7706bd03e1666f6eb0b284cb42b0dd3be23
2021-04-23 11:58:58 +02:00
..
actions Merge "Use WatchlistManager instead of User in WatchAction" 2021-04-19 03:40:38 +00:00
api Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
auth Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
block phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
cache Replace PHPUnit ->returnValue() with ->willReturn() shortcut 2021-04-22 10:37:45 +02:00
changes Replace PHPUnit ->returnValue() with ->willReturn() shortcut 2021-04-22 10:37:45 +02:00
changetags Revert "Add change tags for media additions/removals" 2021-03-26 15:16:08 +00:00
collation
config
content Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
context Remove $actor field from UsererIdentityValue 2021-04-13 18:18:06 +00:00
db Replace ->exactly( 1 ) with ->once() in tests 2021-04-22 09:42:28 +02:00
debug Replace PHPUnit ->returnValue() with ->willReturn() shortcut 2021-04-22 10:37:45 +02:00
deferred phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
diff Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
editpage
exception
externalstore Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
filebackend
filerepo Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
GlobalFunctions MediaHandlerFactory: inject a logger 2021-03-31 17:45:51 +00:00
HookContainer
htmlform
http phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
import
installer Installer: Do not use mediawiki.skinning.interface module 2021-04-15 11:11:32 -07:00
interwiki
jobqueue Replace PHPUnit ->returnValue() with ->willReturn() shortcut 2021-04-22 10:37:45 +02:00
language
libs phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
linkeddata
linker
logging Remove $actor field from UsererIdentityValue 2021-04-13 18:18:06 +00:00
mail Use UserIdentityValue in tests where possible 2021-04-22 09:32:43 +02:00
media phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
Message phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
Navigation
objectcache
page Replace PHPUnit ->returnValue() with ->willReturn() shortcut 2021-04-22 10:37:45 +02:00
pager
ParamValidator/TypeDef
parser phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
password UserPasswordPolicyTest: Replace PasswordCannotMatchBlacklist with PasswordCannotMatchDefaults 2021-04-18 23:52:57 +01:00
Permissions phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
poolcounter ParserCache: only use in-process caching for metadata 2021-04-06 17:53:38 -06:00
preferences Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
rcfeed phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
registration Convert ExtensionJsonValidatorTest to pure unit tests 2021-03-22 16:02:51 +00:00
resourceloader Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
Rest Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
Revision Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
search Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
session Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
shell
site Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
skins Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
sparql
specialpage phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
specials Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
Storage Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
title Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
upload
user Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
utils Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
watcheditem Convert WatchedItem et al to PageIdentity 2021-03-26 15:51:19 -04:00
ActorMigrationTest.php Remove $actor field from UsererIdentityValue 2021-04-13 18:18:06 +00:00
ActorMigrationTest.sql
AutoLoaderTest.php
CategoryTest.php
CommentStoreCommentTest.php
CommentStoreTest.php
CommentStoreTest.sql
ContentSecurityPolicyTest.php build: Swap deprecated @codingStandardsIgnore to phpcs:ignore 2021-04-04 21:18:22 +02:00
EditPageConstraintsTest.php Set $status->value in EditFilterMergedContentHookConstraint::checkConstraint() properly to display error message 2021-04-15 22:01:30 +02:00
EditPageTest.php Fix parameter order of setWatch to match add/removeWatch 2021-04-21 04:41:38 +00:00
ExportTest.php
ExtraParserTest.php Parser: Trim trailing whitespace as the last step in pre-save transform 2021-04-14 20:53:49 +02:00
FauxRequestTest.php
GitInfoTest.php
HooksTest.php
HtmlTest.php
LinkerTest.php
LinkFilterTest.php
MagicWordFactoryTest.php
MediaWikiServicesTest.php
MediaWikiTest.php
MediaWikiVersionFetcherTest.php
MergeHistoryTest.php Replace PHPUnit ->returnValue() with ->willReturn() shortcut 2021-04-22 10:37:45 +02:00
MessageTest.php Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
MockServiceWiring.php
MovePageTest.php Factor out rollback logic from WikiPage 2021-04-14 11:49:07 -07:00
MultiHttpClientTest.php Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
MWTimestampTest.php Remove $actor field from UsererIdentityValue 2021-04-13 18:18:06 +00:00
OutputPageTest.php Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
PagePropsTest.php
ReadOnlyModeTest.php Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
RevisionDbTest.php Use PageStore in RevisionStore 2021-04-05 20:58:54 +02:00
RevisionTest.php Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
RevisionTestModifyableContent.php
RevisionTestModifyableContentHandler.php
SampleTest.php
SiteStatsTest.php
StatusTest.php phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
TemplateCategoriesTest.php
TestUser.php Make stricter type checks on user email and real name 2021-04-01 15:21:41 -06:00
TestUserRegistry.php
TimeAdjustTest.php
TitleMethodsTest.php title: Fix bogus Title::getSkinFromConfigSubpage() 2021-04-01 20:06:16 +02:00
TitleTest.php Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
WebRequestTest.php phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
WikiMapTest.php
WikiReferenceTest.php
XmlTest.php