Per the SVG2 spec, these units should be interpreted following CSS units level 3. We had a number of differences: * Units are supposed to be case-insensitive (previously required lowercase) * Missing the units q, rem, ch * ex is supposed to be 0.5em if UA does not know what it is (previously 0.75em) * Absolute units are supposed to assume 96 dpi (previously was 90dpi) Additionally the spec mentions the units vw, vh, vmin, vmax which are missing. Support for those are left as a future TODO. Bug: T364066 Change-Id: Ie18e4fe38c0ab7f8fc861839783a4758fdb09a8b
213 lines
4.8 KiB
PHP
213 lines
4.8 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group Media
|
|
* @covers \SVGReader
|
|
*/
|
|
class SVGReaderTest extends \MediaWikiIntegrationTestCase {
|
|
|
|
/**
|
|
* @dataProvider provideSvgFiles
|
|
*/
|
|
public function testGetMetadata( $infile, $expected ) {
|
|
$this->assertMetadata( $infile, $expected );
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideSvgFilesWithXMLMetadata
|
|
*/
|
|
public function testGetXMLMetadata( $infile, $expected ) {
|
|
$r = new XMLReader();
|
|
$this->assertMetadata( $infile, $expected );
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideSvgUnits
|
|
*/
|
|
public function testScaleSVGUnit( $inUnit, $expected ) {
|
|
$this->assertEquals(
|
|
$expected,
|
|
SVGReader::scaleSVGUnit( $inUnit ),
|
|
'SVG unit conversion and scaling failure'
|
|
);
|
|
}
|
|
|
|
private function assertMetadata( $infile, $expected ) {
|
|
if ( $expected === false ) {
|
|
$this->expectException( InvalidSVGException::class );
|
|
}
|
|
$svgReader = new SVGReader( $infile );
|
|
$data = $svgReader->getMetadata();
|
|
|
|
$this->assertEquals( $expected, $data, 'SVG metadata extraction test' );
|
|
}
|
|
|
|
public static function provideSvgFiles() {
|
|
$base = __DIR__ . '/../../data/media';
|
|
|
|
return [
|
|
[
|
|
"$base/Wikimedia-logo.svg",
|
|
[
|
|
'width' => 1024,
|
|
'height' => 1024,
|
|
'originalWidth' => '1024',
|
|
'originalHeight' => '1024',
|
|
'translations' => [],
|
|
]
|
|
],
|
|
[
|
|
"$base/QA_icon.svg",
|
|
[
|
|
'width' => 60,
|
|
'height' => 60,
|
|
'originalWidth' => '60',
|
|
'originalHeight' => '60',
|
|
'translations' => [],
|
|
]
|
|
],
|
|
[
|
|
"$base/Gtk-media-play-ltr.svg",
|
|
[
|
|
'width' => 60,
|
|
'height' => 60,
|
|
'originalWidth' => '60.0000000',
|
|
'originalHeight' => '60.0000000',
|
|
'translations' => [],
|
|
]
|
|
],
|
|
[
|
|
"$base/Toll_Texas_1.svg",
|
|
// This file triggered T33719, needs entity expansion in the xmlns checks
|
|
[
|
|
'width' => 385,
|
|
'height' => 385,
|
|
'originalWidth' => '385',
|
|
'originalHeight' => '385.0004883',
|
|
'translations' => [],
|
|
]
|
|
],
|
|
[
|
|
"$base/Tux.svg",
|
|
[
|
|
'width' => 512,
|
|
'height' => 594,
|
|
'originalWidth' => '100%',
|
|
'originalHeight' => '100%',
|
|
'title' => 'Tux',
|
|
'translations' => [],
|
|
'description' => 'For more information see: http://commons.wikimedia.org/wiki/Image:Tux.svg',
|
|
]
|
|
],
|
|
[
|
|
"$base/Speech_bubbles.svg",
|
|
[
|
|
'width' => 669,
|
|
'height' => 491,
|
|
'originalWidth' => '17.7cm',
|
|
'originalHeight' => '13cm',
|
|
'translations' => [
|
|
'de' => SVGReader::LANG_FULL_MATCH,
|
|
'fr' => SVGReader::LANG_FULL_MATCH,
|
|
'nl' => SVGReader::LANG_FULL_MATCH,
|
|
'tlh-ca' => SVGReader::LANG_FULL_MATCH,
|
|
'tlh' => SVGReader::LANG_PREFIX_MATCH
|
|
],
|
|
]
|
|
],
|
|
[
|
|
"$base/Soccer_ball_animated.svg",
|
|
[
|
|
'width' => 150,
|
|
'height' => 150,
|
|
'originalWidth' => '150',
|
|
'originalHeight' => '150',
|
|
'animated' => true,
|
|
'translations' => []
|
|
],
|
|
],
|
|
[
|
|
"$base/comma_separated_viewbox.svg",
|
|
[
|
|
'width' => 512,
|
|
'height' => 594,
|
|
'originalWidth' => '100%',
|
|
'originalHeight' => '100%',
|
|
'translations' => []
|
|
],
|
|
],
|
|
[
|
|
"$base/css-animated.svg",
|
|
[
|
|
'width' => 100,
|
|
'height' => 100,
|
|
'originalWidth' => '100',
|
|
'originalHeight' => '100',
|
|
'animated' => true,
|
|
'translations' => []
|
|
],
|
|
],
|
|
];
|
|
}
|
|
|
|
public static function provideSvgFilesWithXMLMetadata() {
|
|
$base = __DIR__ . '/../../data/media';
|
|
$metadata = '<rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#">
|
|
<ns4:Work xmlns:ns4="http://creativecommons.org/ns#" rdf:about="">
|
|
<ns5:format xmlns:ns5="http://purl.org/dc/elements/1.1/">image/svg+xml</ns5:format>
|
|
<ns5:type xmlns:ns5="http://purl.org/dc/elements/1.1/" rdf:resource="http://purl.org/dc/dcmitype/StillImage"/>
|
|
</ns4:Work>
|
|
</rdf:RDF>';
|
|
// phpcs:enable
|
|
|
|
$metadata = str_replace( "\r", '', $metadata ); // Windows compat
|
|
return [
|
|
[
|
|
"$base/US_states_by_total_state_tax_revenue.svg",
|
|
[
|
|
'height' => 593,
|
|
'metadata' => $metadata,
|
|
'width' => 959,
|
|
'originalWidth' => '958.69',
|
|
'originalHeight' => '592.78998',
|
|
'translations' => [],
|
|
]
|
|
],
|
|
];
|
|
}
|
|
|
|
public static function provideSvgUnits() {
|
|
return [
|
|
[ '1', 1 ],
|
|
[ '1.1', 1.1 ],
|
|
[ '0.1', 0.1 ],
|
|
[ '.1', 0.1 ],
|
|
[ '1e2', 100 ],
|
|
[ '1E2', 100 ],
|
|
[ '+1', 1 ],
|
|
[ '-1', -1 ],
|
|
[ '-1.1', -1.1 ],
|
|
[ '1e+2', 100 ],
|
|
[ '1e-2', 0.01 ],
|
|
[ '10px', 10 ],
|
|
[ '10.2cm', 10.2 * 37.795275 ],
|
|
[ '10pt', 10 * 1.333333 ],
|
|
[ '10pc', 10 * 16 ],
|
|
[ '10mm', 10 * 3.7795275 ],
|
|
[ '10q', 10 * 0.944881 ],
|
|
[ '10Q', 10 * 0.944881 ],
|
|
[ '10cm', 10 * 37.795275 ],
|
|
[ '10in', 10 * 96 ],
|
|
[ '10em', 10 * 16 ],
|
|
[ '10rem', 10 * 16 ],
|
|
[ '10ex', 10 * 8 ],
|
|
[ '10ch', 10 * 8 ],
|
|
[ '10%', 51.2 ],
|
|
[ '10 px', 10 ],
|
|
// Invalid values
|
|
[ '1e1.1', 10 ],
|
|
[ '10bp', 10 ],
|
|
[ 'p10', null ],
|
|
];
|
|
}
|
|
}
|