64734f61ee
https://gerrit.wikimedia.org/r/q/owner:Krinkle+is:merged+message:Widen > Given all called methods are de-facto and liberally claimed, and > that we keep the coverage limited to the subject class, it maintains > the spirit and intent by listing the class explicitly instead. > > PHPUnit offers a more precise tool when you need it (i.e. when testing > legacy monster/god classes), but for well-written code, the > class-wide tag is exactly what you want. > > We lose useful coverage and waste valuable time on keeping tags > accurate through refactors (or worse, forget to do so). > Tracking tiny per-method details wastes time in realizing (and > fixing) when people inevitably don't keep them in sync, and time > lost in finding uncovered code to write tests to realize it was > already covered but "not yet claimed". While at it, also fix PHPUnit warnings in CssContentHandlerIntegrationTest and JavaScriptContentHandlerIntegrationTest about not having any `@covers` annotations. Change-Id: I5afd9fe0bca0fa86cc096f6e5e79f2ba1cfbfa77
17 lines
437 B
PHP
17 lines
437 B
PHP
<?php
|
|
|
|
use MediaWiki\Content\JsonContent;
|
|
use MediaWiki\Content\JsonContentHandler;
|
|
|
|
/**
|
|
* @covers \MediaWiki\Content\JsonContentHandler
|
|
*/
|
|
class JsonContentHandlerTest extends \MediaWikiUnitTestCase {
|
|
|
|
public function testMakeEmptyContent() {
|
|
$handler = new JsonContentHandler();
|
|
$content = $handler->makeEmptyContent();
|
|
$this->assertInstanceOf( JsonContent::class, $content );
|
|
$this->assertTrue( $content->isValid() );
|
|
}
|
|
}
|