94d04b1402
SamplingStatsdClientTest was using the legacy implementation of the Mersenne-Twister RNG algorithm to achieve predictable randomness, but this is deprecated as of PHP 8.3. So, switch to the default algorithm instead (available as of PHP 7.1), and update seed values. Bug: T352908 Change-Id: I3e953d38982e196acd3964faf4370815b7726517
88 lines
2.3 KiB
PHP
88 lines
2.3 KiB
PHP
<?php
|
|
|
|
namespace Wikimedia\Tests;
|
|
|
|
use Liuggio\StatsdClient\Entity\StatsdData;
|
|
use Liuggio\StatsdClient\Sender\SenderInterface;
|
|
use MediaWikiCoversValidator;
|
|
use PHPUnit\Framework\TestCase;
|
|
use SamplingStatsdClient;
|
|
|
|
/**
|
|
* @covers \SamplingStatsdClient
|
|
*/
|
|
class SamplingStatsdClientTest extends TestCase {
|
|
|
|
use MediaWikiCoversValidator;
|
|
|
|
protected function setUp(): void {
|
|
parent::setUp();
|
|
if ( version_compare( PHP_VERSION, '8.2', '>=' ) ) {
|
|
// Tracked on T326386
|
|
$this->markTestSkipped( "PHP 8.2 isn't supported for this test" );
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @dataProvider samplingDataProvider
|
|
*/
|
|
public function testSampling( $data, $sampleRate, $seed, $expectWrite ) {
|
|
$sender = $this->createMock( SenderInterface::class );
|
|
$sender->method( 'open' )->willReturn( true );
|
|
if ( $expectWrite ) {
|
|
$sender->expects( $this->once() )->method( 'write' )
|
|
->with( $this->anything(), $data );
|
|
} else {
|
|
$sender->expects( $this->never() )->method( 'write' );
|
|
}
|
|
|
|
mt_srand( $seed );
|
|
|
|
$client = new SamplingStatsdClient( $sender );
|
|
$client->send( $data, $sampleRate );
|
|
}
|
|
|
|
public function samplingDataProvider() {
|
|
$unsampled = new StatsdData();
|
|
$unsampled->setKey( 'foo' );
|
|
$unsampled->setValue( 1 );
|
|
|
|
$sampled = new StatsdData();
|
|
$sampled->setKey( 'foo' );
|
|
$sampled->setValue( 1 );
|
|
$sampled->setSampleRate( '0.1' );
|
|
|
|
return [
|
|
// $data, $sampleRate, $seed, $expectWrite
|
|
[ $unsampled, 1, 0 /*0.54*/, true ],
|
|
[ $sampled, 1, 0 /*0.54*/, false ],
|
|
[ $sampled, 1, 7 /*0.07*/, true ],
|
|
[ $unsampled, 0.1, 0 /*0.54*/, false ],
|
|
[ $sampled, 0.5, 0 /*0.54*/, false ],
|
|
[ $sampled, 0.5, 7 /*0.07*/, false ],
|
|
];
|
|
}
|
|
|
|
public function testSetSamplingRates() {
|
|
$matching = new StatsdData();
|
|
$matching->setKey( 'foo.bar' );
|
|
$matching->setValue( 1 );
|
|
|
|
$nonMatching = new StatsdData();
|
|
$nonMatching->setKey( 'oof.bar' );
|
|
$nonMatching->setValue( 1 );
|
|
|
|
$sender = $this->createMock( SenderInterface::class );
|
|
$sender->method( 'open' )->willReturn( true );
|
|
$sender->expects( $this->once() )->method( 'write' )
|
|
->with( $this->anything(), $nonMatching );
|
|
|
|
$client = new SamplingStatsdClient( $sender );
|
|
$client->setSamplingRates( [ 'foo.*' => 0.2 ] );
|
|
|
|
mt_srand( 0 ); // next random is 0.44
|
|
$client->send( $matching );
|
|
mt_srand( 0 );
|
|
$client->send( $nonMatching );
|
|
}
|
|
}
|