wiki.techinc.nl/includes/htmlform/fields
Daimona Eaytoy bc0db4dcc3 Apply ID and class more consistently in HTMLSelect(Or|And)OtherField
There were several inconsistencies in how ID vs cssclass vs own classes
were applied, both within the same widget + mode, between different
modes for the same widget, and different widgets. So uniform all of them
according to the plan detailed on phabricator. Include
HTMLSelectAndOtherField as well (that wasn't mentioned on phab) for
consistency. Also remove the select-or-other class from
HTMLAutoCompleteSelectField (which was only applied in HTML mode), since
the widget is not technically a SelectOrOther.

Adjust the logic in selectorother.js so that it works fine in HTML mode,
and disable it for OOUI mode since SelectWithInputWidget does that
already (and the field is autoinfused).

Also, in HTMLAutoCompleteSelectField, don't assign an array to
$this->mClass. This happens to be working right now, but it violates the
type definition of the property.

Luckily, according to codesearch this change seems to be
backwards-compatible because these fields are not commonly used, and
nobody seems to be passing cssclass to them.

Bug: T309883
Change-Id: If950f131d1c4bc1645de6021781045dccfc61966
2022-06-06 18:59:29 +02:00
..
HTMLApiField.php
HTMLAutoCompleteSelectField.php Apply ID and class more consistently in HTMLSelect(Or|And)OtherField 2022-06-06 18:59:29 +02:00
HTMLButtonField.php Use MainConfigNames instead of string literals, #3 2022-04-26 14:31:26 +03:00
HTMLCheckField.php Use MainConfigNames instead of string literals, #3 2022-04-26 14:31:26 +03:00
HTMLCheckMatrix.php Use MainConfigNames instead of string literals, #3 2022-04-26 14:31:26 +03:00
HTMLComboboxField.php Support placeholder in OOUI HTMLComboboxField 2022-05-16 13:10:14 +02:00
HTMLDateTimeField.php Try not to discard Excimer timeout exceptions 2022-02-02 16:27:44 +11:00
HTMLEditTools.php
HTMLExpiryField.php
HTMLFileField.php HTMLFileField: Make 'accept' parameter optional 2021-01-22 16:24:53 +00:00
HTMLFloatField.php
HTMLFormFieldCloner.php Revert "htmlform: Replace some uses of isHidden to isDisabled" 2022-02-28 15:05:45 +00:00
HTMLFormFieldWithButton.php
HTMLHiddenField.php
HTMLInfoField.php Fix typos in comments (E-H) 2021-12-30 18:14:43 +05:30
HTMLIntField.php
HTMLMultiSelectField.php Use MainConfigNames instead of string literals, #3 2022-04-26 14:31:26 +03:00
HTMLNamespacesMultiselectField.php Add explicit casts between scalar types 2022-03-08 16:59:01 +00:00
HTMLRadioField.php Use MainConfigNames instead of string literals, #3 2022-04-26 14:31:26 +03:00
HTMLRestrictionsField.php Revert "htmlform: Replace some uses of isHidden to isDisabled" 2022-02-28 15:05:45 +00:00
HTMLSelectAndOtherField.php Apply ID and class more consistently in HTMLSelect(Or|And)OtherField 2022-06-06 18:59:29 +02:00
HTMLSelectField.php
HTMLSelectLanguageField.php Use MainConfigNames instead of string literals, #3 2022-04-26 14:31:26 +03:00
HTMLSelectLimitField.php Fix typos in comments (E-H) 2021-12-30 18:14:43 +05:30
HTMLSelectNamespace.php Support namespace dropdown 'in-user-lang' option in HTMLForm and OOUI widget 2022-05-13 20:29:44 +00:00
HTMLSelectNamespaceWithButton.php
HTMLSelectOrOtherField.php Apply ID and class more consistently in HTMLSelect(Or|And)OtherField 2022-06-06 18:59:29 +02:00
HTMLSizeFilterField.php
HTMLSubmitField.php
HTMLTagFilter.php Add dropdown menu to "Tag filter" fields 2022-02-07 23:22:40 +00:00
HTMLTagMultiselectField.php HTMLTagMultiselectField: make allowArbitrary really optional 2022-05-22 17:00:27 +00:00
HTMLTextAreaField.php Remove unneeded explicit true/false inside conditions 2021-08-17 21:52:34 +02:00
HTMLTextField.php Remove unneeded explicit true/false inside conditions 2021-08-17 21:52:34 +02:00
HTMLTextFieldWithButton.php
HTMLTitlesMultiselectField.php Rename CSS class 'mw-htmlform-field-autoinfuse' to fit the convention 2021-06-19 15:57:43 +02:00
HTMLTitleTextField.php HTMLTitleTextField: Remove B&C code 2021-09-22 00:48:59 -07:00
HTMLUsersMultiselectField.php Use UserRigorOptions directly 2022-03-25 10:06:34 +11:00
HTMLUserTextField.php Use User::isRegistered for readability instead of ::getId falsy check 2022-04-29 21:15:57 +02:00