0e1e4ee5de
This was previously hardcoded from three places: 1) Upon viewing EditPage, 2) Upon viewing SpecialCreateAccount, 3) For any url if the user is logged-in (User::loadFromSession/isLoggedIn). == User::loadFromSession Performing cookie blocks from here created a circular dependency because Block may need the user language for localisation, which is determined by asking the User object. This was previously worked around by using a DeferredUpdate (T180050, T226777). Moving this logic explicitly to the end of the pre-send cycle in MediaWiki::preOutputCommit breaks the cycle. This is also where other request-specific handling resides already. == Limited effect on unregistered users When an unregistered user performs an edit, and gets blocked, the cookie block is not applied until they open built-in editor or CreateAccount page. This makes it more likely for a user's IP to change meanwhile. Either intentionally, or simply due to IPs varying naturally (e.g. between mobile locations, or when going on/off WiFi). By applying it throughout sessioned page views for unregistered users, it is more likely to get set. Similar to what was already done for logged-in users. This commit also makes the intent of not caching EditPage and SpecialCreateAccount explicit. This was previously implicit through nothing having called setCdnMaxage() and/or due to Session::persist being checked for by OutputPage::sendCacheControl. Bug: T233594 Change-Id: Icf5a00f9b41d31bb6d4742c049feca0039d0c9d9
67 lines
1.8 KiB
PHP
67 lines
1.8 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
|
|
*
|
|
* @file
|
|
* @ingroup Actions
|
|
*/
|
|
|
|
/**
|
|
* Page edition handler (action=edit)
|
|
*
|
|
* This is a wrapper that will call the EditPage class or a custom editor from an extension.
|
|
*
|
|
* @ingroup Actions
|
|
*/
|
|
class EditAction extends FormlessAction {
|
|
|
|
public function getName() {
|
|
return 'edit';
|
|
}
|
|
|
|
public function onView() {
|
|
return null;
|
|
}
|
|
|
|
public function show() {
|
|
$this->useTransactionalTimeLimit();
|
|
|
|
$out = $this->getOutput();
|
|
$out->setRobotPolicy( 'noindex,nofollow' );
|
|
|
|
// The editor should always see the latest content when starting their edit.
|
|
// Also to ensure cookie blocks can be set (T152462).
|
|
$out->enableClientCache( false );
|
|
|
|
if ( $this->getContext()->getConfig()->get( 'UseMediaWikiUIEverywhere' ) ) {
|
|
$out->addModuleStyles( [
|
|
'mediawiki.ui.input',
|
|
'mediawiki.ui.checkbox',
|
|
] );
|
|
}
|
|
$page = $this->page;
|
|
$user = $this->getUser();
|
|
|
|
if ( Hooks::run( 'CustomEditor', [ $page, $user ] ) ) {
|
|
$editor = new EditPage( $page );
|
|
$editor->setContextTitle( $this->getTitle() );
|
|
$editor->edit();
|
|
}
|
|
}
|
|
|
|
public function doesWrites() {
|
|
return true;
|
|
}
|
|
}
|