Previously:
* It was unclear that generate-html is an optional optimization
* Most of MediaWiki core was doing $parserOutput->setText('') if
html wasn't generated. However this is wrong and will cause
$parserOutput->hasText() to return true and also potentially cause
cache pollution if a content handler both does that and supports
parser cache (Like MassMessage; see T299896)
* The default value of mText in the constructor was '', and most
of the time MW used that default. This doesn't seem right. If
setText() is never called, the ParserOutput should not be considered
to have text
* It was impossible to set mText to null, as $parserOutput->setText(null)
was a no-op. Docs implied you were supposed to do this, so it was very
confusing.
This patch clarifies docs, changes the default value for ParserOutput::$mText
from '' to null, and makes $parserOutput->setText(null) do what you
expect it to. The last two are arguably breaking changes, although
the previous behaviours were unexpected, mostly undocumented and
based on a code search do not appear to be relied on.
It seems like the main reason this only broke MassMessage is most
content handlers either don't support generateHtml, or they don't
support parser cache.
Bug: T306591
Change-Id: I49cdf21411c6b02ac9a221a13393bebe17c7871e
Depends-On: I68ad491735b2df13951399312a4f9c37b63a08fa
250 lines
7 KiB
PHP
250 lines
7 KiB
PHP
<?php
|
|
/**
|
|
* Base content handler class for flat text contents.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @since 1.21
|
|
*
|
|
* @file
|
|
* @ingroup Content
|
|
*/
|
|
|
|
use MediaWiki\Content\Renderer\ContentParseParams;
|
|
use MediaWiki\Content\Transform\PreSaveTransformParams;
|
|
use MediaWiki\MainConfigNames;
|
|
use MediaWiki\MediaWikiServices;
|
|
|
|
/**
|
|
* Base content handler implementation for flat text contents.
|
|
*
|
|
* @ingroup Content
|
|
*/
|
|
class TextContentHandler extends ContentHandler {
|
|
|
|
public function __construct( $modelId = CONTENT_MODEL_TEXT, $formats = [ CONTENT_FORMAT_TEXT ] ) {
|
|
parent::__construct( $modelId, $formats );
|
|
}
|
|
|
|
/**
|
|
* Returns the content's text as-is.
|
|
*
|
|
* @param Content $content
|
|
* @param string|null $format The serialization format to check
|
|
*
|
|
* @return mixed
|
|
*/
|
|
public function serializeContent( Content $content, $format = null ) {
|
|
$this->checkFormat( $format );
|
|
|
|
// @phan-suppress-next-line PhanUndeclaredMethod
|
|
return $content->getText();
|
|
}
|
|
|
|
/**
|
|
* Attempts to merge differences between three versions. Returns a new
|
|
* Content object for a clean merge and false for failure or a conflict.
|
|
*
|
|
* All three Content objects passed as parameters must have the same
|
|
* content model.
|
|
*
|
|
* This text-based implementation uses wfMerge().
|
|
*
|
|
* @param Content $oldContent The page's previous content.
|
|
* @param Content $myContent One of the page's conflicting contents.
|
|
* @param Content $yourContent One of the page's conflicting contents.
|
|
*
|
|
* @return Content|bool
|
|
*/
|
|
public function merge3( Content $oldContent, Content $myContent, Content $yourContent ) {
|
|
$this->checkModelID( $oldContent->getModel() );
|
|
$this->checkModelID( $myContent->getModel() );
|
|
$this->checkModelID( $yourContent->getModel() );
|
|
|
|
$format = $this->getDefaultFormat();
|
|
|
|
$old = $this->serializeContent( $oldContent, $format );
|
|
$mine = $this->serializeContent( $myContent, $format );
|
|
$yours = $this->serializeContent( $yourContent, $format );
|
|
|
|
$ok = wfMerge( $old, $mine, $yours, $result );
|
|
|
|
if ( !$ok ) {
|
|
return false;
|
|
}
|
|
|
|
if ( !$result ) {
|
|
return $this->makeEmptyContent();
|
|
}
|
|
|
|
$mergedContent = $this->unserializeContent( $result, $format );
|
|
|
|
return $mergedContent;
|
|
}
|
|
|
|
/**
|
|
* Returns the name of the associated Content class, to
|
|
* be used when creating new objects. Override expected
|
|
* by subclasses.
|
|
*
|
|
* @since 1.24
|
|
*
|
|
* @return string
|
|
*/
|
|
protected function getContentClass() {
|
|
return TextContent::class;
|
|
}
|
|
|
|
/**
|
|
* Unserializes a Content object of the type supported by this ContentHandler.
|
|
*
|
|
* @since 1.21
|
|
*
|
|
* @param string $text Serialized form of the content
|
|
* @param string|null $format The format used for serialization
|
|
*
|
|
* @return Content The TextContent object wrapping $text
|
|
*/
|
|
public function unserializeContent( $text, $format = null ) {
|
|
$this->checkFormat( $format );
|
|
|
|
$class = $this->getContentClass();
|
|
return new $class( $text );
|
|
}
|
|
|
|
/**
|
|
* Creates an empty TextContent object.
|
|
*
|
|
* @since 1.21
|
|
*
|
|
* @return Content A new TextContent object with empty text.
|
|
*/
|
|
public function makeEmptyContent() {
|
|
$class = $this->getContentClass();
|
|
return new $class( '' );
|
|
}
|
|
|
|
/**
|
|
* @see ContentHandler::supportsDirectEditing
|
|
*
|
|
* @return bool Should return true for TextContent and derivatives.
|
|
*/
|
|
public function supportsDirectEditing() {
|
|
return true;
|
|
}
|
|
|
|
public function getFieldsForSearchIndex( SearchEngine $engine ) {
|
|
$fields = parent::getFieldsForSearchIndex( $engine );
|
|
$fields['language'] =
|
|
$engine->makeSearchFieldMapping( 'language', SearchIndexField::INDEX_TYPE_KEYWORD );
|
|
|
|
return $fields;
|
|
}
|
|
|
|
public function getDataForSearchIndex(
|
|
WikiPage $page,
|
|
ParserOutput $output,
|
|
SearchEngine $engine
|
|
) {
|
|
$fields = parent::getDataForSearchIndex( $page, $output, $engine );
|
|
$fields['language'] =
|
|
$this->getPageLanguage( $page->getTitle(), $page->getContent() )->getCode();
|
|
return $fields;
|
|
}
|
|
|
|
public function preSaveTransform(
|
|
Content $content,
|
|
PreSaveTransformParams $pstParams
|
|
): Content {
|
|
$shouldCallDeprecatedMethod = $this->shouldCallDeprecatedContentTransformMethod(
|
|
$content,
|
|
$pstParams
|
|
);
|
|
|
|
if ( $shouldCallDeprecatedMethod ) {
|
|
return $this->callDeprecatedContentPST(
|
|
$content,
|
|
$pstParams
|
|
);
|
|
}
|
|
|
|
'@phan-var TextContent $content';
|
|
|
|
$text = $content->getText();
|
|
|
|
$pst = TextContent::normalizeLineEndings( $text );
|
|
|
|
$contentClass = $this->getContentClass();
|
|
return ( $text === $pst ) ? $content : new $contentClass( $pst, $content->getModel() );
|
|
}
|
|
|
|
/**
|
|
* Fills the provided ParserOutput object with information derived from the content.
|
|
* Unless $generateHtml was false, this includes an HTML representation of the content
|
|
* provided by getHtml().
|
|
*
|
|
* For content models listed in $wgTextModelsToParse, this method will call the MediaWiki
|
|
* wikitext parser on the text to extract any (wikitext) links, magic words, etc.
|
|
*
|
|
* Subclasses may override this to provide custom content processing.
|
|
* For custom HTML generation alone, it is sufficient to override getHtml().
|
|
*
|
|
* @stable to override
|
|
*
|
|
* @since 1.38
|
|
* @param Content $content
|
|
* @param ContentParseParams $cpoParams
|
|
* @param ParserOutput &$output The output object to fill (reference).
|
|
*/
|
|
protected function fillParserOutput(
|
|
Content $content,
|
|
ContentParseParams $cpoParams,
|
|
ParserOutput &$output
|
|
) {
|
|
$textModelsToParse = MediaWikiServices::getInstance()->getMainConfig()->get(
|
|
MainConfigNames::TextModelsToParse );
|
|
'@phan-var TextContent $content';
|
|
if ( in_array( $content->getModel(), $textModelsToParse ) ) {
|
|
// parse just to get links etc into the database, HTML is replaced below.
|
|
$output = MediaWikiServices::getInstance()->getParser()
|
|
->parse(
|
|
$content->getText(),
|
|
$cpoParams->getPage(),
|
|
$cpoParams->getParserOptions(),
|
|
true,
|
|
true,
|
|
$cpoParams->getRevId()
|
|
);
|
|
}
|
|
|
|
if ( $cpoParams->getGenerateHtml() ) {
|
|
// Temporary changes as getHtml() is deprecated, we are working on removing usage of it.
|
|
if ( method_exists( $content, 'getHtml' ) ) {
|
|
$method = new ReflectionMethod( $content, 'getHtml' );
|
|
$method->setAccessible( true );
|
|
$html = $method->invoke( $content );
|
|
} else {
|
|
// Return an HTML representation of the content
|
|
$html = htmlspecialchars( $content->getText(), ENT_COMPAT );
|
|
}
|
|
} else {
|
|
$html = null;
|
|
}
|
|
|
|
$output->clearWrapperDivClass();
|
|
$output->setText( $html );
|
|
}
|
|
}
|