5e2199c5b0
I think this probably shouldn't be directly in the MediaWiki namespace, but I don't know where is a better place to put it. In order to avoid gratuitous use of TitleFormatter, I changed the cache format -- the old implementation used getPrefixedDBkey() and I switched to an ns/dbkey pair. I also changed the cache keys to use SHA1 instead of MD5, by Daniel's request. The previous implementation cached the parsed blacklist for one minute without invalidation, so it could return slightly stale results, but it didn't retrieve the bad image list message on a cache hit. The new implementation unconditionally retrieves the bad image list message, but uses a hash of it in the cache key and caches for one day. The new behavior happens to be more cleanly implementable in a service. Bug: T200882 Bug: T139216 Change-Id: I69fed1b1f3cfc1aa149e0739780e67f6de01609d
75 lines
2.5 KiB
PHP
75 lines
2.5 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
* @ingroup Testing
|
|
*/
|
|
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
/**
|
|
* Base class for unit tests.
|
|
*
|
|
* Extend this class if you are testing classes which use dependency injection and do not access
|
|
* global functions, variables, services or a storage backend.
|
|
*
|
|
* @since 1.34
|
|
*/
|
|
abstract class MediaWikiUnitTestCase extends TestCase {
|
|
use PHPUnit4And6Compat;
|
|
use MediaWikiCoversValidator;
|
|
use MediaWikiTestCaseTrait;
|
|
|
|
private $unitGlobals = [];
|
|
|
|
protected function setUp() {
|
|
parent::setUp();
|
|
$reflection = new ReflectionClass( $this );
|
|
$dirSeparator = DIRECTORY_SEPARATOR;
|
|
if ( strpos( $reflection->getFilename(), "${dirSeparator}unit${dirSeparator}" ) === false ) {
|
|
$this->fail( 'This unit test needs to be in "tests/phpunit/unit"!' );
|
|
}
|
|
$this->unitGlobals = $GLOBALS;
|
|
unset( $GLOBALS );
|
|
$GLOBALS = [];
|
|
// Add back the minimal set of globals needed for unit tests to run for core +
|
|
// extensions/skins.
|
|
foreach ( $this->unitGlobals['wgPhpUnitBootstrapGlobals'] ?? [] as $key => $value ) {
|
|
$GLOBALS[ $key ] = $this->unitGlobals[ $key ];
|
|
}
|
|
}
|
|
|
|
protected function tearDown() {
|
|
$GLOBALS = $this->unitGlobals;
|
|
parent::tearDown();
|
|
}
|
|
|
|
/**
|
|
* Create a temporary hook handler which will be reset by tearDown.
|
|
* This replaces other handlers for the same hook.
|
|
* @param string $hookName Hook name
|
|
* @param mixed $handler Value suitable for a hook handler
|
|
* @since 1.34
|
|
*/
|
|
protected function setTemporaryHook( $hookName, $handler ) {
|
|
// This will be reset by tearDown() when it restores globals. We don't want to use
|
|
// Hooks::register()/clear() because they won't replace other handlers for the same hook,
|
|
// which doesn't match behavior of MediaWikiIntegrationTestCase.
|
|
global $wgHooks;
|
|
$wgHooks[$hookName] = [ $handler ];
|
|
}
|
|
}
|