45d4e8d13a
@covers does not make any sense for structure tests, which either do not cover any PHP lines (they test things like configuration or messages), or cover lines which cannot be determined at the time of writing the tests (e.g. they cover all classes implementing a certain interface). Requiring @coversNothing to be manually added for all of them is a waste of developer time. tests/phpunit/suite.xml has forceCoversAnnotation=true so removing the annotations will not change test coverage, these files will still be skipped. Change-Id: I27cb58e92341b9b1a76f109701f5bc843adbaa9b
101 lines
2.5 KiB
PHP
101 lines
2.5 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Try to make sure that extensions register all rights in $wgAvailableRights
|
|
* or via the 'UserGetAllRights' hook.
|
|
*
|
|
* @author Marius Hoch < hoo@online.de >
|
|
*/
|
|
class AvailableRightsTest extends PHPUnit\Framework\TestCase {
|
|
|
|
use MediaWikiCoversValidator;
|
|
|
|
/**
|
|
* Returns all rights that should be in $wgAvailableRights + all rights
|
|
* registered via the 'UserGetAllRights' hook + all "core" rights.
|
|
*
|
|
* @return string[]
|
|
*/
|
|
private function getAllVisibleRights() {
|
|
global $wgGroupPermissions, $wgRevokePermissions;
|
|
|
|
$rights = User::getAllRights();
|
|
|
|
foreach ( $wgGroupPermissions as $permissions ) {
|
|
$rights = array_merge( $rights, array_keys( $permissions ) );
|
|
}
|
|
|
|
foreach ( $wgRevokePermissions as $permissions ) {
|
|
$rights = array_merge( $rights, array_keys( $permissions ) );
|
|
}
|
|
|
|
$rights = array_unique( $rights );
|
|
sort( $rights );
|
|
|
|
return $rights;
|
|
}
|
|
|
|
public function testAvailableRights() {
|
|
$missingRights = array_diff(
|
|
$this->getAllVisibleRights(),
|
|
User::getAllRights()
|
|
);
|
|
|
|
$this->assertEquals(
|
|
[],
|
|
// Re-index to produce nicer output, keys are meaningless.
|
|
array_values( $missingRights ),
|
|
'Additional user rights need to be added to $wgAvailableRights or ' .
|
|
'via the "UserGetAllRights" hook. See the instructions at: ' .
|
|
'https://www.mediawiki.org/wiki/Manual:User_rights#Adding_new_rights'
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Test, if for all rights an action- message exist,
|
|
* which is used on Special:ListGroupRights as help text
|
|
* Extensions and core
|
|
*
|
|
* @coversNothing
|
|
*/
|
|
public function testAllActionsWithMessages() {
|
|
$this->checkMessagesExist( 'action-' );
|
|
}
|
|
|
|
/**
|
|
* Test, if for all rights a right- message exist,
|
|
* which is used on Special:ListGroupRights as help text
|
|
* Extensions and core
|
|
*/
|
|
public function testAllRightsWithMessage() {
|
|
$this->checkMessagesExist( 'right-' );
|
|
}
|
|
|
|
/**
|
|
* @param string $prefix
|
|
*/
|
|
private function checkMessagesExist( $prefix ) {
|
|
// Getting all user rights, for core: User::$mCoreRights, for extensions: $wgAvailableRights
|
|
$allRights = User::getAllRights();
|
|
$allMessageKeys = Language::getMessageKeysFor( 'en' );
|
|
|
|
$messagesToCheck = [];
|
|
foreach ( $allMessageKeys as $message ) {
|
|
// === 0: must be at beginning of string (position 0)
|
|
if ( strpos( $message, $prefix ) === 0 ) {
|
|
$messagesToCheck[] = substr( $message, strlen( $prefix ) );
|
|
}
|
|
}
|
|
|
|
$missing = array_diff(
|
|
$allRights,
|
|
$messagesToCheck
|
|
);
|
|
|
|
$this->assertEquals(
|
|
[],
|
|
$missing,
|
|
"Each user right (core/extensions) has a corresponding $prefix message."
|
|
);
|
|
}
|
|
}
|