wiki.techinc.nl/includes/libs/objectcache/HashBagOStuff.php
Timo Tijhof 75aec3686a objectcache: Reduce boilerplate and indirection around makeKey()
== Background

Most of this was introduced in commit 5c335f9d77 (I1eb897c2cea3f5b7).
The original motivation was:

* Ensure wrappers like MultiWriteBagOStuff naturally do the right
  thing. In practice, makeKey() results are interchangeable, with
  the most contrained one (Memcached) also generally used as the first
  tier. However, this is not intuitive and may change in the future.
  To make it more intuitive, the default implemention became known
  as "generic", with proxyCall() responsible for decoding these,
  and then re-encoding them with makeKey() from the respective
  underlying BagOStuff. This meant that MultiWriteBag would no longer
  use the result of the Memcached-formatted cache key and pass it
  to SqlBagOStuff.

* Allow extraction of the key group from a given key cache,
  for use in statistics.

Both motivations remains valid and addressed after this refactor.

== Change

* Remove boilerplate and indirection around makeKey from a dozen
  classes. E.g. copy-paste stubs for makeKey, makeKeyInternal, and
  convertGenericKey.

  Instead, let BagOStuff::makeKey and ::makeKeyInternal hold the
  defaults. I believe this makes the logic easier to find, understand,
  and refer to.

  The three non-default implementations (Memcached, WinCache, Sql)
  now naturally reflect what they are in terms of business logic,
  they are a method override.

  Introduce a single boolean requireConvertGenericKey() to let the
  three non-default implementations signal their need to convert
  keys before use.

* Further improve internal consistently of BagOStuff::makeKeyInternal.

  The logic of genericKeyFromComponents() was moved up into
  BagOStuff::makeKeyInternal. As a result of caling this directly
  from BagOStuff::makeKey(), this code now sees $keyspace and $components
  as separate arguments. To keep the behaviour the same, we would
  have to either unshift $keyspace into $components, or duplicate
  the strtr() call to escape it.

  Instead, excempt keyspace from escaping. This matches how the most
  commonly used BagOStuff implementations (MemcachedBag, and SqlBag)
  already worked for 10+ years, thus this does not introduce any new
  responsibility on callers. In particular, keyspace (not key group)
  is set by MediaWiki core in service wiring to the wiki ID, and so
  is not the concern of individual callers anyway.

* Docs: Explain in proxyCall() why this indirection and complexity
  exists. It lets wrapping classes decode and re-encode keys.

* Docs: Explain the cross-wiki and local-wiki semantics of makeKey
  and makeKeyGlobal, and centralise this and other important docs
  about this method in the place with the most eye balls where it is
  most likely seen and discovered, namely BagOStuff::makeKey.
  Remove partial docs from other places in favour of references to this one.

  Previously, there was no particular reason to follow `@see IStoreKeyEncoder`
  much less to know that it holds critical that communicate the
  responsibility to limit the key group to 48 chars.

* Docs: Consistently refer to the first component as the "key group",
  thus unifying what was known as "key class", "collection",
  "key collection name", or "collection name".

  The term "key group" seems to be what is used by developers in
  conversations for this concept, matching WMF on-boarding docs and
  WMF's Grafana dashboard for WANObjectCache.

Change-Id: I6b3167cac824d8bd8773bc66c386f41e4d380021
2023-08-03 10:42:56 +02:00

168 lines
4.5 KiB
PHP

<?php
/**
* Per-process memory cache for storing items.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
* @ingroup Cache
*/
/**
* Simple store for keeping values in an associative array for the current process.
*
* Data will not persist and is not shared with other processes.
*
* @newable
* @ingroup Cache
*/
class HashBagOStuff extends MediumSpecificBagOStuff {
/** @var mixed[] */
protected $bag = [];
/** @var int|double Max entries allowed, INF for unlimited */
protected $maxCacheKeys;
/** @var string CAS token prefix for this instance */
private $token;
/** @var int CAS token counter */
private static $casCounter = 0;
public const KEY_VAL = 0;
public const KEY_EXP = 1;
public const KEY_CAS = 2;
/**
* @stable to call
* @param array $params Additional parameters include:
* - maxKeys : only allow this many keys (using oldest-first eviction)
* @phpcs:ignore Generic.Files.LineLength
* @phan-param array{logger?:Psr\Log\LoggerInterface,asyncHandler?:callable,keyspace?:string,reportDupes?:bool,segmentationSize?:int,segmentedValueMaxSize?:int,maxKeys?:int} $params
*/
public function __construct( $params = [] ) {
$params['segmentationSize'] ??= INF;
parent::__construct( $params );
$this->token = microtime( true ) . ':' . mt_rand();
$maxKeys = $params['maxKeys'] ?? INF;
if ( $maxKeys !== INF && ( !is_int( $maxKeys ) || $maxKeys <= 0 ) ) {
throw new InvalidArgumentException( '$maxKeys parameter must be above zero' );
}
$this->maxCacheKeys = $maxKeys;
$this->attrMap[self::ATTR_DURABILITY] = self::QOS_DURABILITY_SCRIPT;
}
protected function doGet( $key, $flags = 0, &$casToken = null ) {
$getToken = ( $casToken === self::PASS_BY_REF );
$casToken = null;
if ( !$this->hasKey( $key ) || $this->expire( $key ) ) {
return false;
}
// Refresh key position for maxCacheKeys eviction
$temp = $this->bag[$key];
unset( $this->bag[$key] );
$this->bag[$key] = $temp;
$value = $this->bag[$key][self::KEY_VAL];
if ( $getToken && $value !== false ) {
$casToken = $this->bag[$key][self::KEY_CAS];
}
return $value;
}
protected function doSet( $key, $value, $exptime = 0, $flags = 0 ) {
// Refresh key position for maxCacheKeys eviction
unset( $this->bag[$key] );
$this->bag[$key] = [
self::KEY_VAL => $value,
self::KEY_EXP => $this->getExpirationAsTimestamp( $exptime ),
self::KEY_CAS => $this->token . ':' . ++self::$casCounter
];
if ( count( $this->bag ) > $this->maxCacheKeys ) {
$evictKey = array_key_first( $this->bag );
unset( $this->bag[$evictKey] );
}
return true;
}
protected function doAdd( $key, $value, $exptime = 0, $flags = 0 ) {
if ( $this->hasKey( $key ) && !$this->expire( $key ) ) {
// key already set
return false;
}
return $this->doSet( $key, $value, $exptime, $flags );
}
protected function doDelete( $key, $flags = 0 ) {
unset( $this->bag[$key] );
return true;
}
protected function doIncrWithInit( $key, $exptime, $step, $init, $flags ) {
$curValue = $this->doGet( $key );
if ( $curValue === false ) {
$newValue = $this->doSet( $key, $init, $exptime ) ? $init : false;
} elseif ( $this->isInteger( $curValue ) ) {
$newValue = max( $curValue + $step, 0 );
$this->bag[$key][self::KEY_VAL] = $newValue;
} else {
$newValue = false;
}
return $newValue;
}
/**
* Clear all values in cache
*/
public function clear() {
$this->bag = [];
}
/**
* @param string $key
* @return bool
*/
protected function expire( $key ) {
$et = $this->bag[$key][self::KEY_EXP];
if ( $et == self::TTL_INDEFINITE || $et > $this->getCurrentTime() ) {
return false;
}
$this->doDelete( $key );
return true;
}
/**
* Does this bag have a non-null value for the given key?
*
* @param string $key
* @return bool
* @since 1.27
*/
public function hasKey( $key ) {
return isset( $this->bag[$key] );
}
}