c7ee0dbf96
Move parts of implementation code comments into something that is discoverable and understable to a general audience of MW core and skin developers (not hidden in code mostly seen by maintainers and contributors to ResourceLoader internals). Most notably, that the system is turned off by default (and how to turn it on), that it is limited to requests by unregistered users, and that the class must follow a certain pattern. $wgResourceLoaderClientPreferences is removed as part of this. This is not considered a breaking change as the feature is now automatically on in the skins needs it (via skin.json), and previously it was marked experimental and off by default. Skins are naturally required to have knowledge of this system, as they need to call into it to persist classes for feature toggles. By removing the need to also enable it at the site-level we get a few benefits: 1) make skins like Vector easier to correctly install and configure. 2) ease maintenance for skin devs by removing the need to manually export and check $wgResourceLoaderClientPreferences before calling mw.user.clientPrefs or otherwise hinting in UI or docs that the feature persists when it might not be turned on on a given MW site or WMF wiki. 3) ease browser testing in CI. Bug: T344069 Depends-On: If9b83dd559cda2dac315afcb65a4761b9e97f319 Change-Id: Ib0b5ee29ec7accb7b291830d2ab6566fe4f4c0c5 |
||
|---|---|---|
| .. | ||
| templates | ||
| ClientHtmlTest.php | ||
| ContextTest.php | ||
| DerivativeContextTest.php | ||
| FileModuleTest.php | ||
| ImageModuleTest.php | ||
| LessVarFileModuleTest.php | ||
| MessageBlobStoreTest.php | ||
| ModuleTest.php | ||
| OOUIImageModuleTest.php | ||
| ResourceLoaderTest.php | ||
| SkinModuleTest.php | ||
| StartUpModuleTest.php | ||
| UserOptionsModuleTest.php | ||
| WikiModuleTest.php | ||