4e6810e4a2
API warnings and error messages are currently hard-coded English strings. This patch changes that. With a few exceptions, this patch should be compatible with non-updated extensions: * The change to ApiBase::$messageMap will blow up anything trying to mess with it. * The changes to the 'ApiCheckCanExecute' hook will cause a wrong (probably unparsed) error message to be emitted for extensions not already using an ApiMessage. Unless they're currently broken like Wikibase. Bug: T37074 Bug: T47843 Depends-On: Ia2b66b57cd4eaddc30b3ffdd7b97d6ca3e02d898 Depends-On: I2e1bb975bb0045476c03ebe6cdec00259bae22ec Depends-On: I53987bf87c48f6c00deec17a8e957d24fcc3eaa6 Depends-On: Ibf93a459eb62d30f7c70d20e91ec9faeb80d10ed Depends-On: I3cf889811f44a15935e454dd42f081164d4a098c Depends-On: Ieae527de86735ddcba34724730e8730fb277b99b Depends-On: I535344c29d51521147c2a26c341dae38cec3e931 Change-Id: Iae0e2ce3bd42dd4776a9779664086119ac188412
83 lines
2 KiB
PHP
83 lines
2 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group API
|
|
* @group Database
|
|
* @group medium
|
|
*
|
|
* @covers ApiBlock
|
|
*/
|
|
class ApiBlockTest extends ApiTestCase {
|
|
protected function setUp() {
|
|
parent::setUp();
|
|
$this->doLogin();
|
|
}
|
|
|
|
protected function getTokens() {
|
|
return $this->getTokenList( self::$users['sysop'] );
|
|
}
|
|
|
|
function addDBDataOnce() {
|
|
$user = User::newFromName( 'UTApiBlockee' );
|
|
|
|
if ( $user->getId() == 0 ) {
|
|
$user->addToDatabase();
|
|
TestUser::setPasswordForUser( $user, 'UTApiBlockeePassword' );
|
|
|
|
$user->saveSettings();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* This test has probably always been broken and use an invalid token
|
|
* Bug tracking brokenness is https://phabricator.wikimedia.org/T37646
|
|
*
|
|
* Root cause is https://gerrit.wikimedia.org/r/3434
|
|
* Which made the Block/Unblock API to actually verify the token
|
|
* previously always considered valid (T36212).
|
|
*/
|
|
public function testMakeNormalBlock() {
|
|
$tokens = $this->getTokens();
|
|
|
|
$user = User::newFromName( 'UTApiBlockee' );
|
|
|
|
if ( !$user->getId() ) {
|
|
$this->markTestIncomplete( "The user UTApiBlockee does not exist" );
|
|
}
|
|
|
|
if ( !array_key_exists( 'blocktoken', $tokens ) ) {
|
|
$this->markTestIncomplete( "No block token found" );
|
|
}
|
|
|
|
$this->doApiRequest( [
|
|
'action' => 'block',
|
|
'user' => 'UTApiBlockee',
|
|
'reason' => 'Some reason',
|
|
'token' => $tokens['blocktoken'] ], null, false, self::$users['sysop']->getUser() );
|
|
|
|
$block = Block::newFromTarget( 'UTApiBlockee' );
|
|
|
|
$this->assertTrue( !is_null( $block ), 'Block is valid' );
|
|
|
|
$this->assertEquals( 'UTApiBlockee', (string)$block->getTarget() );
|
|
$this->assertEquals( 'Some reason', $block->mReason );
|
|
$this->assertEquals( 'infinity', $block->mExpiry );
|
|
}
|
|
|
|
/**
|
|
* @expectedException ApiUsageException
|
|
* @expectedExceptionMessage The "token" parameter must be set
|
|
*/
|
|
public function testBlockingActionWithNoToken() {
|
|
$this->doApiRequest(
|
|
[
|
|
'action' => 'block',
|
|
'user' => 'UTApiBlockee',
|
|
'reason' => 'Some reason',
|
|
],
|
|
null,
|
|
false,
|
|
self::$users['sysop']->getUser()
|
|
);
|
|
}
|
|
}
|