We already did this, but it was rather convoluted with lots of if/elseif sequences checking all the possible values. Remove this logic from ResourceLoaderStartUpModule. Simplying it simply create the array and pass it to ResourceLoader::makeLoaderRegisterScript. In makeLoaderRegisterScript, we apply a filter to the array(s) that trim empty values. While at it: * As with other registration properties' default values (like for dependencies, group, and skip) also use 'null' for the default value of 'source'. The mediawiki.js client was already compatible with this, and the server omitted it if it was the last value in the list. But in all other cases it explicitly outputs "local". Use null instead of simplicity sake. This also gains us a few characters in the output, and a relatively larger win after gzip since there's lots more re-using of "null". * Remove stray casting of $version to int. This only happened in case of registering a single module (which don't do anywhere), and is redundant. Change-Id: I1f321e7b8bd3b5cffc550b51169957a3da9b971d |
||
|---|---|---|
| .. | ||
| data | ||
| docs | ||
| includes | ||
| languages | ||
| maintenance | ||
| mocks | ||
| skins | ||
| structure | ||
| suites | ||
| tests | ||
| bootstrap.php | ||
| install-phpunit.sh | ||
| LessFileCompilationTest.php | ||
| Makefile | ||
| MediaWikiLangTestCase.php | ||
| MediaWikiPHPUnitTestListener.php | ||
| MediaWikiTestCase.php | ||
| phpunit.php | ||
| README | ||
| ResourceLoaderTestCase.php | ||
| run-tests.bat | ||
| suite.xml | ||
| TODO | ||
== MediaWiki PHPUnit Tests == The unit tests for MediaWiki are implemented using the PHPUnit testing framework and require PHPUnit to run. === WARNING === Some of the unit tests are DESTRUCTIVE and WILL ALTER YOUR WIKI'S CONTENTS. DO NOT RUN THESE TESTS ON A PRODUCTION SYSTEM OR ON ANY SYSTEM WHERE YOU NEED TO RETAIN YOUR DATA. == Installation == If PHPUnit is not installed, follow the installation instructions in the PHPUnit Manual at: http://www.phpunit.de/manual/current/en/installation.html - or - On Unix-like operating systems, run: make install == Running tests == The tests are run from your operating system's command line. Ensure that you are in the tests/phpunit directory of your MediaWiki installation. On Unix-like operating systems, the tests runs are controlled with a makefile. Run command: make help for a full list of options for running tests. On Windows-family operating systems, run the 'run-tests.bat' batch file. === Writing tests === A guide to writing unit tests for MediaWiki can be found at: http://mediawiki.org/wiki/Unit_Testing