wiki.techinc.nl/tests/phpunit/includes/SeleniumConfigurationTest.php
Timo Tijhof 181c7cdc8e Clean and repair many phpunit tests (+ fix implied configuration)
This commit depends on the introduction of
MediaWikiTestCase::setMwGlobals in change Iccf6ea81f4.

Various tests already set their globals, but forgot to restore
them afterwards, or forgot to call the parent setUp, tearDown...

Either way they won't have to anymore with setMwGlobals.

Consistent use of function characteristics:
* protected function setUp
* protected function tearDown
* public static function (provide..)

(Matching the function signature with PHPUnit/Framework/TestCase.php)

Replaces:
 * public function (setUp|tearDown)\(
 * protected function $1(

 * \tfunction (setUp|tearDown)\(
 * \tprotected function $1(

 * \tfunction (data|provide)\(
 * \tpublic static function $1\(

Also renamed a few "data#", "provider#" and "provides#" functions
to "provide#" for consistency. This also removes confusion where
the /media tests had a few private methods called dataFile(),
which were sometimes expected to be data providers.

Fixes:

TimestampTest often failed due to a previous test setting a
different language (it tests "1 hour ago" so need to make sure
it is set to English).

MWNamespaceTest became a lot cleaner now that it executes with
a known context. Though the now-redundant code that was removed
didn't work anyway because wgContentNamespaces isn't keyed by
namespace id, it had them was values...

FileBackendTest:
* Fixed: "PHP Fatal: Using $this when not in object context"

HttpTest
* Added comment about:
  "PHP Fatal: Call to protected MWHttpRequest::__construct()"
  (too much unrelated code to fix in this commit)

ExternalStoreTest
* Add an assertTrue as well, without it the test is useless
  because regardless of whether wgExternalStores is true or false
  it only uses it if it is an array.

Change-Id: I9d2b148e57bada64afeb7d5a99bec0e58f8e1561
2012-10-09 03:01:51 +02:00

229 lines
6.1 KiB
PHP

<?php
class SeleniumConfigurationTest extends MediaWikiTestCase {
/**
* The file where the test temporarity stores the selenium config.
* This should be cleaned up as part of teardown.
*/
private $tempFileName;
/**
* String containing the a sample selenium settings
*/
private $testConfig0 =
'
[SeleniumSettings]
browsers[firefox] = "*firefox"
browsers[iexplorer] = "*iexploreproxy"
browsers[chrome] = "*chrome"
host = "localhost"
port = "foobarr"
wikiUrl = "http://localhost/deployment"
username = "xxxxxxx"
userPassword = ""
testBrowser = "chrome"
startserver =
stopserver =
jUnitLogFile =
runAgainstGrid = false
[SeleniumTests]
testSuite[SimpleSeleniumTestSuite] = "tests/selenium/SimpleSeleniumTestSuite.php"
testSuite[TestSuiteName] = "testSuitePath"
';
/**
* Array of expected browsers from $testConfig0
*/
private $testBrowsers0 = array( 'firefox' => '*firefox',
'iexplorer' => '*iexploreproxy',
'chrome' => '*chrome'
);
/**
* Array of expected selenium settings from $testConfig0
*/
private $testSettings0 = array(
'host' => 'localhost',
'port' => 'foobarr',
'wikiUrl' => 'http://localhost/deployment',
'username' => 'xxxxxxx',
'userPassword' => '',
'testBrowser' => 'chrome',
'startserver' => null,
'stopserver' => null,
'seleniumserverexecpath' => null,
'jUnitLogFile' => null,
'runAgainstGrid' => null
);
/**
* Array of expected testSuites from $testConfig0
*/
private $testSuites0 = array(
'SimpleSeleniumTestSuite' => 'tests/selenium/SimpleSeleniumTestSuite.php',
'TestSuiteName' => 'testSuitePath'
);
/**
* Another sample selenium settings file contents
*/
private $testConfig1 =
'
[SeleniumSettings]
host = "localhost"
testBrowser = "firefox"
';
/**
* Expected browsers from $testConfig1
*/
private $testBrowsers1 = null;
/**
* Expected selenium settings from $testConfig1
*/
private $testSettings1 = array(
'host' => 'localhost',
'port' => null,
'wikiUrl' => null,
'username' => null,
'userPassword' => null,
'testBrowser' => 'firefox',
'startserver' => null,
'stopserver' => null,
'seleniumserverexecpath' => null,
'jUnitLogFile' => null,
'runAgainstGrid' => null
);
/**
* Expected test suites from $testConfig1
*/
private $testSuites1 = null;
protected function setUp() {
parent::setUp();
if ( !defined( 'SELENIUMTEST' ) ) {
define( 'SELENIUMTEST', true );
}
}
/**
* Clean up the temporary file used to store the selenium settings.
*/
protected function tearDown() {
if ( strlen( $this->tempFileName ) > 0 ) {
unlink( $this->tempFileName );
unset( $this->tempFileName );
}
parent::tearDown();
}
/**
* @expectedException MWException
* @group SeleniumFramework
*/
public function testErrorOnIncorrectConfigFile() {
$seleniumSettings = array();
$seleniumBrowsers = array();
$seleniumTestSuites = array();
SeleniumConfig::getSeleniumSettings($seleniumSettings,
$seleniumBrowsers,
$seleniumTestSuites,
"Some_fake_settings_file.ini" );
}
/**
* @expectedException MWException
* @group SeleniumFramework
*/
public function testErrorOnMissingConfigFile() {
$seleniumSettings = array();
$seleniumBrowsers = array();
$seleniumTestSuites = array();
global $wgSeleniumConfigFile;
$wgSeleniumConfigFile = '';
SeleniumConfig::getSeleniumSettings($seleniumSettings,
$seleniumBrowsers,
$seleniumTestSuites);
}
/**
* @group SeleniumFramework
*/
public function testUsesGlobalVarForConfigFile() {
$seleniumSettings = array();
$seleniumBrowsers = array();
$seleniumTestSuites = array();
global $wgSeleniumConfigFile;
$this->writeToTempFile( $this->testConfig0 );
$wgSeleniumConfigFile = $this->tempFileName;
SeleniumConfig::getSeleniumSettings($seleniumSettings,
$seleniumBrowsers,
$seleniumTestSuites);
$this->assertEquals($seleniumSettings, $this->testSettings0 ,
'The selenium settings should have been read from the file defined in $wgSeleniumConfigFile'
);
$this->assertEquals($seleniumBrowsers, $this->testBrowsers0,
'The available browsers should have been read from the file defined in $wgSeleniumConfigFile'
);
$this->assertEquals($seleniumTestSuites, $this->testSuites0,
'The test suites should have been read from the file defined in $wgSeleniumConfigFile'
);
}
/**
* @group SeleniumFramework
* @dataProvider sampleConfigs
*/
public function testgetSeleniumSettings($sampleConfig, $expectedSettings, $expectedBrowsers, $expectedSuites ) {
$this->writeToTempFile( $sampleConfig );
$seleniumSettings = array();
$seleniumBrowsers = array();
$seleniumTestSuites = null;
SeleniumConfig::getSeleniumSettings($seleniumSettings,
$seleniumBrowsers,
$seleniumTestSuites,
$this->tempFileName );
$this->assertEquals($seleniumSettings, $expectedSettings,
"The selenium settings for the following test configuration was not retrieved correctly" . $sampleConfig
);
$this->assertEquals($seleniumBrowsers, $expectedBrowsers,
"The available browsers for the following test configuration was not retrieved correctly" . $sampleConfig
);
$this->assertEquals($seleniumTestSuites, $expectedSuites,
"The test suites for the following test configuration was not retrieved correctly" . $sampleConfig
);
}
/**
* create a temp file and write text to it.
* @param $testToWrite the text to write to the temp file
*/
private function writeToTempFile($textToWrite) {
$this->tempFileName = tempnam(sys_get_temp_dir(), 'test_settings.');
$tempFile = fopen( $this->tempFileName, "w" );
fwrite($tempFile , $textToWrite);
fclose($tempFile);
}
/**
* Returns an array containing:
* The contents of the selenium cingiguration ini file
* The expected selenium configuration array that getSeleniumSettings should return
* The expected available browsers array that getSeleniumSettings should return
* The expected test suites arrya that getSeleniumSettings should return
*/
public function sampleConfigs() {
return array(
array($this->testConfig0, $this->testSettings0, $this->testBrowsers0, $this->testSuites0 ),
array($this->testConfig1, $this->testSettings1, $this->testBrowsers1, $this->testSuites1 )
);
}
}