181c7cdc8e
This commit depends on the introduction of MediaWikiTestCase::setMwGlobals in change Iccf6ea81f4. Various tests already set their globals, but forgot to restore them afterwards, or forgot to call the parent setUp, tearDown... Either way they won't have to anymore with setMwGlobals. Consistent use of function characteristics: * protected function setUp * protected function tearDown * public static function (provide..) (Matching the function signature with PHPUnit/Framework/TestCase.php) Replaces: * public function (setUp|tearDown)\( * protected function $1( * \tfunction (setUp|tearDown)\( * \tprotected function $1( * \tfunction (data|provide)\( * \tpublic static function $1\( Also renamed a few "data#", "provider#" and "provides#" functions to "provide#" for consistency. This also removes confusion where the /media tests had a few private methods called dataFile(), which were sometimes expected to be data providers. Fixes: TimestampTest often failed due to a previous test setting a different language (it tests "1 hour ago" so need to make sure it is set to English). MWNamespaceTest became a lot cleaner now that it executes with a known context. Though the now-redundant code that was removed didn't work anyway because wgContentNamespaces isn't keyed by namespace id, it had them was values... FileBackendTest: * Fixed: "PHP Fatal: Using $this when not in object context" HttpTest * Added comment about: "PHP Fatal: Call to protected MWHttpRequest::__construct()" (too much unrelated code to fix in this commit) ExternalStoreTest * Add an assertTrue as well, without it the test is useless because regardless of whether wgExternalStores is true or false it only uses it if it is an array. Change-Id: I9d2b148e57bada64afeb7d5a99bec0e58f8e1561
117 lines
2.7 KiB
PHP
117 lines
2.7 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @group API
|
|
* @group Database
|
|
*/
|
|
class ApiBlockTest extends ApiTestCase {
|
|
|
|
protected function setUp() {
|
|
parent::setUp();
|
|
$this->doLogin();
|
|
}
|
|
|
|
function getTokens() {
|
|
return $this->getTokenList( self::$users['sysop'] );
|
|
}
|
|
|
|
function addDBData() {
|
|
$user = User::newFromName( 'UTApiBlockee' );
|
|
|
|
if ( $user->getId() == 0 ) {
|
|
$user->addToDatabase();
|
|
$user->setPassword( 'UTApiBlockeePassword' );
|
|
|
|
$user->saveSettings();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* This test has probably always been broken and use an invalid token
|
|
* Bug tracking brokenness is https://bugzilla.wikimedia.org/35646
|
|
*
|
|
* Root cause is https://gerrit.wikimedia.org/r/3434
|
|
* Which made the Block/Unblock API to actually verify the token
|
|
* previously always considered valid (bug 34212).
|
|
*/
|
|
function testMakeNormalBlock() {
|
|
|
|
$data = $this->getTokens();
|
|
|
|
$user = User::newFromName( 'UTApiBlockee' );
|
|
|
|
if ( !$user->getId() ) {
|
|
$this->markTestIncomplete( "The user UTApiBlockee does not exist" );
|
|
}
|
|
|
|
if( !isset( $data[0]['query']['pages'] ) ) {
|
|
$this->markTestIncomplete( "No block token found" );
|
|
}
|
|
|
|
$keys = array_keys( $data[0]['query']['pages'] );
|
|
$key = array_pop( $keys );
|
|
$pageinfo = $data[0]['query']['pages'][$key];
|
|
|
|
$data = $this->doApiRequest( array(
|
|
'action' => 'block',
|
|
'user' => 'UTApiBlockee',
|
|
'reason' => 'Some reason',
|
|
'token' => $pageinfo['blocktoken'] ), null, false, self::$users['sysop']->user );
|
|
|
|
$block = Block::newFromTarget('UTApiBlockee');
|
|
|
|
$this->assertTrue( !is_null( $block ), 'Block is valid' );
|
|
|
|
$this->assertEquals( 'UTApiBlockee', (string)$block->getTarget() );
|
|
$this->assertEquals( 'Some reason', $block->mReason );
|
|
$this->assertEquals( 'infinity', $block->mExpiry );
|
|
|
|
}
|
|
|
|
/**
|
|
* @dataProvider provideBlockUnblockAction
|
|
*/
|
|
function testGetTokenUsingABlockingAction( $action ) {
|
|
$data = $this->doApiRequest(
|
|
array(
|
|
'action' => $action,
|
|
'user' => 'UTApiBlockee',
|
|
'gettoken' => '' ),
|
|
null,
|
|
false,
|
|
self::$users['sysop']->user
|
|
);
|
|
$this->assertEquals( 34, strlen( $data[0][$action]["{$action}token"] ) );
|
|
}
|
|
|
|
/**
|
|
* Attempting to block without a token should give a UsageException with
|
|
* error message:
|
|
* "The token parameter must be set"
|
|
*
|
|
* @dataProvider provideBlockUnblockAction
|
|
* @expectedException UsageException
|
|
*/
|
|
function testBlockingActionWithNoToken( $action ) {
|
|
$this->doApiRequest(
|
|
array(
|
|
'action' => $action,
|
|
'user' => 'UTApiBlockee',
|
|
'reason' => 'Some reason',
|
|
),
|
|
null,
|
|
false,
|
|
self::$users['sysop']->user
|
|
);
|
|
}
|
|
|
|
/**
|
|
* Just provide the 'block' and 'unblock' action to test both API calls
|
|
*/
|
|
function provideBlockUnblockAction() {
|
|
return array(
|
|
array( 'block' ),
|
|
array( 'unblock' ),
|
|
);
|
|
}
|
|
}
|