Most of the code in WatchlistManager does not depend on integration logic, with the exception of - ::clearTitleUserNotifications adding a DeferredUpdate - ::addWatch and ::removeWatch using User::newFatalPermissionDeniedStatus, which uses MediaWikiServices Move the majority of the rest to the unit tests, except for an integration test of the overall basic functionality that we leave to make sure that the integration with the actual services works properly. Also take this opportunity to document why the integration tests left behind need to be integration test, and fix the name of some tests to addWach/removeWatch instead of the old doWatch/doUnwatch. Explicitely add 'watchlist' to the tables used by the integration test. Change-Id: I899ef1618c59c179ed2591149b93969fd935276d |
||
|---|---|---|
| .. | ||
| includes | ||