c2743edd26
This was testing regex with completely unecessary long string. I believe it was meant to be the test message instead of being the haystack. Only the value of $alias may contain the slash, the rest of the string has no any other slash, this is already known. Also use simple string assertion instead of regex matching Change-Id: I47eb0bfcd510e4f1c92099a9cb53b584a34036ce
57 lines
1.3 KiB
PHP
57 lines
1.3 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Verifies that special page aliases are valid, with no slashes.
|
|
*
|
|
* @group Language
|
|
* @group SpecialPageAliases
|
|
* @group SystemTest
|
|
* @group medium
|
|
* @todo This should be a structure test
|
|
*
|
|
* @author Katie Filbert < aude.wiki@gmail.com >
|
|
*/
|
|
class SpecialPageAliasTest extends MediaWikiIntegrationTestCase {
|
|
|
|
/**
|
|
* @coversNothing
|
|
* @dataProvider validSpecialPageAliasesProvider
|
|
*/
|
|
public function testValidSpecialPageAliases( $code, $specialPageAliases ) {
|
|
foreach ( $specialPageAliases as $specialPage => $aliases ) {
|
|
foreach ( $aliases as $alias ) {
|
|
$msg = "Special:$specialPage alias '$alias' in $code must not contain slashes";
|
|
$this->assertStringNotContainsString( '/', $alias, $msg );
|
|
}
|
|
}
|
|
}
|
|
|
|
public function validSpecialPageAliasesProvider() {
|
|
$codes = array_keys( Language::fetchLanguageNames( null, 'mwfile' ) );
|
|
|
|
foreach ( $codes as $code ) {
|
|
$specialPageAliases = $this->getSpecialPageAliases( $code );
|
|
|
|
if ( $specialPageAliases !== [] ) {
|
|
yield [ $code, $specialPageAliases ];
|
|
}
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @param string $code
|
|
*
|
|
* @return array
|
|
*/
|
|
protected function getSpecialPageAliases( $code ) {
|
|
$file = Language::getMessagesFileName( $code );
|
|
|
|
if ( is_readable( $file ) ) {
|
|
include $file;
|
|
return $specialPageAliases ?? [];
|
|
}
|
|
|
|
return [];
|
|
}
|
|
|
|
}
|