7ffea90b5c
The other field is in most case the default item selected in the drop down box when a page is loaded. But when the last item is selected you have to scroll to the top to select one of the first item, which are often the common or most used items. So adding the 'other' always as first item to the list. For the HTMLSelectAndOtherField this was before If4175332405d26c7ff2e8fbe100bcad61762ce6f, so that is fixing a regression. In my opinion it should be the same for both types. Follow-Up: If4175332405d26c7ff2e8fbe100bcad61762ce6f Change-Id: I82f31e260d63bfaa6a4a94908e019feb9e0f2421
83 lines
2.1 KiB
PHP
83 lines
2.1 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Select dropdown field, with an additional "other" textbox.
|
|
*/
|
|
class HTMLSelectOrOtherField extends HTMLTextField {
|
|
function __construct( $params ) {
|
|
parent::__construct( $params );
|
|
$this->getOptions();
|
|
if ( !in_array( 'other', $this->mOptions, true ) ) {
|
|
$msg =
|
|
isset( $params['other'] )
|
|
? $params['other']
|
|
: wfMessage( 'htmlform-selectorother-other' )->text();
|
|
// Have 'other' always as first element
|
|
$this->mOptions = array( $msg => 'other' ) + $this->mOptions;
|
|
}
|
|
|
|
}
|
|
|
|
function getInputHTML( $value ) {
|
|
$valInSelect = false;
|
|
|
|
if ( $value !== false ) {
|
|
$value = strval( $value );
|
|
$valInSelect = in_array(
|
|
$value, HTMLFormField::flattenOptions( $this->getOptions() ), true
|
|
);
|
|
}
|
|
|
|
$selected = $valInSelect ? $value : 'other';
|
|
|
|
$select = new XmlSelect( $this->mName, $this->mID, $selected );
|
|
$select->addOptions( $this->getOptions() );
|
|
|
|
$select->setAttribute( 'class', 'mw-htmlform-select-or-other' );
|
|
|
|
$tbAttribs = array( 'id' => $this->mID . '-other', 'size' => $this->getSize() );
|
|
|
|
if ( !empty( $this->mParams['disabled'] ) ) {
|
|
$select->setAttribute( 'disabled', 'disabled' );
|
|
$tbAttribs['disabled'] = 'disabled';
|
|
}
|
|
|
|
if ( isset( $this->mParams['tabindex'] ) ) {
|
|
$select->setAttribute( 'tabindex', $this->mParams['tabindex'] );
|
|
$tbAttribs['tabindex'] = $this->mParams['tabindex'];
|
|
}
|
|
|
|
$select = $select->getHTML();
|
|
|
|
if ( isset( $this->mParams['maxlength'] ) ) {
|
|
$tbAttribs['maxlength'] = $this->mParams['maxlength'];
|
|
}
|
|
|
|
if ( $this->mClass !== '' ) {
|
|
$tbAttribs['class'] = $this->mClass;
|
|
}
|
|
|
|
$textbox = Html::input( $this->mName . '-other', $valInSelect ? '' : $value, 'text', $tbAttribs );
|
|
|
|
return "$select<br />\n$textbox";
|
|
}
|
|
|
|
/**
|
|
* @param WebRequest $request
|
|
*
|
|
* @return string
|
|
*/
|
|
function loadDataFromRequest( $request ) {
|
|
if ( $request->getCheck( $this->mName ) ) {
|
|
$val = $request->getText( $this->mName );
|
|
|
|
if ( $val === 'other' ) {
|
|
$val = $request->getText( $this->mName . '-other' );
|
|
}
|
|
|
|
return $val;
|
|
} else {
|
|
return $this->getDefault();
|
|
}
|
|
}
|
|
}
|