Support migration stages when reading and writing blocks. I tried to set it up for an easy next stage, in which support for the old schema is removed. I tried to avoid factoring out of shared code between the two schemas, so that the old schema cases can simply be deleted without the need to revert unnecessary abstractions. However, I added HideUserUtils to factor out ipb_deleted queries. Code review showed that this was already quite complex, with multiple approaches to the problem, so it benefits from refactoring even without the schema abstraction. HideUserUtils is a service rather than a standalone class to support unit tests, since unit tests do not allow global config access. When the migration stage config is removed, it will be a service with no constructor parameters -- an unnecessary abstraction which should ideally be resolved at that time. When interpreting result rows, it is possible to share code by using field aliases. But when constructing WHERE conditions, the actual field names need to be used, so the migration is more intrusive in ApiQueryBlocks and SpecialBlockList, where complex conditions are used. Bug: T346293 Bug: T51504 Bug: T349883 Change-Id: I408acf7a57b0100fe18c455fc13141277a598925
172 lines
6 KiB
PHP
172 lines
6 KiB
PHP
<?php
|
|
|
|
use MediaWiki\Config\ServiceOptions;
|
|
use MediaWiki\Linker\LinkRenderer;
|
|
use MediaWiki\Linker\LinkTarget;
|
|
use MediaWiki\MediaWikiServices;
|
|
use MediaWiki\Page\ExistingPageRecord;
|
|
use MediaWiki\Page\PageStore;
|
|
use MediaWiki\Tests\Unit\Permissions\MockAuthorityTrait;
|
|
use MediaWiki\User\UserFactory;
|
|
use Wikimedia\IPUtils;
|
|
use Wikimedia\Rdbms\ILoadBalancer;
|
|
use Wikimedia\TestingAccessWrapper;
|
|
|
|
/**
|
|
* @since 1.26
|
|
*/
|
|
abstract class LogFormatterTestCase extends MediaWikiLangTestCase {
|
|
use MockAuthorityTrait;
|
|
|
|
public function doTestLogFormatter( $row, $extra, $userGroups = [] ) {
|
|
RequestContext::resetMain();
|
|
$row = $this->expandDatabaseRow( $row, $this->isLegacy( $extra ) );
|
|
|
|
$userGroups = (array)$userGroups;
|
|
$userRights = MediaWikiServices::getInstance()->getGroupPermissionsLookup()->getGroupPermissions( $userGroups );
|
|
$context = new RequestContext();
|
|
$authority = $this->mockRegisteredAuthorityWithPermissions( $userRights );
|
|
$context->setAuthority( $authority );
|
|
$context->setLanguage( 'en' );
|
|
|
|
$formatter = LogFormatter::newFromRow( $row );
|
|
$formatter->setContext( $context );
|
|
|
|
// Create a LinkRenderer without LinkCache to avoid DB access
|
|
$services = $this->getServiceContainer();
|
|
$realLinkRenderer = new LinkRenderer(
|
|
$services->getTitleFormatter(),
|
|
$this->createMock( LinkCache::class ),
|
|
$services->getSpecialPageFactory(),
|
|
$services->getHookContainer(),
|
|
new ServiceOptions(
|
|
LinkRenderer::CONSTRUCTOR_OPTIONS,
|
|
$services->getMainConfig(),
|
|
[ 'renderForComment' => false ]
|
|
)
|
|
);
|
|
// Then create a mock LinkRenderer that proxies makeLink calls to the original LinkRenderer, but assumes
|
|
// that all links are known to bypass DB access in Title::exists().
|
|
$linkRenderer = $this->createMock( LinkRenderer::class );
|
|
$linkRenderer->method( 'makeLink' )
|
|
->willReturnCallback(
|
|
static function ( $target, $text = null, $extra = [], $query = [] ) use ( $realLinkRenderer ) {
|
|
return $realLinkRenderer->makeKnownLink( $target, $text, $extra, $query );
|
|
}
|
|
);
|
|
$formatter->setLinkRenderer( $linkRenderer );
|
|
$this->setService( 'LinkRenderer', $linkRenderer );
|
|
|
|
// Create a mock PageStore where all pages are existing, in case any calls to Title::exists are not
|
|
// caught by the mocks above.
|
|
$pageStore = $this->getMockBuilder( PageStore::class )
|
|
->onlyMethods( [ 'getPageByName' ] )
|
|
->setConstructorArgs( [
|
|
new ServiceOptions( PageStore::CONSTRUCTOR_OPTIONS, $services->getMainConfig() ),
|
|
$this->createNoOpMock( ILoadBalancer::class ),
|
|
$services->getNamespaceInfo(),
|
|
$services->getTitleParser(),
|
|
null,
|
|
null
|
|
] )
|
|
->getMock();
|
|
$pageStore->method( 'getPageByName' )
|
|
->willReturn( $this->createMock( ExistingPageRecord::class ) );
|
|
$this->setService( 'PageStore', $pageStore );
|
|
|
|
// Create a mock UserFactory where all registered users are created with ID and name and where loading of
|
|
// other fields is prevented, to avoid DB access.
|
|
$origUserFactory = $services->getUserFactory();
|
|
$userFactory = $this->createMock( UserFactory::class );
|
|
$userFactory->method( 'newFromName' )
|
|
->willReturnCallback( static function ( $name, $validation ) use ( $origUserFactory ) {
|
|
$ret = $origUserFactory->newFromName( $name, $validation );
|
|
if ( !$ret ) {
|
|
return $ret;
|
|
}
|
|
$userID = IPUtils::isIPAddress( $name ) ? 0 : 42;
|
|
$ret = TestingAccessWrapper::newFromObject( $ret );
|
|
$ret->mId = $userID;
|
|
$ret->mLoadedItems = true;
|
|
return $ret->object;
|
|
} );
|
|
$userFactory->method( 'newFromId' )->willReturnCallback( [ $origUserFactory, 'newFromId' ] );
|
|
$userFactory->method( 'newAnonymous' )->willReturnCallback( [ $origUserFactory, 'newAnonymous' ] );
|
|
$this->setService( 'UserFactory', $userFactory );
|
|
|
|
// Replace gender cache to avoid gender DB lookups
|
|
$genderCache = $this->createMock( GenderCache::class );
|
|
$genderCache->method( 'getGenderOf' )->willReturn( 'unknown' );
|
|
$this->setService( 'GenderCache', $genderCache );
|
|
|
|
$this->assertEquals(
|
|
$extra['text'],
|
|
self::removeSomeHtml( $formatter->getActionText() ),
|
|
'Action text is equal to expected text'
|
|
);
|
|
|
|
$this->assertSame( // ensure types and array key order
|
|
$extra['api'],
|
|
self::removeApiMetaData( $formatter->formatParametersForApi() ),
|
|
'Api log params is equal to expected array'
|
|
);
|
|
|
|
if ( isset( $extra['preload'] ) ) {
|
|
$this->assertArrayEquals(
|
|
$this->getLinkTargetsAsStrings( $extra['preload'] ),
|
|
$this->getLinkTargetsAsStrings(
|
|
$formatter->getPreloadTitles()
|
|
)
|
|
);
|
|
}
|
|
}
|
|
|
|
private function getLinkTargetsAsStrings( array $linkTargets ) {
|
|
return array_map( static function ( LinkTarget $t ) {
|
|
return $t->getInterwiki() . ':' . $t->getNamespace() . ':'
|
|
. $t->getDBkey() . '#' . $t->getFragment();
|
|
}, $linkTargets );
|
|
}
|
|
|
|
protected function isLegacy( $extra ) {
|
|
return isset( $extra['legacy'] ) && $extra['legacy'];
|
|
}
|
|
|
|
protected function expandDatabaseRow( $data, $legacy ) {
|
|
return [
|
|
// no log_id because no insert in database
|
|
'log_type' => $data['type'],
|
|
'log_action' => $data['action'],
|
|
'log_timestamp' => $data['timestamp'] ?? wfTimestampNow(),
|
|
'log_user' => $data['user'] ?? 42,
|
|
'log_user_text' => $data['user_text'] ?? 'User',
|
|
'log_actor' => $data['actor'] ?? 24,
|
|
'log_namespace' => $data['namespace'] ?? NS_MAIN,
|
|
'log_title' => $data['title'] ?? 'Main_Page',
|
|
'log_page' => $data['page'] ?? 0,
|
|
'log_comment_text' => $data['comment'] ?? '',
|
|
'log_comment_data' => null,
|
|
'log_params' => $legacy
|
|
? LogPage::makeParamBlob( $data['params'] )
|
|
: LogEntryBase::makeParamBlob( $data['params'] ),
|
|
'log_deleted' => $data['deleted'] ?? 0,
|
|
];
|
|
}
|
|
|
|
protected static function removeSomeHtml( $html ) {
|
|
$html = str_replace( '"', '"', $html );
|
|
$html = preg_replace( '/\xE2\x80[\x8E\x8F]/', '', $html ); // Strip lrm/rlm
|
|
return trim( strip_tags( $html ) );
|
|
}
|
|
|
|
protected static function removeApiMetaData( $val ) {
|
|
if ( is_array( $val ) ) {
|
|
unset( $val['_element'] );
|
|
unset( $val['_type'] );
|
|
foreach ( $val as $key => $value ) {
|
|
$val[$key] = self::removeApiMetaData( $value );
|
|
}
|
|
}
|
|
return $val;
|
|
}
|
|
}
|