Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/includes
History
Aryeh Gregor cf818256fb New RestrictionStore service 
This allows checking restrictions without a dependency on Title, based
only on a PageIdentity.

Additional fixes along the way:

* Correctly return false instead of 'infinity' for
  getRestrictionExpiry( 'create' ) on an existing page
* Correctly handle non-special pages that can't exist (like media pages)
  in listApplicableRestrictionTypes() (return empty array instead of
  'create')
* Improve readability of isProtected()

The expectation change in TitleTest::testIsProtected() is because the
test was formerly broken, since it set mRestrictions without setting
mRestrictionsLoaded. (Which illustrates how this approach to testing is
essentially broken.)

Co-authored-by: Vedmaka <god.vedmaka@gmail.com>
Bug: T218395
Change-Id: Ia73ea587586cb69eb53265b2f8f7a296a2573dd0
2021-08-28 16:01:06 +00:00
..
actions ActionFactory: restore missing check for non-existent classes 2021-08-19 14:22:11 +00:00
api Merge "Replace Content::preSaveTransform call to ContentTransformer::preSaveTransform" 2021-08-23 16:09:20 +00:00
auth Merge "Support fluent interface for StatusValue" 2021-08-11 04:23:17 +00:00
block Simplify if-then-else-return statements with explicit true/false 2021-08-17 23:19:04 +02:00
cache Add logger to BacklinkCache serializing 2021-08-20 12:58:26 -04:00
changes EnhancedChangesList: Use parent::beginRecentChangesList() 2021-07-03 20:51:33 +00:00
changetags Clean up conversions to User objects in ChangeTags 2021-07-02 09:03:22 +00:00
collation
compat
composer Update Legoktm's email address 2021-05-02 05:39:37 +00:00
config Introduce includes/Storage/PageUpdaterFactory 2021-07-19 12:15:26 +02:00
content Fix various typos in documentation 2021-08-23 09:03:44 +00:00
context Revert "Use CsrfTokenSet as CSRF token source" 2021-08-05 15:48:26 -07:00
dao build: Updating dependencies 2021-07-22 03:36:05 +00:00
db build: Updating dependencies 2021-07-22 03:36:05 +00:00
debug DeprecationHelper: Support mocking and dynamic properties 2021-08-04 12:38:02 -07:00
deferred build: Updating dependencies 2021-07-22 03:36:05 +00:00
diff Apply side lock to diff headers and empty lines, too 2021-08-12 18:08:57 +02:00
edit
editpage build: Updating dependencies 2021-07-22 03:36:05 +00:00
exception build: Updating dependencies 2021-07-22 03:36:05 +00:00
export prevent PageIdentity checks in RevisionStore from breaking xml dumps 2021-07-19 12:20:18 -07:00
externalstore Remove dead variables and functions and unneeded parenthesis 2021-08-13 21:41:59 +02:00
filebackend Support fluent interface for StatusValue 2021-08-02 15:14:11 -04:00
filerepo Remove unneeded explicit true/false inside conditions 2021-08-17 21:52:34 +02:00
gallery Emit media structure as piloted in Parsoid 2021-06-24 23:32:40 +00:00
historyblob Post Revision-removal cleanup 2021-06-24 00:32:39 +00:00
Hook build: Updating dependencies 2021-07-22 03:36:05 +00:00
HookContainer Merge "Hard deprecate UserLoadOptions hook" 2021-08-12 13:32:22 +00:00
htmlform Merge "Remove unneeded explicit true/false inside conditions" 2021-08-18 17:40:58 +00:00
http http: Add $wgLocalHTTPProxy to set a proxy for local requests 2021-08-19 16:11:21 +00:00
import Merge "WikiRevision: ensure that $comment is a string" 2021-08-14 16:36:00 +00:00
installer Localisation updates from https://translatewiki.net. 2021-08-19 08:01:18 +02:00
interwiki Use @deprecated annotation on hook interfaces, not functions 2021-05-17 23:00:40 +02:00
jobqueue Improve exception message for JobQueueGroup::assertValidJobs 2021-08-19 22:05:49 +02:00
json FormatJson: Add message for JSON_ERROR_INVALID_PROPERTY_NAME 2021-08-16 10:57:14 -04:00
language Fix various typos in documentation 2021-08-23 09:03:44 +00:00
languages Chinese Conversion Table Update 2021-1 2021-08-15 03:39:10 +00:00
libs rdbms: Followup to upsert/replace parameter validation 2021-08-24 00:34:12 +00:00
linkeddata
linker Suppress LinkCache warning about "non-proper" pages 2021-07-27 20:51:42 +10:00
logging Narrow PageUpdater dependency from Title 2021-07-26 19:45:11 -07:00
mail Fix various typos in documentation 2021-08-23 09:03:44 +00:00
media Merge "Simplify loops over array_keys" 2021-08-24 13:19:38 +00:00
Message
Navigation Use Message::page instead of Message::title 2021-06-09 13:18:22 +00:00
objectcache Revert "objectcache: make use of new modtoken field in SqlBagOStuff" 2021-08-17 15:29:32 +00:00
page Merge "Document ProperPageIdentity::canExist as returning true" 2021-08-22 10:31:41 +00:00
pager Merge "Simplify loops over array_keys" 2021-08-24 13:19:38 +00:00
ParamValidator/TypeDef build: Updating dependencies 2021-07-22 03:36:05 +00:00
parser Merge "Simplify if-then-else-return statements with explicit true/false" 2021-08-24 11:44:23 +00:00
password build: Updating dependencies 2021-07-22 03:36:05 +00:00
Permissions New RestrictionStore service 2021-08-28 16:01:06 +00:00
poolcounter Add comment to fall-through cases in switch 2021-04-15 17:31:12 +00:00
preferences Simplify else-branches after continue/break 2021-08-17 22:51:43 +02:00
profiler Use more neutral or alternative language 2021-03-20 19:47:18 +00:00
rcfeed Fix some @stable for ... annotations to use @stable to ... 2021-07-08 02:54:59 +00:00
registration Remove unneeded explicit true/false inside conditions 2021-08-17 21:52:34 +02:00
resourceloader Merge "resourceloader: Remove isFileModule() overhead from web requests" 2021-08-19 17:17:53 +00:00
Rest Revert "Use CsrfTokenSet as CSRF token source" 2021-08-05 15:48:26 -07:00
Revision DeletedContribsPager row filtering with RevisionStore::isRevisionRow 2021-08-18 15:18:24 -04:00
revisiondelete Revert "Use CsrfTokenSet as CSRF token source" 2021-08-05 15:48:26 -07:00
revisionlist build: Updating dependencies 2021-07-22 03:36:05 +00:00
search Remove unneeded explicit true/false inside conditions 2021-08-17 21:52:34 +02:00
session build: Updating dependencies 2021-07-22 03:36:05 +00:00
shell Add support for multiple shellbox URLs through a mapping configuration 2021-06-21 14:14:44 +02:00
site Various updates and fixes to PHPDoc documentation 2021-08-09 09:26:23 +02:00
skins Merge "Remove unneeded continue/return statements" 2021-08-18 09:10:19 +00:00
sparql sparql: Replace deprecated Http::userAgent() in SparqlClient 2021-08-04 13:54:13 +00:00
specialpage Merge "Simplify if-then-else-return statements with explicit true/false" 2021-08-24 11:44:23 +00:00
specials Merge "Simplify if-then-else-return statements with explicit true/false" 2021-08-24 11:44:23 +00:00
Storage Remove unneeded continue/return statements 2021-08-17 22:53:53 +02:00
templates Don't use classes error, success and warning outside parser 2021-04-27 17:11:14 +02:00
tidy Bump wikimedia/remex-html to 2.3.2 and drop 2.3.1 2021-08-08 18:07:29 -04:00
title Allow using MediaWikiTitleCodec with errors in unit tests 2021-07-27 11:27:56 +00:00
upload Remove unneeded explicit true/false inside conditions 2021-08-17 21:52:34 +02:00
user Merge "UserFactory: Simplify and type hint newAnonymous" 2021-08-18 00:16:42 +00:00
utils Use the unserialized form of image metadata internally 2021-06-08 17:04:01 +10:00
watcheditem Merge "WatchedItemStore: clean up, simplify, and misc tweaks" 2021-07-26 14:18:42 +00:00
watchlist build: Updating dependencies 2021-07-22 03:36:05 +00:00
widget Remove comments that repeat the code 2021-06-02 08:03:09 +00:00
xml Simplify else-branches after continue/break 2021-08-17 22:51:43 +02:00
.htaccess
ActorMigration.php Schema migration for revison_actor_temp table removal 2021-07-14 08:29:04 +10:00
ActorMigrationBase.php Schema migration for revison_actor_temp table removal 2021-07-14 08:29:04 +10:00
AjaxDispatcher.php
AjaxResponse.php
AutoLoader.php Merge "AutoLoader: Use ?? instead of multiple if-isset-else branches" 2021-08-12 02:05:25 +00:00
BadFileLookup.php
CategoriesRdf.php
Category.php Category: store ReadOnlyMode in constructor 2021-08-13 02:29:21 +02:00
CategoryViewer.php
CommentStore.php Fix various typos in documentation 2021-08-23 09:03:44 +00:00
CommentStoreComment.php
ConfiguredReadOnlyMode.php
ContentSecurityPolicy.php Remove comments that repeat the code 2021-06-02 08:03:09 +00:00
DefaultSettings.php http: Add $wgLocalHTTPProxy to set a proxy for local requests 2021-08-19 16:11:21 +00:00
Defines.php MW_VERSION also exists in 1.33.3 and 1.34.1 2021-08-19 06:54:29 +00:00
DeprecatedGlobal.php
DerivativeRequest.php Create FauxRequestUpload to fake uploads in tests 2021-04-06 23:10:43 +02:00
DevelopmentSettings.php Set $wgIncludejQueryMigrate to false in CI/dev 2021-07-14 20:17:42 +02:00
DummyLinker.php Post Revision-removal cleanup 2021-06-24 00:32:39 +00:00
EditPage.php Remove unneeded explicit true/false inside conditions 2021-08-17 21:52:34 +02:00
Emptiable.php
EventRelayerGroup.php
ExtensionInfo.php
FauxRequest.php Remove backward compatibility $_FILES from FauxRequest::getUpload 2021-05-16 18:27:35 +00:00
FauxRequestUpload.php Create FauxRequestUpload to fake uploads in tests 2021-04-06 23:10:43 +02:00
FauxResponse.php
FeedUtils.php FeedUtils: remove usage of $wgLang 2021-08-13 23:36:14 +02:00
FileDeleteForm.php Revert "Use CsrfTokenSet as CSRF token source" 2021-08-05 15:48:26 -07:00
ForeignResourceManager.php
ForkController.php Unbreak ForkController 2021-07-14 14:08:22 +02:00
FormOptions.php
GitInfo.php
GlobalFunctions.php Remove global function wfDiff(), deprecated since 1.25 and unused 2021-07-23 12:23:40 +00:00
HeaderCallback.php
Hooks.php Mark Hooks::runner() as @internal 2021-07-28 23:49:27 +00:00
Html.php Html::openElement() micro-optimisations 2021-08-02 18:10:59 +00:00
Linker.php Remove unneeded explicit true/false inside conditions 2021-08-17 21:52:34 +02:00
LinkFilter.php
ListToggle.php
MagicWord.php
MagicWordArray.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
MagicWordFactory.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
MediaWiki.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
MediaWikiServices.php New RestrictionStore service 2021-08-28 16:01:06 +00:00
MediaWikiVersionFetcher.php
MergeHistory.php Support fluent interface for StatusValue 2021-08-02 15:14:11 -04:00
MovePage.php Merge "Use MovePageFactory and hard deprecate constructing MovePage objects directly" 2021-08-11 20:29:44 +00:00
MWGrants.php Use array_fill_keys() instead of array_flip() if that reflects the developer's intention 2021-06-15 00:11:10 +00:00
MWNamespace.php Hard-deprecate some MWNamespace methods 2021-07-26 11:53:11 +00:00
MWTimestamp.php Split TimeCorrection parser into separate class 2021-05-07 10:43:09 -07:00
NoLocalSettings.php
OrderedStreamingForkController.php
OutputHandler.php Reapply Content-Length deferred updates patches 2021-04-08 09:25:56 +00:00
OutputPage.php Revert "Use CsrfTokenSet as CSRF token source" 2021-08-05 15:48:26 -07:00
PageProps.php PageProps: be prepared that PageIdentity is not proper title 2021-05-19 12:50:26 -07:00
PathRouter.php
PHPVersionCheck.php Restore PHP 4.0 compatibility to PHPVersionCheck 2021-06-07 08:24:11 -07:00
Pingback.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
ProtectionForm.php Revert "Use CsrfTokenSet as CSRF token source" 2021-08-05 15:48:26 -07:00
ProxyLookup.php ProxyLookup: inject hook container 2021-03-30 18:46:53 +00:00
RawMessage.php
ReadOnlyMode.php
ServiceWiring.php New RestrictionStore service 2021-08-28 16:01:06 +00:00
Setup.php Setup: Move $wgServer check back, update date.timezone explaination 2021-07-31 20:05:38 +01:00
SiteConfiguration.php Use array_fill_keys() instead of array_flip() if that reflects the developer's intention 2021-06-15 00:11:10 +00:00
SiteStats.php Replace uses of DB_MASTER with DB_PRIMARY 2021-04-29 09:24:31 -07:00
SiteStatsInit.php Use null coalecing operators everywhere consistenctly. 2021-06-03 21:42:06 -07:00
Status.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
StreamFile.php Use more neutral or alternative language 2021-03-20 19:47:18 +00:00
StubObject.php
StubUserLang.php Remove StubUserLang::findVariantLink 2021-05-15 12:51:26 -07:00
TemplateParser.php
TemplatesOnThisPageFormatter.php
Title.php New RestrictionStore service 2021-08-28 16:01:06 +00:00
TitleArray.php Remove the TitleArrayFromResult hook 2021-06-02 13:48:30 +00:00
TitleArrayFromResult.php
TitleFactory.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
TrackingCategories.php Use Message::page instead of Message::title 2021-06-09 13:18:22 +00:00
WebRequest.php WebRequest: Document getVal caveat and recommend getText or getRawVal 2021-08-23 23:43:10 +00:00
WebRequestUpload.php Create FauxRequestUpload to fake uploads in tests 2021-04-06 23:10:43 +02:00
WebResponse.php
WebStart.php
WikiMap.php
WikiReference.php