wiki.techinc.nl/includes
Daimona Eaytoy d24641a2a0 Change return format of UndeletePage::undelete()
- Make it consistently return a StatusValue, as is expected by this
  kind of methods.
- Omit the comment in the returned status, as it matches the one
that was passed as method parameter to undelete().
- Return a good status if there was nothing to undelete. Callers can
  check the status value to determine if something was deleted.

The new format will make getRevisionStatus and getFileStatus
unnecessary, and will also make it impossible to distinguish between
file-related and revision-related errors. I don't think this is really
important (only SpecialUndelete uses the respective methods).

PageArchive is responsible for maintaining backwards compatibility with
the old format.

Bug: T290021
Change-Id: I51179fa7707b5fc44d2257cc927edc0bd798a4d9
2021-09-27 15:41:45 +00:00
..
actions Move revert detection code from WikiPage to EditResultBuilder 2021-09-16 12:24:34 -07:00
api Move code from PageArchive to a new UndeletePage command 2021-09-21 16:11:29 +00:00
auth Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
block docs: Remove wrong null types 2021-08-26 21:42:03 +02:00
cache Remove MessageCache::singleton() 2021-09-15 18:13:37 +02:00
changes Title: Make use of BacklinkCacheFactory service 2021-09-09 14:04:02 +01:00
changetags ChangeTags: Add CSS classes to rows for hidden tags too 2021-09-14 22:51:09 +02:00
collation collation: Create CollationFactory service 2021-09-04 02:46:06 +02:00
compat
composer
config Introduce includes/Storage/PageUpdaterFactory 2021-07-19 12:15:26 +02:00
content Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
context Emit deprecation warnings reading from $wgUser 2021-09-15 20:17:04 -07:00
dao build: Updating dependencies 2021-07-22 03:36:05 +00:00
db Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
debug DeprecationHelper: Support mocking and dynamic properties 2021-08-04 12:38:02 -07:00
deferred Remove User from LinksUpdate 2021-09-13 09:40:24 -07:00
diff Rename diff-related classes for LTR compatibility 2021-09-17 22:58:44 +00:00
edit
editpage editpage: Replace usage of Title in TextboxBuilder::class 2021-09-20 10:24:00 +01:00
exception Merge "Revert "Introduce AbstractLocalizedException"" 2021-09-14 20:10:48 +00:00
export Update @since doc for WikiExporterFactory 2021-09-16 19:10:46 +02:00
externalstore Merge "ExternalStoreDB::getMaster: Hard deprecate now it's unused in prod" 2021-09-08 20:52:48 +00:00
filebackend Remove LockManagerGroup::singleton() and ::destroySingletons() 2021-09-17 00:25:44 +02:00
filerepo file: Fix doc of LocalRepo::locked 2021-09-20 23:26:42 +02:00
gallery build: Update mediawiki/mediawiki-phan-config to 0.11.0 2021-09-07 17:19:05 +02:00
historyblob Post Revision-removal cleanup 2021-06-24 00:32:39 +00:00
Hook Remove PHPUnit hooks 2021-08-30 00:28:32 +02:00
HookContainer Drop the ArticleUndeleteLogEntry hook 2021-09-20 13:50:19 +02:00
htmlform Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
http Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
import Merge "Same code style and formatting for exists-style SQL queries" 2021-08-24 17:44:17 +00:00
installer Merge "Installer: Add $wgLocaltimezone to LocalSettings template" 2021-09-21 15:43:14 +00:00
interwiki
jobqueue Emit deprecation warnings reading from $wgUser 2021-09-15 20:17:04 -07:00
json FormatJson: Optimize encode() for supported PHP versions 2021-08-20 08:03:11 -04:00
language Fix indent of line comment 2021-09-11 20:56:18 +02:00
languages Add sjd and sje languages to Names.php 2021-09-13 20:49:29 +00:00
libs Merge "profiler: Fixup broken logic for the new 'running' option" 2021-09-21 04:42:58 +00:00
linkeddata
linker Remove stub threshold feature 2021-09-13 09:26:38 -07:00
logging Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
mail EmailNotification: fix misplaced tab 2021-09-20 22:25:20 +00:00
media Drop $wgDjvuToXML 2021-09-10 23:40:31 +02:00
Message
Navigation Use Message::page instead of Message::title 2021-06-09 13:18:22 +00:00
objectcache Cleanup mixed space/tab line indent 2021-09-04 00:52:31 +02:00
page Change return format of UndeletePage::undelete() 2021-09-27 15:41:45 +00:00
pager TablePager: fix param documentation for formatValue() 2021-09-09 08:44:27 +02:00
ParamValidator/TypeDef UserDef: creating from id 0 should be unknown user, not context ip 2021-09-14 03:25:40 +00:00
parser Unserialize objects in ParserCache->mExtensionData as objects 2021-09-17 11:34:33 +02:00
password Remove PasswordCannotMatchUsername password policy 2021-09-06 14:55:12 +00:00
Permissions Reapply "GrantsInfo service to replace MWGrants" 2021-09-18 08:52:22 +00:00
poolcounter Add slow-parsoid log channel 2021-09-15 15:48:11 +10:00
preferences ApiParse: Support hidden skins 2021-09-20 09:29:24 +01:00
profiler profiler: Fixup broken logic for the new 'running' option 2021-09-16 03:26:23 +01:00
rcfeed Fix some @stable for ... annotations to use @stable to ... 2021-07-08 02:54:59 +00:00
registration Merge "registration: Apply manifest v2 logic to hypothetical v3" 2021-09-10 06:47:36 +00:00
resourceloader ApiParse: Support hidden skins 2021-09-20 09:29:24 +01:00
Rest Merge "Add slow-parsoid log channel" 2021-09-16 14:05:36 +00:00
Revision Remove stub threshold feature 2021-09-13 09:26:38 -07:00
revisiondelete build: Update mediawiki/mediawiki-phan-config to 0.11.0 2021-09-07 17:19:05 +02:00
revisionlist build: Updating dependencies 2021-07-22 03:36:05 +00:00
search Remove Title from signatures in CategoryViewer 2021-09-13 16:14:06 +00:00
session Cleanup mixed space/tab line indent 2021-09-04 00:52:31 +02:00
shell shell: Fix $wgShellboxUrls by passing service name when creating BoxedCommand 2021-09-01 11:43:22 -07:00
site Various updates and fixes to PHPDoc documentation 2021-08-09 09:26:23 +02:00
skins Merge "skins: Correctly index the copyright icon, caused failure in MF" 2021-09-21 01:46:56 +00:00
sparql sparql: Replace deprecated Http::userAgent() in SparqlClient 2021-08-04 13:54:13 +00:00
specialpage Merge "WikiExporter: inject services" 2021-09-16 17:04:04 +00:00
specials Move code from PageArchive to a new UndeletePage command 2021-09-21 16:11:29 +00:00
Storage MovePage - use PageUpdater to create redirect page 2021-09-17 15:49:50 +00:00
templates
tidy Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
title Revert "Introduce AbstractLocalizedException" 2021-09-14 19:01:21 +00:00
upload Merge "Revert "Introduce AbstractLocalizedException"" 2021-09-14 20:10:48 +00:00
user Remove stub threshold feature 2021-09-13 09:26:38 -07:00
utils Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
watcheditem Merge "Using @return never documentation on always-throw-function" 2021-09-08 03:12:06 +00:00
watchlist build: Updating dependencies 2021-07-22 03:36:05 +00:00
widget Remove unreachable code after exception/die/exit 2021-09-03 23:14:28 +00:00
xml Simplify else-branches after continue/break 2021-08-17 22:51:43 +02:00
.htaccess
ActorMigration.php Schema migration for revison_actor_temp table removal 2021-07-14 08:29:04 +10:00
ActorMigrationBase.php Schema migration for revison_actor_temp table removal 2021-07-14 08:29:04 +10:00
AjaxDispatcher.php ILoadBalancer/ILBFactory: Rename commitMasterChanges() to commitPrimaryChanges() 2021-09-02 11:27:10 -07:00
AjaxResponse.php
AutoLoader.php Merge "AutoLoader: Use ?? instead of multiple if-isset-else branches" 2021-08-12 02:05:25 +00:00
BadFileLookup.php
CategoriesRdf.php
Category.php Remove Title from signatures in CategoryViewer 2021-09-13 16:14:06 +00:00
CategoryViewer.php Remove Title from signatures in CategoryViewer 2021-09-13 16:14:06 +00:00
CommentStore.php Fix various typos in documentation 2021-08-23 09:03:44 +00:00
CommentStoreComment.php
ConfiguredReadOnlyMode.php
ContentSecurityPolicy.php Remove comments that repeat the code 2021-06-02 08:03:09 +00:00
DefaultSettings.php Remove stub threshold feature 2021-09-13 09:26:38 -07:00
Defines.php Prepare for REL1_37 cut, labelling master as 1.38-alpha 2021-09-13 19:19:42 -07:00
DeprecatedGlobal.php StubObject: add magic __get() and __set() 2021-09-04 05:37:25 +00:00
DerivativeRequest.php build: Update mediawiki/mediawiki-phan-config to 0.11.0 2021-09-07 17:19:05 +02:00
DevelopmentSettings.php Set $wgIncludejQueryMigrate to false as default 2021-08-29 02:09:35 +02:00
DummyLinker.php Post Revision-removal cleanup 2021-06-24 00:32:39 +00:00
EditPage.php Merge "Avoid using ContentHandler::getContentText()" 2021-09-20 19:14:10 +00:00
Emptiable.php
EventRelayerGroup.php
ExtensionInfo.php
FauxRequest.php
FauxRequestUpload.php
FauxResponse.php
FeedUtils.php Merge "Make use of Html class utility methods in a few places" 2021-08-31 15:39:39 +00:00
FileDeleteForm.php ILoadBalancer/ILBFactory: Rename rollbackMasterChanges to rollbackPrimaryChanges 2021-09-02 12:50:52 -07:00
ForeignResourceManager.php
ForkController.php Unbreak ForkController 2021-07-14 14:08:22 +02:00
FormOptions.php
GitInfo.php
GlobalFunctions.php Merge "Soft deprecate wfReadOnly() and wfReadOnlyReason()" 2021-09-20 06:04:40 +00:00
HeaderCallback.php
Hooks.php Mark Hooks::runner() as @internal 2021-07-28 23:49:27 +00:00
Html.php Html::openElement() micro-optimisations 2021-08-02 18:10:59 +00:00
Linker.php Remove stub threshold feature 2021-09-13 09:26:38 -07:00
LinkFilter.php
ListToggle.php
MagicWord.php
MagicWordArray.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
MagicWordFactory.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
MediaWiki.php MWExceptionHandler: Rename rollbackMasterChangesAndLog to rollbackPrimaryChangesAndLog 2021-09-03 17:36:34 -07:00
MediaWikiServices.php Reapply "GrantsInfo service to replace MWGrants" 2021-09-18 08:52:22 +00:00
MediaWikiVersionFetcher.php
MergeHistory.php Support fluent interface for StatusValue 2021-08-02 15:14:11 -04:00
MovePage.php MovePage - use PageUpdater to create redirect page 2021-09-17 15:49:50 +00:00
MWGrants.php Reapply "GrantsInfo service to replace MWGrants" 2021-09-18 08:52:22 +00:00
MWNamespace.php Hard-deprecate some MWNamespace methods 2021-07-26 11:53:11 +00:00
MWTimestamp.php
NoLocalSettings.php
OrderedStreamingForkController.php
OutputHandler.php
OutputPage.php Avoid using ContentHandler::getContentText() 2021-09-20 15:32:44 +02:00
PageProps.php
PathRouter.php
PHPVersionCheck.php Prepare for REL1_37 cut, labelling master as 1.38-alpha 2021-09-13 19:19:42 -07:00
Pingback.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
ProtectionForm.php Revert "Use CsrfTokenSet as CSRF token source" 2021-08-05 15:48:26 -07:00
ProxyLookup.php
RawMessage.php
ReadOnlyMode.php
ServiceWiring.php Reapply "GrantsInfo service to replace MWGrants" 2021-09-18 08:52:22 +00:00
Setup.php Emit deprecation warnings reading from $wgUser 2021-09-15 20:17:04 -07:00
SiteConfiguration.php Use array_fill_keys() instead of array_flip() if that reflects the developer's intention 2021-06-15 00:11:10 +00:00
SiteStats.php ILoadBalancer/ILBFactory: Rename hasOrMadeRecentMasterChanges to hasOrMadeRecentPrimaryChanges 2021-09-02 16:34:44 -07:00
SiteStatsInit.php Same code style and formatting for exists-style SQL queries 2021-08-12 11:37:58 +02:00
Status.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
StreamFile.php Rename four config variables to avoid 'blacklist' term 2021-09-08 23:32:29 +01:00
StubGlobalUser.php Emit deprecation warnings reading from $wgUser 2021-09-15 20:17:04 -07:00
StubObject.php StubObject: add magic __get() and __set() 2021-09-04 05:37:25 +00:00
StubUserLang.php
TemplateParser.php TemplateParser: Remove support for deprecated cache-disabling parameter 2021-09-17 19:48:54 +00:00
TemplatesOnThisPageFormatter.php
Title.php Deprecate WikiPage methods replaced by DeletePage 2021-09-16 20:17:45 +00:00
TitleArray.php docs: Declare UserArray/TitleArray as Iterator<User>/Iterator<Title> 2021-08-30 22:37:54 +02:00
TitleArrayFromResult.php docs: Declare UserArray/TitleArray as Iterator<User>/Iterator<Title> 2021-08-30 22:37:54 +02:00
TitleFactory.php build: Updating dependencies 2021-07-22 03:36:05 +00:00
TrackingCategories.php Use Message::page instead of Message::title 2021-06-09 13:18:22 +00:00
WebRequest.php WebRequest: Document getVal caveat and recommend getText or getRawVal 2021-08-23 23:43:10 +00:00
WebRequestUpload.php
WebResponse.php
WebStart.php Using @return never documentation on always-throw-function 2021-09-07 17:29:03 +02:00
WikiMap.php
WikiReference.php