5e30a927bc
Just methods where adding "static" to the declaration was enough, I didn't do anything with providers that used $this. Initially by search and replace. There were many mistakes which I found mostly by running the PHPStorm inspection which searches for $this usage in a static method. Later I used the PHPStorm "make static" action which avoids the more obvious mistakes. Bug: T332865 Change-Id: I47ed6692945607dfa5c139d42edbd934fa4f3a36
85 lines
1.8 KiB
PHP
85 lines
1.8 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @covers HTMLUserTextFieldTest
|
|
*/
|
|
class HTMLUserTextFieldTest extends MediaWikiIntegrationTestCase {
|
|
|
|
/**
|
|
* @dataProvider provideInputs
|
|
*/
|
|
public function testInputs( array $config, string $value, $expected ) {
|
|
$htmlForm = $this->createMock( HTMLForm::class );
|
|
$htmlForm->method( 'msg' )->willReturnCallback( 'wfMessage' );
|
|
|
|
$field = new HTMLUserTextField( $config + [ 'fieldname' => 'foo', 'parent' => $htmlForm ] );
|
|
$result = $field->validate( $value, [ 'foo' => $value ] );
|
|
if ( $result instanceof Message ) {
|
|
$this->assertSame( $expected, $result->getKey() );
|
|
} else {
|
|
$this->assertSame( $expected, $result );
|
|
}
|
|
}
|
|
|
|
public static function provideInputs() {
|
|
return [
|
|
'valid username' => [
|
|
[],
|
|
'SomeUser',
|
|
true
|
|
],
|
|
'invalid username' => [
|
|
[],
|
|
'<SomeUser>',
|
|
'htmlform-user-not-valid'
|
|
],
|
|
'valid IP' => [
|
|
[ 'ipallowed' => true ],
|
|
'1.2.3.4',
|
|
true
|
|
],
|
|
'valid IP, but not allowed' => [
|
|
[ 'ipallowed' => false ],
|
|
'1.2.3.4',
|
|
'htmlform-user-not-valid'
|
|
],
|
|
'invalid IP' => [
|
|
[ 'ipallowed' => true ],
|
|
'1.2.3.456',
|
|
'htmlform-user-not-valid'
|
|
],
|
|
'valid IP range' => [
|
|
[ 'iprange' => true ],
|
|
'1.2.3.4/30',
|
|
true
|
|
],
|
|
'valid IP range, but not allowed' => [
|
|
[ 'iprange' => false ],
|
|
'1.2.3.4/30',
|
|
'htmlform-user-not-valid'
|
|
],
|
|
'invalid IP range (bad syntax)' => [
|
|
[ 'iprange' => true ],
|
|
'1.2.3.4/x',
|
|
'htmlform-user-not-valid'
|
|
],
|
|
'invalid IP range (exceeds limits)' => [
|
|
[
|
|
'iprange' => true,
|
|
'iprangelimits' => [
|
|
'IPv4' => 11,
|
|
'IPv6' => 11,
|
|
],
|
|
],
|
|
'1.2.3.4/10',
|
|
'ip_range_exceeded'
|
|
],
|
|
'valid username, but does not exist' => [
|
|
[ 'exists' => true ],
|
|
'SomeUser',
|
|
'htmlform-user-not-exists'
|
|
],
|
|
];
|
|
}
|
|
|
|
}
|