Add - ContentModelChangeConstraint - EditRightConstraint - ImageRedirectConstraint - ReadOnlyConstraint - UserBlockConstraint - UserRateLimitConstraint Additionally: - Split EditPageTest into a separate file for all of the constraints being tested - Add a helper EditConstraintTestTrait - Add debug logging for EditConstraintRunner for the result of each constraint - Changed the order of some of the checks, which may result in a different failure code if multiple checks were going to fail, but shouldn't change the overall result of whether an edit fails or not. Bug: T157658 Change-Id: Ib8f8b62b9928544e5559c96d82bf850dd8cf9b05
60 lines
1.8 KiB
PHP
60 lines
1.8 KiB
PHP
<?php
|
|
/**
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
|
|
* http://www.gnu.org/copyleft/gpl.html
|
|
*
|
|
* @file
|
|
*/
|
|
|
|
use MediaWiki\EditPage\Constraint\IEditConstraint;
|
|
|
|
/**
|
|
* Helper for the various constraint test classes
|
|
*
|
|
* @author DannyS712
|
|
*/
|
|
trait EditConstraintTestTrait {
|
|
|
|
/**
|
|
* Assert that the constraint passes and that the status is good
|
|
* @param IEditConstraint $constraint
|
|
*/
|
|
public function assertConstraintPassed( IEditConstraint $constraint ) {
|
|
$this->assertSame(
|
|
IEditConstraint::CONSTRAINT_PASSED,
|
|
$constraint->checkConstraint()
|
|
);
|
|
|
|
$status = $constraint->getLegacyStatus();
|
|
$this->assertTrue( $status->isGood() );
|
|
}
|
|
|
|
/**
|
|
* Assert that the constraint fails with the specified status code
|
|
* @param IEditConstraint $constraint
|
|
* @param int $statusCode
|
|
*/
|
|
public function assertConstraintFailed( IEditConstraint $constraint, int $statusCode ) {
|
|
$this->assertSame(
|
|
IEditConstraint::CONSTRAINT_FAILED,
|
|
$constraint->checkConstraint()
|
|
);
|
|
|
|
$status = $constraint->getLegacyStatus();
|
|
$this->assertFalse( $status->isGood() );
|
|
$this->assertSame( $statusCode, $status->getValue() );
|
|
}
|
|
|
|
}
|