wiki.techinc.nl/includes/ResourceLoader/dependencystore/SqlModuleDependencyStore.php
Timo Tijhof 1016d3b9ba ResourceLoader: Fix confusing DependencyStoreException trace logs
After the roll-out of $wgResourceLoaderUseObjectCacheForDeps on
WMF wikis, there was an unrelated database spike that caused some
error messages:

> DependencyStoreException:
> Cannot access the database: Too many connections (db1132)

I found this confusing, because servers shouldn't be using old
DepStore class any more (ref T311788?). And because the new store
is x2.mainstash, whereas the reported hostname is an s1.enwiki host.

I wasted some time not trusting the code path as there was no Rdbms
trace available to confirm for sure that this isn't an unrelated query
that happens to be caught during the DepStore interaction (e.g. some
generic MW code running from a hook, or Rdbms internal query from
LoadMonitor etc).

Improve telemetry by preserving the original trace.

I considered passing `$e` as third parameter to
DependencyStoreException, but since the new implementation doesn't
actually use this class, it's effectively going to remain unused in the
future and would not reliably indicate anything in particular to callers
unaware of which implementation is in use. There's also some benefit
to being able to aggregate and filter out specific db issues, which
is made harder by the same issue being reported multiple different
ways through wrapped errors.

The old implementation will remain for one release as default, and
probably one release after that as option for any third parties that
encounter an issue during upgrade so as to not block their upgrade
while we find/address the issue in question.

Bug: T113916
Change-Id: Iaa3907fc3aa0622daa9648eabfdd7efabdd4f2a9
2022-08-01 20:46:26 -07:00

213 lines
5.8 KiB
PHP

<?php
/**
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
*/
namespace Wikimedia\DependencyStore;
use InvalidArgumentException;
use Wikimedia\Rdbms\DBConnRef;
use Wikimedia\Rdbms\IDatabase;
use Wikimedia\Rdbms\ILoadBalancer;
/**
* Track per-module file dependencies in the core module_deps table
*
* Wiki farms that are too big for maintenance/update.php, can clean up
* unneeded data for modules that no longer exist after a MW upgrade,
* by running maintenance/cleanupRemovedModules.php.
*
* To force a rebuild and incurr a small penalty in browser cache churn,
* run maintenance/purgeModuleDeps.php instead.
*
* @internal For use by ResourceLoader\Module only
* @since 1.35
*/
class SqlModuleDependencyStore extends DependencyStore {
/** @var ILoadBalancer */
private $lb;
/**
* @param ILoadBalancer $lb Storage backend
*/
public function __construct( ILoadBalancer $lb ) {
$this->lb = $lb;
}
public function retrieveMulti( $type, array $entities ) {
$dbr = $this->getReplicaDb();
$depsBlobByEntity = $this->fetchDependencyBlobs( $entities, $dbr );
$storedPathsByEntity = [];
foreach ( $depsBlobByEntity as $entity => $depsBlob ) {
$storedPathsByEntity[$entity] = json_decode( $depsBlob, true );
}
$results = [];
foreach ( $entities as $entity ) {
$paths = $storedPathsByEntity[$entity] ?? [];
$results[$entity] = $this->newEntityDependencies( $paths, null );
}
return $results;
}
public function storeMulti( $type, array $dataByEntity, $ttl ) {
// Avoid opening a primary DB connection when it's not needed.
// ResourceLoader::saveModuleDependenciesInternal calls this method unconditionally
// with empty values most of the time.
if ( !$dataByEntity ) {
return;
}
$dbw = $this->getPrimaryDB();
$depsBlobByEntity = $this->fetchDependencyBlobs( array_keys( $dataByEntity ), $dbw );
$rows = [];
foreach ( $dataByEntity as $entity => $data ) {
list( $module, $variant ) = $this->getEntityNameComponents( $entity );
if ( !is_array( $data[self::KEY_PATHS] ) ) {
throw new InvalidArgumentException( "Invalid entry for '$entity'" );
}
// Normalize the list by removing duplicates and sortings
$paths = array_values( array_unique( $data[self::KEY_PATHS] ) );
sort( $paths, SORT_STRING );
$blob = json_encode( $paths, JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE );
$existingBlob = $depsBlobByEntity[$entity] ?? null;
if ( $blob !== $existingBlob ) {
$rows[] = [
'md_module' => $module,
'md_skin' => $variant,
'md_deps' => $blob
];
}
}
// @TODO: use a single query with VALUES()/aliases support in DB wrapper
// See https://dev.mysql.com/doc/refman/8.0/en/insert-on-duplicate.html
foreach ( $rows as $row ) {
$dbw->upsert(
'module_deps',
$row,
[ [ 'md_module', 'md_skin' ] ],
[
'md_deps' => $row['md_deps'],
],
__METHOD__
);
}
}
public function remove( $type, $entities ) {
// Avoid opening a primary DB connection when it's not needed.
// ResourceLoader::saveModuleDependenciesInternal calls this method unconditionally
// with empty values most of the time.
if ( !$entities ) {
return;
}
$dbw = $this->getPrimaryDB();
$disjunctionConds = [];
foreach ( (array)$entities as $entity ) {
list( $module, $variant ) = $this->getEntityNameComponents( $entity );
$disjunctionConds[] = $dbw->makeList(
[ 'md_skin' => $variant, 'md_module' => $module ],
$dbw::LIST_AND
);
}
if ( $disjunctionConds ) {
$dbw->delete(
'module_deps',
$dbw->makeList( $disjunctionConds, $dbw::LIST_OR ),
__METHOD__
);
}
}
/**
* @param string[] $entities
* @param IDatabase $db
* @return string[]
*/
private function fetchDependencyBlobs( array $entities, IDatabase $db ) {
$modulesByVariant = [];
foreach ( $entities as $entity ) {
list( $module, $variant ) = $this->getEntityNameComponents( $entity );
$modulesByVariant[$variant][] = $module;
}
$disjunctionConds = [];
foreach ( $modulesByVariant as $variant => $modules ) {
$disjunctionConds[] = $db->makeList(
[ 'md_skin' => $variant, 'md_module' => $modules ],
$db::LIST_AND
);
}
$depsBlobByEntity = [];
if ( $disjunctionConds ) {
$res = $db->select(
'module_deps',
[ 'md_module', 'md_skin', 'md_deps' ],
$db->makeList( $disjunctionConds, $db::LIST_OR ),
__METHOD__
);
foreach ( $res as $row ) {
$entity = "{$row->md_module}|{$row->md_skin}";
$depsBlobByEntity[$entity] = $row->md_deps;
}
}
return $depsBlobByEntity;
}
/**
* @return DBConnRef
*/
private function getReplicaDb() {
return $this->lb
->getConnectionRef( DB_REPLICA, [], false, ( $this->lb )::CONN_TRX_AUTOCOMMIT );
}
/**
* @return DBConnRef
*/
private function getPrimaryDb() {
return $this->lb
->getConnectionRef( DB_PRIMARY, [], false, ( $this->lb )::CONN_TRX_AUTOCOMMIT );
}
/**
* @param string $entity
* @return string[]
*/
private function getEntityNameComponents( $entity ) {
$parts = explode( '|', $entity, 2 );
if ( count( $parts ) !== 2 ) {
throw new InvalidArgumentException( "Invalid module entity '$entity'" );
}
return $parts;
}
}