2982625e75
Reasoning: * Not all code needs an actual User object. And even if, most code doesn't need it to be validated. That's expensive. Let the users decide. * setUserObj() is almost never called anyway. And the few places that call it go the extra mile and create a User object just to please this setter. We can avoid or at least postpone this. * All callers already fall back to getUser() when there is no getUserObj(). * For a while we try to replace the User class with much smaller interfaces, whenever possible. This is a chance to remove of one more. * A "user IP" is a concept that doesn't even exist in this code. The setter writes to the same property as setUsername(). This makes it very easy to use these methods wrong, and this indeed already happened in some places. Change-Id: I6687305a5be68e8a068f11482625a0a6bd9626f2
69 lines
1.2 KiB
PHP
69 lines
1.2 KiB
PHP
<?php
|
|
|
|
/**
|
|
* @since 1.31
|
|
*/
|
|
interface ImportableUploadRevision {
|
|
|
|
/**
|
|
* @since 1.31
|
|
* @return string Archive name of a revision if archived.
|
|
*/
|
|
public function getArchiveName();
|
|
|
|
/**
|
|
* @since 1.31
|
|
* @return Title
|
|
*/
|
|
public function getTitle();
|
|
|
|
/**
|
|
* @since 1.31
|
|
* @return string
|
|
*/
|
|
public function getTimestamp();
|
|
|
|
/**
|
|
* @since 1.31
|
|
* @return string|null HTTP source of revision to be used for downloading.
|
|
*/
|
|
public function getSrc();
|
|
|
|
/**
|
|
* @since 1.31
|
|
* @return string Local file source of the revision.
|
|
*/
|
|
public function getFileSrc();
|
|
|
|
/**
|
|
* @since 1.31
|
|
* @return bool Is the return of getFileSrc only temporary?
|
|
*/
|
|
public function isTempSrc();
|
|
|
|
/**
|
|
* @since 1.31
|
|
* @return string|bool sha1 of the revision, false if not set or errors occur.
|
|
*/
|
|
public function getSha1();
|
|
|
|
/**
|
|
* @deprecated since 1.39, use {@see getUser} instead; this is almost always null anyway
|
|
* @since 1.31
|
|
* @return User|null Typically null, use {@see getUser} instead
|
|
*/
|
|
public function getUserObj();
|
|
|
|
/**
|
|
* @since 1.31
|
|
* @return string The username of the user that created this revision
|
|
*/
|
|
public function getUser();
|
|
|
|
/**
|
|
* @since 1.31
|
|
* @return string
|
|
*/
|
|
public function getComment();
|
|
|
|
}
|