All these methods have been written to return true, but that value was never used for anything other than realizing that the method succeeded. The ParserOutput object we are interested in was stuck in a property. Why not return the ParserOutput object? I wrapped it in a Status object to be able to pass warning messages along with the actual result. There was even more specialized code to do that via dedicated setters and getters. All this can be removed now. Bug: T304813 Change-Id: I6fd3745835dfcaec94695469498a2662f8317c35 |
||
|---|---|---|
| .. | ||
| PoolWorkArticleViewCurrentTest.php | ||
| PoolWorkArticleViewOldTest.php | ||
| PoolWorkArticleViewTest.php | ||