b0795a2550
These appear to be unused. Moreover, their behavior doesn't match their documentation. getDefault() claims to return NullLockManager if no lock manager could be found, but really returns it if there's no lock manager named 'default'. getAny() claims to throw if no lock manager can be found, but actually throws if no lock manager is named 'default' or 'fsLockManager'. The behavior can be easily replicated by just using get() yourself and catching any exception. Bug: T234227 Change-Id: Iad083847f45d6e017a3f7dbfece1f9c155c5efd6
92 lines
3.3 KiB
PHP
92 lines
3.3 KiB
PHP
<?php
|
|
|
|
use Wikimedia\Rdbms\LBFactory;
|
|
use Wikimedia\TestingAccessWrapper;
|
|
|
|
/**
|
|
* Since this is a unit test, we don't test the singleton() or destroySingletons() methods. We also
|
|
* can't test get() with a valid argument, because that winds up calling static methods of
|
|
* ObjectCache and LoggerFactory that aren't yet compatible with proper unit tests. Those will be
|
|
* tested in the integration test for now.
|
|
*
|
|
* @covers LockManagerGroup
|
|
*/
|
|
class LockManagerGroupTest extends MediaWikiUnitTestCase {
|
|
private function getMockLBFactory() {
|
|
$mock = $this->createMock( LBFactory::class );
|
|
$mock->expects( $this->never() )->method( $this->anythingBut( '__destruct' ) );
|
|
return $mock;
|
|
}
|
|
|
|
public function testConstructorNoConfigs() {
|
|
new LockManagerGroup( 'domain', [], $this->getMockLBFactory() );
|
|
$this->assertTrue( true, 'No exception thrown' );
|
|
}
|
|
|
|
public function testConstructorConfigWithNoName() {
|
|
$this->expectException( Exception::class );
|
|
$this->expectExceptionMessage( 'Cannot register a lock manager with no name.' );
|
|
|
|
new LockManagerGroup( 'domain',
|
|
[ [ 'name' => 'a', 'class' => 'b' ], [ 'class' => 'c' ] ], $this->getMockLBFactory() );
|
|
}
|
|
|
|
public function testConstructorConfigWithNoClass() {
|
|
$this->expectException( Exception::class );
|
|
$this->expectExceptionMessage( 'Cannot register lock manager `c` with no class.' );
|
|
|
|
new LockManagerGroup( 'domain',
|
|
[ [ 'name' => 'a', 'class' => 'b' ], [ 'name' => 'c' ] ], $this->getMockLBFactory() );
|
|
}
|
|
|
|
public function testGetUndefined() {
|
|
$this->expectException( Exception::class );
|
|
$this->expectExceptionMessage( 'No lock manager defined with the name `c`.' );
|
|
|
|
$lmg = new LockManagerGroup( 'domain', [ [ 'name' => 'a', 'class' => 'b' ] ],
|
|
$this->getMockLBFactory() );
|
|
$lmg->get( 'c' );
|
|
}
|
|
|
|
public function testConfigUndefined() {
|
|
$this->expectException( Exception::class );
|
|
$this->expectExceptionMessage( 'No lock manager defined with the name `c`.' );
|
|
|
|
$lmg = new LockManagerGroup( 'domain', [ [ 'name' => 'a', 'class' => 'b' ] ],
|
|
$this->getMockLBFactory() );
|
|
$lmg->config( 'c' );
|
|
}
|
|
|
|
public function testConfig() {
|
|
$lmg = new LockManagerGroup( 'domain', [ [ 'name' => 'a', 'class' => 'b', 'foo' => 'c' ] ],
|
|
$this->getMockLBFactory() );
|
|
$this->assertSame(
|
|
[ 'class' => 'b', 'name' => 'a', 'foo' => 'c', 'domain' => 'domain' ],
|
|
$lmg->config( 'a' )
|
|
);
|
|
}
|
|
|
|
public function testGetDefaultNull() {
|
|
$this->hideDeprecated( 'LockManagerGroup::getDefault' );
|
|
|
|
$lmg = new LockManagerGroup( 'domain', [], $this->getMockLBFactory() );
|
|
$expected = new NullLockManager( [] );
|
|
$actual = $lmg->getDefault();
|
|
// Have to get rid of the $sessions for equality check to work
|
|
TestingAccessWrapper::newFromObject( $actual )->session = null;
|
|
TestingAccessWrapper::newFromObject( $expected )->session = null;
|
|
$this->assertEquals( $expected, $actual );
|
|
}
|
|
|
|
public function testGetAnyException() {
|
|
$this->hideDeprecated( 'LockManagerGroup::getAny' );
|
|
|
|
// XXX Isn't the name 'getAny' misleading if we don't get whatever's available?
|
|
$this->expectException( Exception::class );
|
|
$this->expectExceptionMessage( 'No lock manager defined with the name `fsLockManager`.' );
|
|
|
|
$lmg = new LockManagerGroup( 'domain', [ [ 'name' => 'a', 'class' => 'b' ] ],
|
|
$this->getMockLBFactory() );
|
|
$lmg->getAny();
|
|
}
|
|
}
|