Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/includes
History
Timo Tijhof dba33a0508 resourceloader: Derive from existing Context object in ClientHtml 
It was previously creating a fresh context object, and then
manually imported some query parameters, and then *also* created
a derivative context object (so that it can copy over the
"getContentOverrideCallback" value and to allow the consumer
to also use setVersion/setModules).

The reason for this indirection was that I wanted to re-use the
query string parsing logic of ResourceLoaderContext::__construct,
instead of interpreting it here. However that extra indirection
is rather fragile as it could easily forget some other things to
inherit manually.

And, per T249189, it means there is no process cache shared between
the two. This is exactly what DerivativeResourceLoaderContext
is for, and if there is a missing feature in it, we should add it,
instead of working around it (note to self...). For now, though,
it can actually be used as-is.

Changes:
* Use DerivativeResourceLoaderContext directly.
* Set the 'only' and 'user' values directly using the setter
  methods after creating the derivative object.
* Also set 'raw' correctly. This was previously handled by
  $extraQuery being passed to ResourceLoaderContext::__construct,
  but now needs to be done manually.

Bug: T249189
Change-Id: I4173ec75bef4fe9fee39663b1348c077414d3627
2020-04-14 03:36:56 +01:00
..
actions Merge "Hard deprecate Action::factory with null argument $action" 2020-04-11 04:07:35 +00:00
api Remove codepaths which ran parser in 'untidy' mode 2020-04-13 21:34:04 +00:00
auth Enhance passwored reset message 2020-03-13 16:18:48 -07:00
block block: avoid IN() DB query clause for ipb_address with redundant entries 2020-03-26 20:07:42 +00:00
cache Hard deprecate GenderCache::singleton 2020-04-08 18:23:36 +00:00
changes Use RevisionRecord in ChangesList::revDateLink 2020-04-04 00:49:28 +00:00
changetags Hard deprecate Revision::getQueryInfo and ::getArchiveQueryInfo 2020-03-26 23:53:19 +00:00
clientpool Merge "Use namespaced IPUtils class" 2020-01-01 23:56:22 +00:00
collation collation: Add 64-67 ICU->Unicode mappings 2020-03-21 01:10:17 +00:00
compat Coding style: Auto-fix MediaWiki.Commenting.DocComment.* 2020-01-10 12:28:12 -08:00
composer Provide command to adjust phpunit.xml for code coverage 2019-09-09 14:32:02 +02:00
config Use namespaced IPUtils class 2020-01-01 02:36:49 -08:00
content Merge "ContentModelChange: Remove use of Revision objects" 2020-04-13 18:16:27 +00:00
context Remove usages of deprecated Language methods 2020-02-16 00:45:48 +00:00
dao Make DBAccessBase use DBConnRef, rename $wiki, and hide getLoadBalancer() 2019-09-08 03:34:18 +00:00
db rdbms: Fix debug toolbar query tab when $wgDebugLogFile is not set 2020-03-24 15:31:00 +00:00
debug phpunit: Add setNullLogger() and make tests default to LegacySpi 2020-04-07 22:00:13 +00:00
deferred Merge "RefreshSecondaryDataUpdate: Commit before running sub-updates" 2020-04-11 09:47:31 +00:00
diff Replace remaining uses and hard deprecate Revision::newFromArchiveRow 2020-04-01 20:18:33 +00:00
edit Coding style: Auto-fix MediaWiki.Classes.UnsortedUseStatements.UnsortedUse 2020-01-10 09:32:25 -08:00
editpage TextConflictHelper: deprecate old constructor signature 2020-02-12 14:02:38 +11:00
exception exception: No longer try to send error page post-send on api.php 2020-03-26 17:53:27 +00:00
export Make dump tests based on fixture files. 2020-04-06 15:21:00 -07:00
externalstore Upgrade phan to 0.9.1 2020-01-25 10:53:26 +00:00
filebackend Coding style: Auto-fix MediaWiki.Classes.UnsortedUseStatements.UnsortedUse 2020-01-10 09:32:25 -08:00
filerepo Hard deprecate File::delete methods 2020-03-21 03:13:50 +00:00
gallery Bundle services at top of TraditionalImageGallery::toHtml 2020-03-14 20:29:37 +00:00
historyblob Set visibility on php magic functions __destruct/sleep/wakeup/get/call 2019-12-05 18:52:55 +01:00
htmlform Fix HTMLUsersMultiselectField validation when exists is true 2020-03-20 13:15:53 -04:00
http Support cookies in GuzzleHttpRequest 2020-03-18 21:48:26 +03:00
import Use MediaWikiServices::getRepoGroup 2020-03-14 13:16:12 +01:00
installer Localisation updates from https://translatewiki.net. 2020-04-13 08:54:44 +02:00
interwiki Remove deprecated methods in the Interwiki class 2020-03-09 20:36:50 +00:00
jobqueue Fix typo in JobQueueGroup 2020-04-09 07:05:36 +00:00
json FormatJson: Improve parse() error code handling and tests 2020-01-01 02:34:44 -08:00
language Use MediaWikiServices::getMessageCache 2020-03-14 14:25:03 +01:00
libs Localisation updates from https://translatewiki.net. 2020-04-13 08:54:44 +02:00
linkeddata Introduce ContentHandlerFactory 2020-02-07 00:53:51 +03:00
linker Fix @todo asking to document LogPage::getTitleLink() 2020-01-29 13:13:56 +01:00
logging Reduce the length of 6 long lines of code 2020-03-13 09:01:14 +08:00
mail Introduce Emailer as service 2020-03-17 21:41:34 +02:00
media Remove usages of deprecated Language methods 2020-02-16 00:45:48 +00:00
Message Coding style: Auto-fix MediaWiki.Classes.UnsortedUseStatements.UnsortedUse 2020-01-10 09:32:25 -08:00
Navigation
objectcache Cleanup unique keys parameter to IDatabase::replace() calls 2020-03-24 22:30:48 +00:00
page Merge "Replace PageArchive::getPreviousRevision with getPreviousRevisionRecord" 2020-04-11 03:53:57 +00:00
pager IndexPager: Limit offset params to the max of the indices available 2020-02-20 13:42:16 -08:00
ParamValidator/TypeDef UserDef: Don't return incomplete UserIdentityValues 2020-02-19 15:28:40 -05:00
parser Remove codepaths which ran parser in 'untidy' mode 2020-04-13 21:34:04 +00:00
password Pbkdf2Password: Fix error handling on PHP 8 2020-04-07 18:46:31 +02:00
Permissions Fix the namespace of SpecialPageFactory 2020-02-21 13:46:19 +11:00
poolcounter Set method visibility for various constructors 2019-12-03 20:17:30 +01:00
preferences Setup: Move wgSkipSkins appendix to Skin::getAllowedSkins 2020-03-13 23:45:12 +00:00
profiler Merge "Remove $wgProfileLimit setting" 2020-03-19 23:17:37 +00:00
rcfeed Remove hack comment from IRCLineURL 2020-03-28 00:56:50 +00:00
registration registration: Convert internal static class vars to constants 2020-04-10 18:26:30 +00:00
resourceloader resourceloader: Derive from existing Context object in ClientHtml 2020-04-14 03:36:56 +01:00
Rest Localisation updates from https://translatewiki.net. 2020-04-13 08:54:44 +02:00
Revision Merge "Define RevisionRecord::isCurrent" 2020-04-07 13:48:09 +00:00
revisiondelete Replace remaining uses and hard deprecate Revision::newFromArchiveRow 2020-04-01 20:18:33 +00:00
revisionlist Hard deprecate Revision::getQueryInfo and ::getArchiveQueryInfo 2020-03-26 23:53:19 +00:00
search RevisionSearchResultTrait: Remove use of Revision objects 2020-04-13 01:12:21 +00:00
session REST: page/ endpoints: don't use tokens with OAuth 2020-03-27 12:20:22 +01:00
shell Fix mismatching type hints in PHPDoc tags 2020-03-24 09:59:02 +01:00
site Add flag to force local page name normalization in development env 2020-02-18 17:00:20 +01:00
skins Merge "Remove direct access to Action::page and Article::page properties" 2020-03-27 04:36:51 +00:00
sparql Improve param docs 2019-11-28 19:08:59 +01:00
specialpage Use MediaWikiServices::getAuthManager in special page related classes 2020-04-12 00:17:22 +00:00
specials Remove codepaths which ran parser in 'untidy' mode 2020-04-13 21:34:04 +00:00
Storage Merge "Fix typo in documentation comment" 2020-04-04 08:29:06 +00:00
templates Update all use of $wgVersion to MW_VERSION 2020-02-25 02:16:12 +00:00
tidy Coding style: Auto-fix MediaWiki.Classes.UnsortedUseStatements.UnsortedUse 2020-01-10 09:32:25 -08:00
title Coding style: Auto-fix MediaWiki.Usage.IsNull.IsNull 2020-01-10 14:17:13 -08:00
upload Merge "Use MediaWikiServices::getRepoGroup in file related classes" 2020-03-14 18:11:21 +00:00
user Merge "Clean up unused $displayPassword return value" 2020-04-13 15:11:04 +00:00
utils Fix the namespace of SpecialPageFactory 2020-02-21 13:46:19 +11:00
watcheditem Merge "Add expiry type to ParamValidator" 2020-04-09 16:57:41 +00:00
widget Create a PHP version of jquery.spinner 2020-03-13 18:06:29 +01:00
xml Unify handling of options messages 2020-03-27 11:19:43 +08:00
.htaccess
ActorMigration.php Avoid upsert() log warning spam in ActorMigration due to unique key array format 2020-03-20 05:31:03 -07:00
AjaxDispatcher.php Set method visibility in some classes 2019-12-05 17:42:55 +00:00
AjaxResponse.php Remove more unused ajax response methods 2020-03-04 17:59:51 +00:00
AutoLoader.php Add PSR-4 mappings for existing namespaces and the top level 2020-03-10 21:08:30 +11:00
Autopromote.php Use namespaced IPUtils class 2020-01-01 02:36:49 -08:00
BadFileLookup.php Use MediaWikiServices::getRepoGroup in file related classes 2020-03-14 12:36:27 +00:00
CategoriesRdf.php
Category.php Cleanup various calls to IDatabase::upsert() 2020-02-27 15:27:29 -08:00
CategoryFinder.php Improve param docs 2019-11-28 19:08:59 +01:00
CategoryViewer.php Remove unreachable null checks after isset() 2020-02-28 21:40:48 +00:00
CommentStore.php Remove CommentStore::newKey, deprecated and unused 2020-02-20 02:00:15 +00:00
CommentStoreComment.php
ConfiguredReadOnlyMode.php
ContentSecurityPolicy.php Replace isset() in if() conditions with ?? if possible 2020-03-23 09:28:07 +01:00
DefaultSettings.php Merge "OutputPage: Add experimental preconnect resource hint for thumbnails" 2020-04-07 21:19:47 +00:00
Defines.php Provide MW_VERSION and deprecate fake global $wgVersion 2020-02-25 01:55:21 +00:00
DeprecatedGlobal.php Forbid wfDeprecated with $version = true 2019-12-31 13:53:36 +01:00
DerivativeRequest.php
DevelopmentSettings.php DevelopmentSettings: Disable resource limits 2020-03-29 21:11:12 +02:00
DummyLinker.php
EditPage.php Hard deprecate EditPage::getBaseRevision 2020-04-13 18:36:27 +00:00
EventRelayerGroup.php
FauxRequest.php Remove IE 6 security features from server-side code 2019-11-28 15:11:56 +11:00
FauxResponse.php Add missing @param and @return to documentation 2019-11-10 22:12:58 +00:00
FeedUtils.php Replace calls to Title::getUserPermissionsErrors (part 5) 2020-02-26 03:00:33 +00:00
FileDeleteForm.php FileDeleteForm: Use LocalFile::deleteFile 2020-03-20 20:46:53 +00:00
ForeignResourceManager.php Improve param docs 2019-11-28 19:08:59 +01:00
ForkController.php Remove usages of $wgMemc 2020-01-20 19:41:32 +01:00
FormOptions.php
GitInfo.php Coding style: Auto-fix MediaWiki.Usage.IsNull.IsNull 2020-01-10 14:17:13 -08:00
GlobalFunctions.php Add expiry type to ParamValidator 2020-04-08 16:21:04 -04:00
HeaderCallback.php
Hooks.php Improve param docs 2019-11-28 19:08:59 +01:00
Html.php languages: Introduce LanguageConverterFactory 2020-02-03 11:38:03 +02:00
Linker.php Accept RevisionRecord in Linker methods 2020-04-07 00:54:31 +00:00
LinkFilter.php Use namespaced IPUtils class 2020-01-01 02:36:49 -08:00
ListToggle.php
MagicWord.php Miscellaneous documentation updates 2020-02-16 04:38:38 +00:00
MagicWordArray.php Miscellaneous documentation updates 2020-02-16 04:38:38 +00:00
MagicWordFactory.php Miscellaneous documentation updates 2020-02-16 04:38:38 +00:00
MediaWiki.php Hard deprecate Action::factory with null argument $action 2020-04-11 03:48:56 +00:00
MediaWikiServices.php Add a new UserNameUtils service 2020-03-26 01:31:14 +00:00
MediaWikiVersionFetcher.php MediaWikiVersionFetcher: Change regex to capture any quoted string 2020-02-25 02:16:23 +00:00
MergeHistory.php MergeHistory: Remove use of Title::getUserPermissionsErrors (part 4) 2020-02-18 22:32:21 +00:00
MovePage.php MovePage: Don't fail to delete a nonexistent file 2020-04-07 13:58:39 +00:00
MWGrants.php Remove Language::factory and getParentLanguage use 2019-10-27 12:34:28 +02:00
MWNamespace.php
MWTimestamp.php
NoLocalSettings.php Update all use of $wgVersion to MW_VERSION 2020-02-25 02:16:12 +00:00
OrderedStreamingForkController.php
OutputHandler.php
OutputPage.php OutputPage: Add experimental preconnect resource hint for thumbnails 2020-04-07 21:04:47 +00:00
PageProps.php Upgrade phan to 0.9.1 2020-01-25 10:53:26 +00:00
PathRouter.php Coding style: Auto-fix MediaWiki.Usage.IsNull.IsNull 2020-01-10 14:17:13 -08:00
PHPVersionCheck.php PHPVersionCheck: Refactor triggerError() to be easier to understand 2020-03-02 01:46:09 +00:00
Pingback.php Cleanup various calls to IDatabase::upsert() 2020-02-27 15:27:29 -08:00
ProtectionForm.php Merge "Unify handling of options messages" 2020-04-06 23:20:44 +00:00
ProxyLookup.php
RawMessage.php
ReadOnlyMode.php
Revision.php Follow up to 7566934 - remove redundant check for RevisionStoreRecord 2020-04-12 22:09:17 +00:00
ServiceWiring.php Merge "objectcache: Improve wgMainWANCache docs" 2020-04-03 16:08:36 +00:00
Setup.php Setup: Document the responsibilities of entry points 2020-04-12 21:22:41 +01:00
SiteConfiguration.php SiteConfiguration: Remove by-ref return from getLocalDatabases() 2020-03-17 18:29:43 +00:00
SiteStats.php Coding style: Auto-fix MediaWiki.Classes.UnsortedUseStatements.UnsortedUse 2020-01-10 09:32:25 -08:00
SiteStatsInit.php sitestats: cleanup use of upsert() by removing the key column from SET 2020-02-26 01:18:47 -08:00
Status.php Use MediaWikiServices::getMessageCache 2020-03-14 14:25:03 +01:00
StreamFile.php Streamline/fix code by using short ?: and ?? syntax 2019-11-11 11:17:13 +01:00
StubObject.php
StubUserLang.php
TemplateParser.php TemplateParser: Inject BagOStuff and deprecate '$forceRecompile' 2020-03-23 20:09:05 +00:00
TemplatesOnThisPageFormatter.php
Title.php Merge "CdnCacheUpdate: Accept Titles in addition to strings" 2020-04-08 10:23:07 +00:00
TitleArray.php Set method visibility in some classes 2019-12-05 17:42:55 +00:00
TitleArrayFromResult.php Set method visibility for various constructors 2019-12-03 20:17:30 +01:00
TitleFactory.php Add TitleFactory 2019-10-18 00:00:46 +02:00
TrackingCategories.php Fix new phan errors, part 3 2019-10-12 10:35:22 +00:00
WebRequest.php WebRequest & RequestFromGlobals: get HTTP headers in one way 2020-04-03 09:32:41 +02:00
WebRequestUpload.php API: Use ParamValidator library 2020-02-04 13:36:14 -05:00
WebResponse.php
WebStart.php Setup: Move simple shortcuts together in Setup.php and improve docs 2020-03-14 23:10:07 +00:00
WikiMap.php Fix typo, remove double "a"s 2020-03-11 00:09:59 +05:30
WikiReference.php