assertEquals( false, … ) still succeeds when the actual value is 0, null, an empty string, even an empty array. All these should be reported as a failure, I would argue. Note this patch previously also touched assertSame( false ). I reverted these. The only benefit would have been consistency within this codebase, but there is no strict reason to prefer one over the other. assertFalse() and assertSame( false ) are functionally identical. Change-Id: Ic5f1c7d504e7249002d3184520012e03313137b4 |
||
|---|---|---|
| .. | ||
| filejournal | ||
| lockmanager | ||
| FileBackendGroupIntegrationTest.php | ||
| FileBackendTest.php | ||
| HTTPFileStreamerTest.php | ||
| SwiftFileBackendTest.php | ||