wiki.techinc.nl/includes/auth/AbstractPasswordPrimaryAuthenticationProvider.php
Dayllan Maza 4b39919c47 Add password policy setting suggestChangeOnLogin
Password policy checks that fail and have `suggestChangeOnLogin` set to true will
prompt for a password change on login.

Below are some rules that apply to this setting in different scenarios:

- If only one policy fails and has `suggestChangeOnLogin = false`, a password change will
  not be requested
- If more than one policy fails and one or more have `suggestChangeOnLogin` set to true`,
  a password change will be requested
- If `forceChange` is present in any of the failing policies, `suggestChangeOnLogin` value
  will be ignored and password change will be enforced
- if $wgInvalidPasswordReset is set to false `suggestChangeOnLogin` is ignored

IMPORTANT**
Before this patch, suggesting a password change was the default behavior (depending on
$wgInvalidPasswordReset), which means that the necessary changes to $wgPasswordPolicy
need to be in place before this patch is merged and gets to production.

Bug: T211621
Change-Id: I7a4a0a06273fa4e8bd0da3dac54cf5a1b78bb3fd
2019-03-09 14:59:02 -05:00

177 lines
5.1 KiB
PHP

<?php
/**
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
* @ingroup Auth
*/
namespace MediaWiki\Auth;
use Password;
use PasswordFactory;
use Status;
/**
* Basic framework for a primary authentication provider that uses passwords
* @ingroup Auth
* @since 1.27
*/
abstract class AbstractPasswordPrimaryAuthenticationProvider
extends AbstractPrimaryAuthenticationProvider
{
/** @var bool Whether this provider should ABSTAIN (false) or FAIL (true) on password failure */
protected $authoritative;
private $passwordFactory = null;
/**
* @param array $params Settings
* - authoritative: Whether this provider should ABSTAIN (false) or FAIL
* (true) on password failure
*/
public function __construct( array $params = [] ) {
$this->authoritative = !isset( $params['authoritative'] ) || (bool)$params['authoritative'];
}
/**
* Get the PasswordFactory
* @return PasswordFactory
*/
protected function getPasswordFactory() {
if ( $this->passwordFactory === null ) {
$this->passwordFactory = new PasswordFactory(
$this->config->get( 'PasswordConfig' ),
$this->config->get( 'PasswordDefault' )
);
}
return $this->passwordFactory;
}
/**
* Get a Password object from the hash
* @param string $hash
* @return Password
*/
protected function getPassword( $hash ) {
$passwordFactory = $this->getPasswordFactory();
try {
return $passwordFactory->newFromCiphertext( $hash );
} catch ( \PasswordError $e ) {
$class = static::class;
$this->logger->debug( "Invalid password hash in {$class}::getPassword()" );
return $passwordFactory->newFromCiphertext( null );
}
}
/**
* Return the appropriate response for failure
* @param PasswordAuthenticationRequest $req
* @return AuthenticationResponse
*/
protected function failResponse( PasswordAuthenticationRequest $req ) {
if ( $this->authoritative ) {
return AuthenticationResponse::newFail(
wfMessage( $req->password === '' ? 'wrongpasswordempty' : 'wrongpassword' )
);
} else {
return AuthenticationResponse::newAbstain();
}
}
/**
* Check that the password is valid
*
* This should be called *before* validating the password. If the result is
* not ok, login should fail immediately.
*
* @param string $username
* @param string $password
* @return Status
*/
protected function checkPasswordValidity( $username, $password ) {
return \User::newFromName( $username )->checkPasswordValidity( $password );
}
/**
* Check if the password should be reset
*
* This should be called after a successful login. It sets 'reset-pass'
* authentication data if necessary, see
* ResetPassSecondaryAuthenticationProvider.
*
* @param string $username
* @param Status $status From $this->checkPasswordValidity()
* @param mixed|null $data Passed through to $this->getPasswordResetData()
*/
protected function setPasswordResetFlag( $username, Status $status, $data = null ) {
$reset = $this->getPasswordResetData( $username, $data );
if ( !$reset && $this->config->get( 'InvalidPasswordReset' ) && !$status->isGood() ) {
$hard = $status->getValue()['forceChange'] ?? false;
if ( $hard || !empty( $status->getValue()['suggestChangeOnLogin'] ) ) {
$reset = (object)[
'msg' => $status->getMessage( $hard ? 'resetpass-validity' : 'resetpass-validity-soft' ),
'hard' => $hard,
];
}
}
if ( $reset ) {
$this->manager->setAuthenticationSessionData( 'reset-pass', $reset );
}
}
/**
* Get password reset data, if any
*
* @param string $username
* @param mixed $data
* @return object|null { 'hard' => bool, 'msg' => Message }
*/
protected function getPasswordResetData( $username, $data ) {
return null;
}
/**
* Get expiration date for a new password, if any
*
* @param string $username
* @return string|null
*/
protected function getNewPasswordExpiry( $username ) {
$days = $this->config->get( 'PasswordExpirationDays' );
$expires = $days ? wfTimestamp( TS_MW, time() + $days * 86400 ) : null;
// Give extensions a chance to force an expiration
\Hooks::run( 'ResetPasswordExpiration', [ \User::newFromName( $username ), &$expires ] );
return $expires;
}
public function getAuthenticationRequests( $action, array $options ) {
switch ( $action ) {
case AuthManager::ACTION_LOGIN:
case AuthManager::ACTION_REMOVE:
case AuthManager::ACTION_CREATE:
case AuthManager::ACTION_CHANGE:
return [ new PasswordAuthenticationRequest() ];
default:
return [];
}
}
}