wiki.techinc.nl/includes/profiler/output
Timo Tijhof 734b0e9f74 profiler: Actually escape debug text in ProfilerOutputText
The method names are basically all reviewed source code that is unlikely
to contain characters that would terminate a comment in HTML, CSS,
or JS. However, we also include virtual call frames for database
queries, such as:

>  0.30% 62 - ParserOptions::getTargetLanguage
>  0.29% 1 - section.query-m: SELECT /* WikiPage::pageData */ page_id,.. FROM page WHERE .. LIMIT 1
>  0.29% 104 - MediaWiki\Logger\LoggerFactory::getInstance

This has two problems:

1. The queries contain a block comment, which is not only likely
   but guruanteed to terminate a containing block comment, as a result
   this broke load.php CSS and JS responses (CSS was fine-ish, since
   it just gets some recoverable parse warnings after the rest of the
   stylesheet; JS was less fine).

   For formatBlockComment, I use the same replacement as what we do
   in ResourceLoader::makeComment() already/

2. For the HTML mode, it seems not unlikely that for certain queries
   it might terminate the HTML comment or (in "visible" mode) cause
   characters to not be displayed correctly due to interpreted as
   HTML instead of plain text when inside a <pre> element.

Change-Id: I1a9f1ed149f374805d6493f07f5430786d8700fa
2022-03-25 12:38:28 +00:00
..
ProfilerOutput.php
ProfilerOutputDump.php
ProfilerOutputStats.php
ProfilerOutputText.php profiler: Actually escape debug text in ProfilerOutputText 2022-03-25 12:38:28 +00:00