7b4b0135b9
All the other ways of doing it were ridiculous and much harder to read, and usually required repeating the needle expression (to get its length). I found these occurrences by grepping for various expressions, but I undoubtedly missed some. I didn't try replacing the many instances of strpos(...) === 0 with str_starts_with(...), because I think they're readable enough as-is (although less efficient). Likewise I didn't try porting strpos(...) !== false to str_contains(...). For case-insensitive comparisons, Tim Starling requested that we stick with substr_compare() because it's more efficient than calling strtolower(). On PHP < 8 these functions will be included with a polyfill via vendor/autoload.php. This is included at the beginning of includes/AutoLoader.php, so if our autoloader has been included the polyfill will be available. This means it should be safe to call these functions from any code that would not be usable without our autoloader. Three uses that Tim Starling identified as being performance-sensitive have been split out to a separate commit for porting after the switch to PHP 8. Change-Id: I113a8d052b6845852c15969a2f0e6fbbe3e9f8d9
57 lines
2 KiB
PHP
57 lines
2 KiB
PHP
<?php
|
|
/**
|
|
* Copyright (C) 2017 Kunal Mehta <legoktm@debian.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
use PHPUnit\Framework\CodeCoverageException;
|
|
use PHPUnit\Util\Test;
|
|
|
|
/**
|
|
* Check that `@covers` tags are valid. PHPUnit only does this when generating
|
|
* code coverage reports, which is slow and we generally don't do that when
|
|
* running tests during development and pre-merge in CI.
|
|
*
|
|
* @since 1.31
|
|
*/
|
|
trait MediaWikiCoversValidator {
|
|
|
|
/**
|
|
* Assert that all "test*" methods in the host class have valid `@covers` tags.
|
|
*
|
|
* Don't use a data provider here because this assertion will be run many
|
|
* thousands of times in CI, and the implicit overhead from PHPUnit with
|
|
* generating and executing a test case around each becomes rather significant
|
|
* at that scale. Also, when using a data provider, the setUp() and tearDown()
|
|
* of the host class would be re-run for every check, which becomes very
|
|
* expensive for integration tests that involve databases.
|
|
*/
|
|
public function testValidCovers() {
|
|
$class = static::class;
|
|
foreach ( get_class_methods( $this ) as $method ) {
|
|
if ( str_starts_with( $method, 'test' ) ) {
|
|
try {
|
|
Test::getLinesToBeCovered( $class, $method );
|
|
} catch ( CodeCoverageException $ex ) {
|
|
$this->fail( "$class::$method: " . $ex->getMessage() );
|
|
}
|
|
}
|
|
}
|
|
|
|
$this->addToAssertionCount( 1 );
|
|
}
|
|
}
|