wiki.techinc.nl/tests/phpunit/unit/includes/Message/ConverterTest.php
Bartosz Dziewoński 7ad5a2ca54 ScalarParam: Un-deprecate Stringable, deprecate ParamType::OBJECT instead
Follow-up to f18362ccce.
While working on I625a48a6ecd3fad5c2ed76b23343a0fef91e1b83,
I learned that Stringable objects are sometimes also used
as normal params, intended to be stringified when rendering.
For example, see `this->target` in the UnblockUser class.

That code uses Message objects, so it's not causing trouble,
but converting them to MessageValue would emit warnings.
I didn't actually intend to deprecate that, and it won't
cause issues with JSON-serializability (assuming we stringify
the objects in time), so tweak how the warnings are emitted.

Change-Id: I26dfd4f1ac8ed08a422692de4e39d072242c08df
2024-07-22 19:13:59 +00:00

151 lines
4.6 KiB
PHP

<?php
namespace MediaWiki\Tests\Unit\Message;
use InvalidArgumentException;
use Language;
use MediaWiki\Language\RawMessage;
use MediaWiki\Message\Converter;
use MediaWiki\Message\Message;
use MediaWiki\User\UserIdentityValue;
use MediaWikiUnitTestCase;
use Wikimedia\Message\MessageValue;
/**
* @covers \MediaWiki\Message\Converter
*/
class ConverterTest extends MediaWikiUnitTestCase {
public function testCreateMessage() {
$converter = new Converter();
$m = $converter->createMessage( 'foobar' );
$this->assertInstanceOf( Message::class, $m );
$this->assertSame( 'foobar', $m->getKey() );
$this->assertSame( [], $m->getParams() );
}
/** @dataProvider provideConversions */
public function testConvertMessage( Message $m, MessageValue $mv ) {
$converter = new Converter();
$this->assertEquals( $mv, $converter->convertMessage( $m ) );
}
/** @dataProvider provideConversions */
public function testConvertMessageValue( Message $m, MessageValue $mv ) {
$converter = new Converter();
$this->assertEquals( $m, $converter->convertMessageValue( $mv ) );
}
public static function provideConversions() {
yield 'Basic message, no params' => [
new Message( 'foobar' ),
new MessageValue( 'foobar' ),
];
yield 'Scalar text params' => [
new Message( 'foobar', [ 'one', 2, 3 ] ),
new MessageValue( 'foobar', [ 'one', 2, 3 ] ),
];
$u = new UserIdentityValue( 1, 'Username' );
yield 'Stringable params' => [
new Message( 'foobar', [ $u ] ),
new MessageValue( 'foobar', [ $u ] ),
];
yield 'Message(Value) as param' => [
new Message( 'foo', [ new Message( 'bar', [ new Message( 'baz' ) ] ) ] ),
new MessageValue( 'foo', [ new MessageValue( 'bar', [ new MessageValue( 'baz' ) ] ) ] ),
];
yield 'numParams' => [
Message::newFromKey( 'foobar' )->numParams( 1, 2, 3 ),
MessageValue::new( 'foobar' )->numParams( 1, 2, 3 ),
];
yield 'longDurationParams' => [
Message::newFromKey( 'foobar' )->durationParams( 1, 2, 3 ),
MessageValue::new( 'foobar' )->longDurationParams( 1, 2, 3 ),
];
yield 'shortDurationParams' => [
Message::newFromKey( 'foobar' )->timeperiodParams( 1, 2, 3 ),
MessageValue::new( 'foobar' )->shortDurationParams( 1, 2, 3 ),
];
yield 'expiryParams' => [
Message::newFromKey( 'foobar' )->expiryParams( 1, 2, 'infinity' ),
MessageValue::new( 'foobar' )->expiryParams( 1, 2, 'infinity' ),
];
yield 'sizeParams' => [
Message::newFromKey( 'foobar' )->sizeParams( 1, 2, 3 ),
MessageValue::new( 'foobar' )->sizeParams( 1, 2, 3 ),
];
yield 'bitrateParams' => [
Message::newFromKey( 'foobar' )->bitrateParams( 1, 2, 3 ),
MessageValue::new( 'foobar' )->bitrateParams( 1, 2, 3 ),
];
yield 'rawParams' => [
Message::newFromKey( 'foobar' )->rawParams( 1, 2, 3 ),
MessageValue::new( 'foobar' )->rawParams( 1, 2, 3 ),
];
yield 'plaintextParams' => [
Message::newFromKey( 'foobar' )->plaintextParams( 1, 2, 3 ),
MessageValue::new( 'foobar' )->plaintextParams( 1, 2, 3 ),
];
yield 'listParams' => [
Message::newFromKey( 'foobar',
Message::listParam( [ 1, 2, 3 ], 'comma' ),
Message::listParam( [ 4, 5, 6 ], 'semicolon' ),
Message::listParam( [ 7, 8, 9 ], 'pipe' ),
Message::listParam( [ 10, 11, 12 ], 'text' )
),
MessageValue::new( 'foobar' )
->commaListParams( [ 1, 2, 3 ] )
->semicolonListParams( [ 4, 5, 6 ] )
->pipeListParams( [ 7, 8, 9 ] )
->textListParams( [ 10, 11, 12 ] ),
];
}
public function testConvertMessage_invalidParam() {
$m = Message::newFromKey( 'foobar', [ 'foo' => 'bar' ] );
$converter = new Converter();
$this->expectException( InvalidArgumentException::class );
$converter->convertMessage( $m );
}
public static function provideConversions_RawMessage() {
yield 'No params' => [
new RawMessage( 'Foo Bar' ),
new MessageValue( 'rawmessage', [ 'Foo Bar' ] ),
];
yield 'Single param' => [
new RawMessage( '$1', [ 'Foo Bar' ] ),
new MessageValue( 'rawmessage', [ 'Foo Bar' ] ),
];
yield 'Multiple params' => [
new RawMessage( '$1 $2', [ 'Foo', 'Bar' ] ),
new MessageValue( 'rawmessage', [ 'Foo Bar' ] ),
];
}
/** @dataProvider provideConversions_RawMessage */
public function testConvertMessage_RawMessage( RawMessage $m, MessageValue $mv ) {
// Tests for unidirectional conversion from RawMessage.
// The result doesn't roundtrip, but it at least renders the same output.
$converter = new Converter();
// Avoid service container access in the multiple param case
$lang = $this->createMock( Language::class );
$m->inLanguage( $lang );
$this->assertEquals( $mv, $converter->convertMessage( $m ) );
}
}