wiki.techinc.nl/tests/parser/ParserTestParserHook.php
Máté Szabó 377c53ae51 Don't p-wrap <aside> tags in extension HTML
Our PortableInfobox extension uses the HTML5 <aside> tag in its generated HTML.
This tag isn't recognized as a block element (in the way e.g. <div> is) by the
legacy parser, resulting in some spurious empty paragraphs in the output.

As a fix, make the legacy parser aware of <aside> tags to avoid unnecessary
p-wrapping. Also add <aside> to the Sanitizer's internal attribute check.
I3e57f55ac69d2c1ee8a1d41c21b692e56fc7e628 takes care of updating Parsoid-PHP
accordingly.

Bug: T278565
Change-Id: I89dbdf7770e13e1b62320228a366c64e64217b0b
2021-04-06 16:26:12 +02:00

67 lines
2.3 KiB
PHP

<?php
/**
* A basic extension that's used by the parser tests to test whether input and
* arguments are passed to extensions properly.
*
* Copyright © 2005, 2006 Ævar Arnfjörð Bjarmason
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
* http://www.gnu.org/copyleft/gpl.html
*
* @file
* @ingroup Testing
* @author Ævar Arnfjörð Bjarmason <avarab@gmail.com>
*/
class ParserTestParserHook {
public static function setup( Parser $parser ) {
$parser->setHook( 'tag', [ __CLASS__, 'dumpHook' ] );
$parser->setHook( 'tåg', [ __CLASS__, 'dumpHook' ] );
$parser->setHook( 'statictag', [ __CLASS__, 'staticTagHook' ] );
$parser->setHook( 'asidetag', [ __CLASS__, 'asideTagHook' ] );
return true;
}
public static function dumpHook( $in, $argv ) {
return "<pre>\n" .
var_export( $in, true ) . "\n" .
var_export( $argv, true ) . "\n" .
"</pre>";
}
public static function staticTagHook( $in, $argv, $parser ) {
if ( !count( $argv ) ) {
$parser->static_tag_buf = $in;
return '';
} elseif ( count( $argv ) === 1 && isset( $argv['action'] )
&& $argv['action'] === 'flush' && $in === null
) {
// Clear the buffer, we probably don't need to
$tmp = $parser->static_tag_buf ?? '';
$parser->static_tag_buf = null;
return $tmp;
} else { // wtf?
return "\nCall this extension as <statictag>string</statictag> or as" .
" <statictag action=flush/>, not in any other way.\n" .
"text: " . var_export( $in, true ) . "\n" .
"argv: " . var_export( $argv, true ) . "\n";
}
}
public static function asideTagHook(): string {
return Html::element( 'aside', [], 'Some aside content' );
}
}