Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/tests/phpunit/maintenance
History
Thiemo Kreuz b95a07380a Remove meaningless ->expects( $this->any() ) from all tests 
It is not entirely meaningless. It might be an indicator that
the number of calls to a method is intentionally unlimited.
This is similar to e.g. an @inheritDoc PHPDoc comment that
marks a method as being "intentionally undocumented".

However, what's the meaning of being "intentionally
unconstrained"? Let's just not have any constraint then.

I feel all these ->expects( $this->any() ) bloat the test
code so much that it's never worth it.

Change-Id: I9925e7706bd03e1666f6eb0b284cb42b0dd3be23
2021-04-23 11:58:58 +02:00
..
backup_LogTest.php Fix incomplete/bogus PHPDoc tags in various tests 2021-01-14 19:02:00 +00:00
backup_PageTest.php MediaWikiTestCase to MediaWikiIntegrationTestCase 2020-06-30 17:02:22 +01:00
backupPrefetchTest.php build: Update mediawiki/mediawiki-codesniffer to 35.0.0 2021-01-31 13:34:38 +00:00
backupTextPassTest.php phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
BenchmarkerTest.php phpunit: Mass-replace setMethods with onlyMethods and adjust 2021-04-16 20:15:00 +02:00
categoriesRdfTest.php Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
categoryChangesAsRdfTest.php Remove meaningless ->expects( $this->any() ) from all tests 2021-04-23 11:58:58 +02:00
deleteAutoPatrolLogsTest.php Tests: Mark more closures as static 2021-02-07 13:26:56 +01:00
DumpAsserter.php Make dump tests based on fixture files. 2020-04-06 15:21:00 -07:00
DumpTestCase.php Tests: Mark more closures as static 2021-02-07 13:26:56 +01:00
fetchTextTest.php MediaWikiTestCase to MediaWikiIntegrationTestCase 2020-06-30 17:02:22 +01:00
MaintenanceBaseTestCase.php Split MaintenanceTest::testParseArgs and fix docs 2020-11-24 19:05:40 +00:00
MaintenanceTest.php Maintenance: Don't modify mOptions in getOption 2021-02-25 15:42:05 +00:00
PageDumpTestDataTrait.php PageDumpTestDataTrait: Pass a user to WikiPage::doDeleteArticleReal 2020-04-16 17:03:54 +00:00
xml.xsd Remove traling double newlines from text files 2019-10-23 21:17:43 +02:00