Thijs/wiki.techinc.nl
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
wiki.techinc.nl/tests/phpunit/includes
History
Thiemo Kreuz e4272518f7 tests: Replace PHPUnit's loose assertEquals(false) with assertFalse() 
assertEquals( false, … ) still succeeds when the actual value is 0, null,
an empty string, even an empty array. All these should be reported as a
failure, I would argue.

Note this patch previously also touched assertSame( false ). I reverted
these. The only benefit would have been consistency within this codebase,
but there is no strict reason to prefer one over the other. assertFalse()
and assertSame( false ) are functionally identical.

Change-Id: Ic5f1c7d504e7249002d3184520012e03313137b4
2019-10-04 00:30:36 +00:00
..
actions Replace User::isAllowed with PermissionManager. 2019-08-20 14:43:51 -07:00
api Merge "tests: Fix broken assertion in ApiQueryAllPagesTest" 2019-10-01 13:31:19 +00:00
auth tests: Prefer assertSame() when comparing the integer 0 2019-09-19 15:35:23 +00:00
block block: Allow cookie-block tracking from any uncached web request 2019-10-01 13:52:58 -04:00
cache tests: Prefer assertSame() when comparing the integer 0 2019-09-19 15:35:23 +00:00
changes tests: Replace PHPUnit's loose assertEquals(false) with assertFalse() 2019-10-04 00:30:36 +00:00
changetags ChangeTags: turn private getPrevTags() into public getTags() 2019-08-07 15:19:20 +02:00
collation Revert "Separate MediaWiki unit and integration tests" 2019-06-13 23:00:08 +00:00
config Test that classes use all their ServiceOptions 2019-08-19 20:42:28 +03:00
content tests: Replace PHPUnit's loose assertEquals(null) with assertNull() 2019-09-27 19:15:38 +00:00
context tests: Prefer assertSame() when comparing the integer 0 2019-09-19 15:35:23 +00:00
db tests: Replace PHPUnit's loose assertEquals(null) with assertNull() 2019-09-27 19:15:38 +00:00
debug Load GlobalFunctions.php to tests/phpunit/bootstrap.php 2019-07-14 01:28:07 +02:00
deferred tests: Prefer assertSame() when comparing the integer 0 2019-09-19 15:35:23 +00:00
diff phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase 2019-09-02 20:58:34 +01:00
editpage Mass conversion to NamespaceInfo 2019-05-07 22:44:56 +02:00
exception Move trivially compatible tests to the unit tests suite 2019-06-30 15:23:53 +02:00
externalstore tests: Replace PHPUnit's loose assertEquals(false) with assertFalse() 2019-10-04 00:30:36 +00:00
filebackend tests: Replace PHPUnit's loose assertEquals(false) with assertFalse() 2019-10-04 00:30:36 +00:00
filerepo tests: Prefer PHPUnit's assertSame() when comparing empty strings 2019-09-20 15:27:58 +00:00
GlobalFunctions tests: Replace PHPUnit's loose assertEquals(false) with assertFalse() 2019-10-04 00:30:36 +00:00
htmlform Load GlobalFunctions.php to tests/phpunit/bootstrap.php 2019-07-14 01:28:07 +02:00
http Merge "tests: Prefer PHPUnit's assertSame() when comparing empty strings" 2019-09-20 15:55:08 +00:00
import Include change tags in revision import structure 2019-09-03 21:14:16 +02:00
interwiki Remove unneeded overrideMwServices/resetServices 2019-08-29 14:26:18 +03:00
jobqueue tests: Prefer assertSame() when comparing the integer 0 2019-09-19 15:35:23 +00:00
language language: Move ConverterRule to includes/ and add test case 2019-08-26 12:32:14 +01:00
libs tests: Replace PHPUnit's loose assertEquals(false) with assertFalse() 2019-10-04 00:30:36 +00:00
linkeddata
linker tests: Prefer PHPUnit's assertSame() when comparing empty strings 2019-09-20 15:27:58 +00:00
logging Fix permission check on protection log 2019-09-27 09:58:41 -07:00
mail
media tests: Prefer assertSame() when comparing the integer 0 2019-09-19 15:35:23 +00:00
Message lib/Message: Support MessageValue as a parameter 2019-08-30 15:14:37 -04:00
Navigation Refactor buildPrevNextNavigation 2019-06-05 19:32:27 -04:00
objectcache Remove unneeded overrideMwServices/resetServices 2019-08-29 14:26:18 +03:00
page Force usage of MCR aware database schema 2019-09-27 11:31:23 +00:00
pager tests: Replace PHPUnit's loose assertEquals(null) with assertNull() 2019-09-27 19:15:38 +00:00
parser phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase 2019-09-02 20:58:34 +01:00
password Revert "Unbreak Pbkdf2PasswordTest" 2019-10-03 14:58:47 -07:00
Permissions tests: Replace PHPUnit's loose assertEquals(false) with assertFalse() 2019-10-04 00:30:36 +00:00
poolcounter Add missing newline between <?php and namespace/use section 2019-06-03 13:36:48 +00:00
preferences Break PreferencesFormOOUI->PermissionManager dependency 2019-09-17 08:34:53 -07:00
rcfeed Clear test user registry between tests 2019-08-14 10:27:21 +03:00
registration registration: Avoid redundant LBYL check in ExtensionRegistry::queue() 2019-09-01 18:28:41 +00:00
resourceloader resourceloader: Simplify makeLoaderStateScript and makeLoaderSourcesScript 2019-09-28 18:26:40 +00:00
Rest Use UserIdentity instead of User in REST 2019-09-18 14:45:01 +10:00
Revision Storage: SqlBlobStore no longer needs Lanugage object 2019-10-02 09:26:34 -07:00
search tests: Prefer assertSame() when comparing the integer 0 2019-09-19 15:35:23 +00:00
session tests: Replace assertions on count() == 0 with strict === [] 2019-09-30 16:20:34 +02:00
shell tests: Prefer assertSame() when comparing the integer 0 2019-09-19 15:35:23 +00:00
site Merge "tests: Prefer PHPUnit's assertSame() when comparing empty strings" 2019-09-20 15:55:08 +00:00
skins Move trivially compatible tests to the unit tests suite 2019-06-30 15:23:53 +02:00
sparql Revert "Separate MediaWiki unit and integration tests" 2019-06-13 23:00:08 +00:00
specialpage Fix typo in ChangesListSpecialPageTest 2019-09-09 11:38:36 -04:00
specials tests: Make SpecialPageDataTest independend from the language 2019-09-19 12:53:08 +02:00
Storage Storage: SqlBlobStore no longer needs Lanugage object 2019-10-02 09:26:34 -07:00
title Remove unneeded overrideMwServices/resetServices 2019-08-29 14:26:18 +03:00
upload Relax HTML sniffing checks on image upload 2019-06-07 14:21:00 -07:00
user Merge "Optionally require both username and email for password resets" 2019-10-02 21:41:50 +00:00
utils phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase 2019-09-02 20:58:34 +01:00
watcheditem HHVM removal: Kill HHVM_VERSION checks in PHPUnit tests 2019-10-03 15:35:21 +00:00
ActorMigrationTest.php Mostly drop old pre-actor user schemas 2019-09-09 11:38:36 -04:00
ActorMigrationTest.sql Mostly drop old pre-actor user schemas 2019-09-09 11:38:36 -04:00
AutoLoaderTest.php
AutopromoteTest.php
CategoryTest.php
CommentStoreCommentTest.php Revert "Separate MediaWiki unit and integration tests" 2019-06-13 23:00:08 +00:00
CommentStoreTest.php CommentStore: Accept SCHEMA_COMPAT_* constants 2019-09-26 11:17:50 +00:00
CommentStoreTest.sql
ContentSecurityPolicyTest.php Remove unneeded overrideMwServices/resetServices 2019-08-29 14:26:18 +03:00
DeprecatedGlobalTest.php
DiffHistoryBlobTest.php
EditPageTest.php tests: Prefer assertSame() when comparing the integer 0 2019-09-19 15:35:23 +00:00
ExportTest.php
ExtraParserTest.php
FauxRequestTest.php tests: Replace PHPUnit's loose assertEquals(false) with assertFalse() 2019-10-04 00:30:36 +00:00
GitInfoTest.php tests: Replace PHPUnit's loose assertEquals(false) with assertFalse() 2019-10-04 00:30:36 +00:00
HooksTest.php Revert "Separate MediaWiki unit and integration tests" 2019-06-13 23:00:08 +00:00
HtmlTest.php Replace infobox usages and extend successbox, warningbox and errorbox 2019-09-24 16:29:32 -07:00
LinkerTest.php tests: Prefer assertSame() when comparing the integer 0 2019-09-19 15:35:23 +00:00
LinkFilterTest.php
ListToggleTest.php Revert "Separate MediaWiki unit and integration tests" 2019-06-13 23:00:08 +00:00
MagicWordFactoryTest.php Revert "Separate MediaWiki unit and integration tests" 2019-06-13 23:00:08 +00:00
MediaWikiServicesTest.php tests: Prefer assertSame() when comparing the integer 0 2019-09-19 15:35:23 +00:00
MediaWikiTest.php
MediaWikiVersionFetcherTest.php Unset all globals unneeded for unit tests, assert correct directory 2019-07-09 14:09:29 -04:00
MergeHistoryTest.php Don't use new MCR schema without using DB 2019-08-13 17:05:24 +03:00
MessageTest.php Remove unneeded overrideMwServices/resetServices 2019-08-29 14:26:18 +03:00
MovePageTest.php Merge "createNoOpMock() method for PHPUnit tests" 2019-08-29 18:15:43 +00:00
MultiHttpClientTest.php
MWTimestampTest.php
OutputPageTest.php tests: Prefer assertSame() when comparing the integer 0 2019-09-19 15:35:23 +00:00
PagePropsTest.php Mass conversion to NamespaceInfo 2019-05-07 22:44:56 +02:00
PrefixSearchTest.php Remove unneeded overrideMwServices/resetServices 2019-08-29 14:26:18 +03:00
ReadOnlyModeTest.php Don't pass Config to service constructors 2019-05-02 11:33:56 +03:00
RevisionDbTestBase.php Mostly drop old pre-actor user schemas 2019-09-09 11:38:36 -04:00
RevisionMcrDbTest.php
RevisionMcrReadNewDbTest.php
RevisionMcrWriteBothDbTest.php Add missing newline between <?php and namespace/use section 2019-06-03 13:36:48 +00:00
RevisionTest.php Storage: SqlBlobStore no longer needs Lanugage object 2019-10-02 09:26:34 -07:00
RevisionTestModifyableContent.php
RevisionTestModifyableContentHandler.php
SampleTest.php Replace old URLs in SampleTest 2019-07-10 15:00:12 +01:00
SiteStatsTest.php tests: Prefer assertSame() when comparing the integer 0 2019-09-19 15:35:23 +00:00
StatusTest.php tests: Replace PHPUnit's loose assertEquals(false) with assertFalse() 2019-10-04 00:30:36 +00:00
SystemBlockTest.php Separate Block into AbstractBlock, Block and SystemBlock 2019-05-07 17:36:31 -05:00
TemplateCategoriesTest.php Re-apply: Factors out permissions check from User into PermissionManager service 2019-06-28 13:19:38 -07:00
TemplateParserTest.php
TestLogger.php Use [...] instead of array(...) in PHP comments and documentation 2019-06-17 21:15:09 +02:00
TestUser.php Drop last bits of oracle 2019-08-14 23:44:22 +02:00
TestUserRegistry.php tests: Remove use of wfRandomString() for test fixtures 2019-05-06 17:22:03 +00:00
TimeAdjustTest.php
TitleMethodsTest.php tests: Prefer assertSame() when comparing the integer 0 2019-09-19 15:35:23 +00:00
TitlePermissionTest.php tests: Replace PHPUnit's loose assertEquals(false) with assertFalse() 2019-10-04 00:30:36 +00:00
TitleTest.php tests: Replace PHPUnit's loose assertEquals(false) with assertFalse() 2019-10-04 00:30:36 +00:00
WebRequestTest.php Rename CDN config variables to be generic, deprecating the old names 2019-05-24 21:09:22 +00:00
WikiMapTest.php Removed deprecated WikiMap::getWikiIdFromDomain() method 2019-07-14 01:17:31 +01:00
WikiReferenceTest.php phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase 2019-09-02 20:58:34 +01:00
XmlTest.php tests: Prefer PHPUnit's assertSame() when comparing empty strings 2019-09-20 15:27:58 +00:00