72b14c9459
- MediaWiki no longer supports PHP versions that are old enough to include the null terminator in the sort key, so there's no need to remove it using rtrim(). See T137642 for more information. - Simplify prefix comparison by setting the initial value of $prev to the empty string rather than false. A PHP array key can only be an integer or string, so there's no other reason to check for false. - $letterMap is unset to "Reduce memory usage before caching", which made sense at the time (r80443 /eaeea84b44). In2a86b5a17a, the code was refactored such that $letterMap goes out of scope before we save to the cache, so unset() should no longer be needed. Change-Id: Id99ab3a6a29d037912f4ab3e817dba52d2ac24e8
122 lines
3.5 KiB
PHP
122 lines
3.5 KiB
PHP
<?php
|
||
|
||
/**
|
||
* Class CollationTest
|
||
* @covers Collation
|
||
* @covers IcuCollation
|
||
* @covers IdentityCollation
|
||
* @covers UppercaseCollation
|
||
*/
|
||
class CollationTest extends MediaWikiLangTestCase {
|
||
|
||
/**
|
||
* Test to make sure, that if you
|
||
* have "X" and "XY", the binary
|
||
* sortkey also has "X" being a
|
||
* prefix of "XY". Our collation
|
||
* code makes this assumption.
|
||
*
|
||
* @param string $lang Language code for collator
|
||
* @param string $base
|
||
* @param string $extended String containing base as a prefix.
|
||
*
|
||
* @covers Collation::getSortKey()
|
||
* @covers IcuCollation::getSortKey()
|
||
* @covers IdentityCollation::getSortKey()
|
||
* @covers UppercaseCollation::getSortKey()
|
||
* @dataProvider prefixDataProvider
|
||
*/
|
||
public function testIsPrefix( $lang, $base, $extended ) {
|
||
$cp = Collator::create( $lang );
|
||
$cp->setStrength( Collator::PRIMARY );
|
||
$baseBin = $cp->getSortKey( $base );
|
||
$extendedBin = $cp->getSortKey( $extended );
|
||
$this->assertStringStartsWith( $baseBin, $extendedBin, "$base is not a prefix of $extended" );
|
||
}
|
||
|
||
public static function prefixDataProvider() {
|
||
return [
|
||
[ 'en', 'A', 'AA' ],
|
||
[ 'en', 'A', 'AAA' ],
|
||
[ 'en', 'Д', 'ДЂ' ],
|
||
[ 'en', 'Д', 'ДA' ],
|
||
// 'Ʒ' should expand to 'Z ' (note space).
|
||
[ 'fi', 'Z', 'Ʒ' ],
|
||
// 'Þ' should expand to 'th'
|
||
[ 'sv', 't', 'Þ' ],
|
||
// Javanese is a limited use alphabet, so should have 3 bytes
|
||
// per character, so do some tests with it.
|
||
[ 'en', 'ꦲ', 'ꦲꦤ' ],
|
||
[ 'en', 'ꦲ', 'ꦲД' ],
|
||
[ 'en', 'A', 'Aꦲ' ],
|
||
];
|
||
}
|
||
|
||
/**
|
||
* Opposite of testIsPrefix
|
||
*
|
||
* @covers Collation::getSortKey()
|
||
* @covers IcuCollation::getSortKey()
|
||
* @covers IdentityCollation::getSortKey()
|
||
* @covers UppercaseCollation::getSortKey()
|
||
* @dataProvider notPrefixDataProvider
|
||
*/
|
||
public function testNotIsPrefix( $lang, $base, $extended ) {
|
||
$cp = Collator::create( $lang );
|
||
$cp->setStrength( Collator::PRIMARY );
|
||
$baseBin = $cp->getSortKey( $base );
|
||
$extendedBin = $cp->getSortKey( $extended );
|
||
$this->assertStringStartsNotWith( $baseBin, $extendedBin, "$base is a prefix of $extended" );
|
||
}
|
||
|
||
public static function notPrefixDataProvider() {
|
||
return [
|
||
[ 'en', 'A', 'B' ],
|
||
[ 'en', 'AC', 'ABC' ],
|
||
[ 'en', 'Z', 'Ʒ' ],
|
||
[ 'en', 'A', 'ꦲ' ],
|
||
];
|
||
}
|
||
|
||
/**
|
||
* Test correct first letter is fetched.
|
||
*
|
||
* @param string $collation Collation name (aka uca-en)
|
||
* @param string $string String to get first letter of
|
||
* @param string $firstLetter Expected first letter.
|
||
*
|
||
* @covers Collation::getFirstLetter()
|
||
* @covers IcuCollation::getFirstLetter()
|
||
* @covers IdentityCollation::getFirstLetter()
|
||
* @covers UppercaseCollation::getFirstLetter()
|
||
* @dataProvider firstLetterProvider
|
||
*/
|
||
public function testGetFirstLetter( $collation, $string, $firstLetter ) {
|
||
$col = $this->getServiceContainer()->getCollationFactory()->makeCollation( $collation );
|
||
$this->assertEquals( $firstLetter, $col->getFirstLetter( $string ) );
|
||
}
|
||
|
||
public function firstLetterProvider() {
|
||
return [
|
||
[ 'uppercase', 'Abc', 'A' ],
|
||
[ 'uppercase', 'abc', 'A' ],
|
||
[ 'identity', 'abc', 'a' ],
|
||
[ 'uca-en', 'abc', 'A' ],
|
||
[ 'uca-en', ' ', ' ' ],
|
||
[ 'uca-en', 'Êveryone', 'E' ],
|
||
[ 'uca-vi', 'Êveryone', 'Ê' ],
|
||
// Make sure thorn is not a first letter.
|
||
[ 'uca-sv', 'The', 'T' ],
|
||
[ 'uca-sv', 'Å', 'Å' ],
|
||
[ 'uca-hu', 'dzsdo', 'Dzs' ],
|
||
[ 'uca-hu', 'dzdso', 'Dz' ],
|
||
[ 'uca-hu', 'CSD', 'Cs' ],
|
||
[ 'uca-root', 'CSD', 'C' ],
|
||
[ 'uca-fi', 'Ǥ', 'G' ],
|
||
[ 'uca-fi', 'Ŧ', 'T' ],
|
||
[ 'uca-fi', 'Ʒ', 'Z' ],
|
||
[ 'uca-fi', 'Ŋ', 'N' ],
|
||
[ 'uppercase-ba', 'в', 'В' ],
|
||
];
|
||
}
|
||
}
|